Skip to content

Add z stream approvers for involved teams in MCO repo#23197

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sinnykumari:master
Nov 8, 2021
Merged

Add z stream approvers for involved teams in MCO repo#23197
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sinnykumari:master

Conversation

@sinnykumari
Copy link
Copy Markdown
Contributor

This PR is to add Dev and QE who can add backport-risk-assessed and cherry-pick-approved label respectively to the backported PRs owned by their team. This allows to better assess risk involved and QE capacity present for the respective team directly impacted.

Tried my best to get the list of users whom I can find are involved in respective teams from PR and z stream bugs. Feel free to add in the comment if you think someone else should be added. We are trying to keep this list short, so 1 or 2 members from each team will be ideal.

I wasn't sure about QE for some of the components, please add in comment if you know. Thanks!

Dev who can add backport-risk-assessed label to respectively owned sub-components in MCO repo:

  • rphillips (Node, kubelet)
  • umohnani8 (Node, cri-o)
  • jcpowermac (vSphere)
  • Prashanth684 (PowerVS)
  • kwoodson (Alibaba)
  • cybertron (Baremetal)
  • mandre (OpenStack)
  • Gal-Zaidman (ovirt)
  • trozet (Networking)

QE who can add cherry-pick-approved label to respectively owned sub-components in MCO repo

  • vvoronko (baremetal)
  • mburman5 (ovirt)
  • eurijon (openstack)
  • sunilcio (node)

/cc @rphillips @umohnani8 @jcpowermac @Prashanth684 @kwoodson @cybertron @mandre @Gal-Zaidman @trozet @vvoronko @mburman5 @eurijon @sunilcio

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 2, 2021

@sinnykumari: GitHub didn't allow me to request PR reviews from the following users: vvoronko.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

This PR is to add Dev and QE who can add backport-risk-assessed and cherry-pick-approved label respectively to the backported PRs owned by their team. This allows to better assess risk involved and QE capacity present for the respective team directly impacted.

Tried my best to get the list of users whom I can find are involved in respective teams from PR and z stream bugs. Feel free to add in the comment if you think someone else should be added. We are trying to keep this list short, so 1 or 2 members from each team will be ideal.

I wasn't sure about QE for some of the components, please add in comment if you know. Thanks!

Dev who can add backport-risk-assessed label to respectively owned sub-components in MCO repo:

  • rphillips (Node, kubelet)
  • umohnani8 (Node, cri-o)
  • jcpowermac (vSphere)
  • Prashanth684 (PowerVS)
  • kwoodson (Alibaba)
  • cybertron (Baremetal)
  • mandre (OpenStack)
  • Gal-Zaidman (ovirt)
  • trozet (Networking)

QE who can add cherry-pick-approved label to respectively owned sub-components in MCO repo

  • vvoronko (baremetal)
  • mburman5 (ovirt)
  • eurijon (openstack)
  • sunilcio (node)

/cc @rphillips @umohnani8 @jcpowermac @Prashanth684 @kwoodson @cybertron @mandre @Gal-Zaidman @trozet @vvoronko @mburman5 @eurijon @sunilcio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from kwoodson November 2, 2021 11:23
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2021
@sinnykumari
Copy link
Copy Markdown
Contributor Author

Added reviewers, PTAL

@rphillips
Copy link
Copy Markdown
Contributor

lgtm from a node perspective

@rphillips
Copy link
Copy Markdown
Contributor

@sinnykumari a vote to add mrunalp to the list as well.

@sinnykumari
Copy link
Copy Markdown
Contributor Author

sinnykumari commented Nov 3, 2021

@sinnykumari a vote to add mrunalp to the list as well.

I think since he is staff engineer, he already have that superpower https://github.com/openshift/release/blob/master/core-services/prow/02_config/openshift/machine-config-operator/_pluginconfig.yaml#L5

@umohnani8
Copy link
Copy Markdown
Contributor

LGTM

@Prashanth684
Copy link
Copy Markdown
Contributor

lgtm for PowerVS..thanks!

@cybertron
Copy link
Copy Markdown
Member

lgtm, thanks!

@Gal-Zaidman
Copy link
Copy Markdown
Contributor

LGTM thanks :)

@sinnykumari
Copy link
Copy Markdown
Contributor Author

PTAL @jcpowermac @kwoodson @trozet @vvoronko @mburman5 @eurijon
Planning to merge tomorrow.

@sinnykumari
Copy link
Copy Markdown
Contributor Author

/assign @kikisdeliveryservice

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

thanks sinny!

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e4914c9 into openshift:master Nov 8, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 8, 2021

@sinnykumari: Updated the plugins configmap in namespace ci at cluster app.ci using the following files:

  • key core-services-prow-02_config-openshift-machine-config-operator-_pluginconfig.yaml using file core-services/prow/02_config/openshift/machine-config-operator/_pluginconfig.yaml
Details

In response to this:

This PR is to add Dev and QE who can add backport-risk-assessed and cherry-pick-approved label respectively to the backported PRs owned by their team. This allows to better assess risk involved and QE capacity present for the respective team directly impacted.

Tried my best to get the list of users whom I can find are involved in respective teams from PR and z stream bugs. Feel free to add in the comment if you think someone else should be added. We are trying to keep this list short, so 1 or 2 members from each team will be ideal.

I wasn't sure about QE for some of the components, please add in comment if you know. Thanks!

Dev who can add backport-risk-assessed label to respectively owned sub-components in MCO repo:

  • rphillips (Node, kubelet)
  • umohnani8 (Node, cri-o)
  • jcpowermac (vSphere)
  • Prashanth684 (PowerVS)
  • kwoodson (Alibaba)
  • cybertron (Baremetal)
  • mandre (OpenStack)
  • Gal-Zaidman (ovirt)
  • trozet (Networking)

QE who can add cherry-pick-approved label to respectively owned sub-components in MCO repo

  • vvoronko (baremetal)
  • mburman5 (ovirt)
  • eurijon (openstack)
  • sunilcio (node)

/cc @rphillips @umohnani8 @jcpowermac @Prashanth684 @kwoodson @cybertron @mandre @Gal-Zaidman @trozet @vvoronko @mburman5 @eurijon @sunilcio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants