Skip to content

Conversation

@ecordell
Copy link
Contributor

@ecordell ecordell commented Dec 17, 2018

#2361 broke the src template:

/bin/bash: line 94: password: unbound variable

Based on the changes in #2361 I assume this patch will fix the problem.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 17, 2018
@sallyom
Copy link
Contributor

sallyom commented Dec 17, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2018
@sallyom
Copy link
Contributor

sallyom commented Dec 17, 2018

@wking can you approve this, please?

@wking
Copy link
Member

wking commented Dec 17, 2018

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, sallyom, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2018
@openshift-merge-robot openshift-merge-robot merged commit 5a1f19c into openshift:master Dec 17, 2018
@openshift-ci-robot
Copy link
Contributor

@ecordell: Updated the prow-job-cluster-launch-installer-src configmap using the following files:

  • key cluster-launch-installer-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml
Details

In response to this:

#2361 broke the src template:

/bin/bash: line 94: password: unbound variable

Based on the changes in #2361 I assume this patch will fix the problem.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants