openstack: set correct TEST_PROVIDER in e2e-test-commands#24212
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Dec 7, 2021
Merged
openstack: set correct TEST_PROVIDER in e2e-test-commands#24212openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci
Bot
added
the
approved
mandre
reviewed
Dec 2, 2021
Member
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
Much better than maintaining a list of tests to skip, thanks.
/lgtm
/hold for CI to come back
openshift-ci
Bot
added
the
do-not-merge/hold
openshift-ci
Bot
removed
lgtm
EmilienM
changed the title
Contributor
|
@EmilienM: The
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
reviewed
Dec 2, 2021
Member
Author
|
/retest |
EmilienM
force-pushed
the
proxy_skip
branch
7 times, most recently
from
2e164ab to
c6191ee
Compare
Member
Author
|
I don't know how to trigger the openstack-proxy job, but we'll need it to test this change. |
Member
You can make a dummy change to the proxy step to force the proxy job to run. |
mandre
reviewed
Dec 3, 2021
Member
Author
|
/retest-required |
Member
Author
|
/hold |
Member
Author
Member
Author
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
Instead of maintaining a long list of tests that we want to skip, let's configure the TEST_PROVIDER variable correctly so it'll re-use an existing list that knows what to skip from origin. This patch also removes the hardcoded list that we had.
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, EmilienM, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
|
@EmilienM: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
@EmilienM: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of maintaining a long list of tests that we want to skip, let's
configure the TEST_PROVIDER variable correctly so it'll re-use an
existing list that knows what to skip from origin.
This patch also removes the hardcoded list that we had.