Skip to content

Conversation

@iamemilio
Copy link
Contributor

Gets the MAPO CI Operator config in shape to be hooked up to ART.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2021
@openshift-ci openshift-ci bot requested review from mandre and mdbooth December 14, 2021 18:04
@iamemilio
Copy link
Contributor Author

Clarifying conversation occured here: https://coreos.slack.com/archives/CEKNRGF25/p1639507206317300

This will be squashed down to one commit

@petr-muller
Copy link
Member

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 14, 2021
@petr-muller
Copy link
Member

And now the both will do it for us

@iamemilio
Copy link
Contributor Author

thanks for all the help @petr-muller

@iamemilio
Copy link
Contributor Author

/assign @mandre

@EmilienM
Copy link
Member

/lgtm
/hold for ci

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2021
@iamemilio
Copy link
Contributor Author

/retest

@mandre
Copy link
Member

mandre commented Dec 15, 2021

Bootstrap failed and there's no must-gather. Is this because we're missing openshift/machine-api-provider-openstack#13?
/test pj-rehearse

@mandre
Copy link
Member

mandre commented Dec 15, 2021

I suspect openshift/machine-api-provider-openstack#12 broke it. It use to go past the bootstrap phase.

Edit: on second thoughts, it's weird since we're not using MAPO until after bootstrap machine has completed. It must be something else that broke it.

Edit 2: potentially fixed with openshift/installer#5484

@mandre
Copy link
Member

mandre commented Dec 15, 2021

/retest

@mandre
Copy link
Member

mandre commented Dec 15, 2021

This time it passed bootstrap \o/
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, iamemilio, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iamemilio
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

@iamemilio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/machine-api-provider-openstack/master/e2e-openstack 1efe6a1 link unknown /test pj-rehearse
ci/prow/pj-rehearse 1efe6a1 link false /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7ac5aea into openshift:master Dec 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

@iamemilio: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-api-provider-openstack-master.yaml using file ci-operator/config/openshift/machine-api-provider-openstack/openshift-machine-api-provider-openstack-master.yaml
  • job-config-master-postsubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-api-provider-openstack-master-postsubmits.yaml using file ci-operator/jobs/openshift/machine-api-provider-openstack/openshift-machine-api-provider-openstack-master-postsubmits.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-api-provider-openstack-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-api-provider-openstack/openshift-machine-api-provider-openstack-master-presubmits.yaml
Details

In response to this:

Gets the MAPO CI Operator config in shape to be hooked up to ART.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants