Skip to content

[QE][AWS] Add support for installing private&disconnected cluster #24888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 14, 2022
Merged

[QE][AWS] Add support for installing private&disconnected cluster #24888

openshift-merge-robot merged 1 commit into from
Apr 14, 2022

Conversation

@yunjiang29
Copy link
Contributor

@yunjiang29 yunjiang29 commented Dec 30, 2021 •
edited
Loading

Allow creating a cluster in a disconnected network:

chain:
  as: cucushift-installer-rehearse-aws-ipi-disconnected-private-provision
  steps:
    - ref: ipi-install-rbac
    - ref: openshift-cluster-bot-rbac
    - ref: aws-provision-vpc-disconnected
    - ref: aws-provision-bastionhost
    - ref: aws-provision-cco-manual-users-static
    - ref: mirror-images-by-oc-adm
    - ref: ipi-conf
    - ref: ipi-conf-mirror
    - ref: ipi-conf-aws-custom-vpc
    - ref: ipi-conf-manual-creds
    - ref: ipi-conf-aws
    - ref: ipi-install-monitoringpvc
    - ref: proxy-config-generate
    - ref: ipi-install-install-aws
    - ref: ipi-install-times-collection
  env:
  - name: ADD_INGRESS_RECORDS_MANUALLY
    default: "yes"
    documentation: "Enable manually create apps dns record."
  - name: PUBLISH
    default: "Internal"
    documentation: "Cluster publish strategy."

@openshift-ci openshift-ci bot requested review from gpei and jianlinliu December 30, 2021 04:35
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2022
@mhanss
Copy link
Contributor

mhanss commented Feb 7, 2022

@yunjiang29 we already have ci-operator/step-registry/ipi/aws folder in step-registry so the files created under aws folder can be moved to that location.

@jharmison-redhat jharmison-redhat mentioned this pull request Feb 16, 2022
Closed
@yunjiang29 yunjiang29 force-pushed the aws-disconnected-private branch from 9c08810 to c9022db Compare March 22, 2022 08:34
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 22, 2022
@yunjiang29 yunjiang29 changed the title Aws disconnected private [QE][AWS] Add support for installing private&disconnected cluster Mar 22, 2022
@yunjiang29 yunjiang29 force-pushed the aws-disconnected-private branch 4 times, most recently from b49746c to 88f54c4 Compare March 24, 2022 01:57
@yunjiang29 yunjiang29 mentioned this pull request Mar 24, 2022
Merged
@yunjiang29 yunjiang29 force-pushed the aws-disconnected-private branch 8 times, most recently from bbb48a5 to ef06df0 Compare March 25, 2022 04:24
@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Mar 25, 2022

/test pj-rehearse

1 similar comment
@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Mar 25, 2022

/test pj-rehearse

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Mar 26, 2022

/retest

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 26, 2022
@yunjiang29 yunjiang29 force-pushed the aws-disconnected-private branch 3 times, most recently from f7886af to 4b1c7a6 Compare March 30, 2022 09:47
@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Mar 30, 2022

/test pj-rehearse

1 similar comment
@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Mar 31, 2022

/test pj-rehearse

@yunjiang29 yunjiang29 force-pushed the aws-disconnected-private branch from c966e47 to 21143f3 Compare April 11, 2022 13:36
@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Apr 11, 2022

@jianli-wei @jianlinliu all comments have been addressed, PTAL, thanks.

@yunjiang29 yunjiang29 force-pushed the aws-disconnected-private branch from 21143f3 to 497ccf8 Compare April 11, 2022 15:01
@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Apr 12, 2022

/retest

jianlinliu
jianlinliu reviewed Apr 12, 2022
View reviewed changes
@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 13, 2022
@yunjiang29 yunjiang29 force-pushed the aws-disconnected-private branch from af1e0fe to 4842730 Compare April 13, 2022 06:59
@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Apr 13, 2022

@jianli-wei @jianlinliu PTAL

@jianlinliu
Copy link
Contributor

jianlinliu commented Apr 13, 2022

PR looks good to me, but seem like installer-rehearse-installer-rehearse-aws-disconnected-private job failed.

@yunjiang29 yunjiang29 force-pushed the aws-disconnected-private branch from 4842730 to b54ea4e Compare April 13, 2022 09:22
@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Apr 13, 2022

PR looks good to me, but seem like installer-rehearse-installer-rehearse-aws-disconnected-private job failed.

yes, it's a flake while pulling images, re-testing

jianli-wei
jianli-wei suggested changes Apr 13, 2022
View reviewed changes
.../aws/ipi/private/provision/cucushift-installer-rehearse-aws-ipi-private-provision-chain.yaml Outdated
Copy link
Contributor

@jianli-wei jianli-wei Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just "aws-provision-vpc"?

Copy link
Contributor Author

@yunjiang29 yunjiang29 Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following some kinds of manner, we call it customer/existing/shared VPCs

.../aws/ipi/private/provision/cucushift-installer-rehearse-aws-ipi-private-provision-chain.yaml Outdated
Copy link
Contributor

@jianli-wei jianli-wei Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In GCP, the step "gcp-provision-vpc" would write gcp network settings into file "${SHARED_DIR}/customer_vpc_subnets.yaml", which would be used in the step "ipi-conf-gcp". The questions, is it really necessary to add the step "ipi-conf-aws-custom-vpc" besides the existing step "ipi-conf-aws"?

Copy link
Contributor Author

@yunjiang29 yunjiang29 Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does an option, I'd like to keep the step as simple as possible, ipi-conf-aws-custom-vpc just focus on subnets/AZs' settings.

...ate/provision/cucushift-installer-rehearse-aws-ipi-disconnected-private-provision-chain.yaml Outdated
Copy link
Contributor

@jianli-wei jianli-wei Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about renaming as "aws-provision-static-iam-users" (i.e. remove the word "cco-manual")?

Copy link
Contributor Author

@yunjiang29 yunjiang29 Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cco-manual means these users are for CCO in manual mode, I think it's more clear.

@yunjiang29 yunjiang29 force-pushed the aws-disconnected-private branch from b54ea4e to b740442 Compare April 13, 2022 10:19
@jianlinliu
Copy link
Contributor

jianlinliu commented Apr 14, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2022
@jianli-wei
Copy link
Contributor

jianli-wei commented Apr 14, 2022

/lgtm

@yunjiang29 yunjiang29 force-pushed the aws-disconnected-private branch from b740442 to 2a5e339 Compare April 14, 2022 03:32
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2022

@yunjiang29: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/machine-config-operator/release-4.9/e2e-gcp-single-node 7369260bc303def889af810009a8cf8d47dbbc4a link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-verification-tests-master-installer-rehearse-installer-rehearse-aws 9c088102f3c4eaaf56a7dd213944762feaa07a48 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-storage-operator/release-4.11/e2e-azure-file-csi 9c088102f3c4eaaf56a7dd213944762feaa07a48 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-ovn-kubernetes-release-4.11-e2e-ibmcloud-ipi-ovn-periodic 9c088102f3c4eaaf56a7dd213944762feaa07a48 link unknown /test pj-rehearse
ci/build-farm/build03-dry 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test build03-dry
ci/build-farm/app-ci-config-dry 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test app-ci-config-dry
ci/build-farm/build01-dry 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test build01-dry
ci/build-farm/build04-dry 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test build04-dry
ci/build-farm/hive-dry 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test hive-dry
ci/prow/ci-secret-bootstrap-config-validation 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test ci-secret-bootstrap-config-validation
ci/prow/boskos-config-generation 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test boskos-config-generation
ci/prow/boskos-config 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test boskos-config
ci/build-farm/build02-dry 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test build02-dry
ci/prow/ci-testgrid-allow-list 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test ci-testgrid-allow-list
ci/prow/prow-config 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test prow-config
ci/prow/generated-dashboards 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test generated-dashboards
ci/prow/release-config 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test release-config
ci/prow/secret-generator-config-valid 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test secret-generator-config-valid
ci/prow/release-controller-config 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test release-controller-config
ci/prow/services-valid 9c088102f3c4eaaf56a7dd213944762feaa07a48 link true /test services-valid
ci/rehearse/openshift/k8s-prometheus-adapter/master/e2e-agnostic-cmo f3a48a5710e8b6a048fe7726cd17ae3887f5937f link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-capi-operator/main/e2e-aws-capi-techpreview f3a48a5710e8b6a048fe7726cd17ae3887f5937f link unknown /test pj-rehearse
ci/rehearse/openshift/vmware-vsphere-csi-driver-operator/master/e2e-vsphere-csi f3a48a5710e8b6a048fe7726cd17ae3887f5937f link unknown /test pj-rehearse
ci/rehearse/openshift/vmware-vsphere-csi-driver/master/e2e-vsphere-csi 383acdf164f0b400cf338909fbfe8d339cf2fe68 link unknown /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.5/e2e-ovirt 383acdf164f0b400cf338909fbfe8d339cf2fe68 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-multiarch-master-nightly-4.11-ocp-e2e-aws-upi-arm64 383acdf164f0b400cf338909fbfe8d339cf2fe68 link unknown /test pj-rehearse
ci/rehearse/openshift/vmware-vsphere-csi-driver/master/e2e-vsphere 383acdf164f0b400cf338909fbfe8d339cf2fe68 link unknown /test pj-rehearse
ci/rehearse/redhat-openshift-ecosystem/community-operators-pipeline/main/4.8-pipeline-functionality b49746cf12b88f10af3beb3df074e425e54e0f1f link unknown /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-alibaba b49746cf12b88f10af3beb3df074e425e54e0f1f link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-machine-approver/master/e2e-aws-capi-techpreview b49746cf12b88f10af3beb3df074e425e54e0f1f link unknown /test pj-rehearse
ci/rehearse/openshift/aws-pod-identity-webhook/master/e2e-aws 88f54c4d62735ddf2901ba9d4a535585ec229dab link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-csi-snapshot-controller-operator/master/e2e-upgrade d9363d4c41435b232f2b8a5b6a1a3dc9e9a66a7b link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-csi-snapshot-controller-operator/master/e2e-aws d9363d4c41435b232f2b8a5b6a1a3dc9e9a66a7b link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-kube-scheduler-operator/master/e2e-aws-operator ef06df053ad4c4ce5ddbabf0b84f4c3fa414741d link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-kube-scheduler-operator/master/e2e-aws-serial ef06df053ad4c4ce5ddbabf0b84f4c3fa414741d link unknown /test pj-rehearse
ci/rehearse/openshift/cincinnati-graph-data/master/e2e-latest-cincinnati ef06df053ad4c4ce5ddbabf0b84f4c3fa414741d link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-storage-operator/master/e2e-aws-shared-resources ef06df053ad4c4ce5ddbabf0b84f4c3fa414741d link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-kube-scheduler-operator/master/e2e-aws ef06df053ad4c4ce5ddbabf0b84f4c3fa414741d link unknown /test pj-rehearse
ci/rehearse/openshift/azure-file-csi-driver/master/e2e-azure-file-nfs-csi 6c7b3bdfa01e75d974acc7fda795853aa4897f97 link unknown /test pj-rehearse
ci/rehearse/openshift/ovn-kubernetes/master/okd-e2e-gcp-ovn 6c7b3bdfa01e75d974acc7fda795853aa4897f97 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-kata-containers-kata-containers-main-e2e-tests 184bc63c3642ac3f3f73520c456d2bf48982fe0a link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/master/e2e-azure-ovn-dualstack 5c02582f6851519be76a220acd7fc9010cd33ee6 link unknown /test pj-rehearse
ci/rehearse/openshift/aws-ebs-csi-driver-operator/master/e2e-aws-csi-migration 4b1c7a6fe3f032e4d68fa5e087fc126b9199b548 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-api-provider-ovirt/release-4.5/e2e-ovirt 4b1c7a6fe3f032e4d68fa5e087fc126b9199b548 link unknown /test pj-rehearse
ci/rehearse/openshift/origin/master/e2e-aws-disruptive 9ec76ef3b2e7de09bb1df0ecf6fd31d2673ee5a3 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-verification-tests-master-installer-rehearse-installer-rehearse-aws-disconnected 8ab0b609260c101f44743eaaaf01d90d4c7d0466 link unknown /test pj-rehearse
ci/rehearse/openshift/cloud-provider-gcp/master/e2e-gcp-ccm-install 5f9fd803298d5e1ceec9b9deda560f4318af9463 link unknown /test pj-rehearse
ci/rehearse/openshift/image-registry/master/e2e-aws-image-registry 5f9fd803298d5e1ceec9b9deda560f4318af9463 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-logging-operator/release-4.8/e2e-operator 5f9fd803298d5e1ceec9b9deda560f4318af9463 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-logging-operator/master/e2e 5f9fd803298d5e1ceec9b9deda560f4318af9463 link unknown /test pj-rehearse
ci/rehearse/kubevirt/hyperconverged-cluster-operator/main/hco-e2e-image-index-sno-aws 89b1a0173afeaf9599498f802ccdb52c60b4ce20 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-api-provider-openstack/master/e2e-openstack-proxy 5f9fd803298d5e1ceec9b9deda560f4318af9463 link unknown /test pj-rehearse
ci/rehearse/openshift/csi-driver-shared-resource-operator/master/e2e-aws-techpreview 5f9fd803298d5e1ceec9b9deda560f4318af9463 link unknown /test pj-rehearse
ci/rehearse/openshift/cloud-provider-gcp/master/e2e-gcp-ccm 5f9fd803298d5e1ceec9b9deda560f4318af9463 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/master/e2e-aws-ccm-install 76109b269be1e3c813ec0ad127edbbcd821a8389 link unknown /test pj-rehearse
ci/rehearse/openshift/ovn-kubernetes/master/e2e-aws-ovn-local-to-shared-gateway-mode-migration 5f11913b92e30a650eb8921e010bbf3df72a6b73 link unknown /test pj-rehearse
ci/rehearse/okd-virtualization/release/master/okd-pres-e2e-deploy f6f2ec0c9a65ae3c5ecd438d7273669407d9a97e link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/master/e2e-aws-ccm 76109b269be1e3c813ec0ad127edbbcd821a8389 link unknown /test pj-rehearse
ci/rehearse/openshift/machine-api-operator/master/e2e-aws-disruptive f6f2ec0c9a65ae3c5ecd438d7273669407d9a97e link unknown /test pj-rehearse
ci/rehearse/openshift/origin/master/okd-e2e-gcp 5f11913b92e30a650eb8921e010bbf3df72a6b73 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/master/e2e-azure 76109b269be1e3c813ec0ad127edbbcd821a8389 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/master/e2e-azure-ccm 76109b269be1e3c813ec0ad127edbbcd821a8389 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-kubevirt-kubevirt-main-0.36_4.7-e2e-default 76109b269be1e3c813ec0ad127edbbcd821a8389 link unknown /test pj-rehearse
ci/rehearse/openshift/prom-label-proxy/master/e2e-agnostic-cmo 497ccf89fde55273ec2a5a011a03b8ad3808507b link unknown /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-ovn-workers-rhel8 497ccf89fde55273ec2a5a011a03b8ad3808507b link unknown /test pj-rehearse
ci/rehearse/red-hat-storage/odf-operator/main/odf-operator-bundle-e2e-aws 21143f3466bd2b7f35dcd5bfc6861fb135d0a118 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-api-provider-aws/master/e2e-aws c966e47940806e7c4544836cde078b7020328a34 link unknown /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-gcp-single-node 497ccf89fde55273ec2a5a011a03b8ad3808507b link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-image-registry-operator/master/e2e-aws-image-registry 497ccf89fde55273ec2a5a011a03b8ad3808507b link unknown /test pj-rehearse
ci/rehearse/openshift/origin/release-4.5/e2e-aws-csi c966e47940806e7c4544836cde078b7020328a34 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-samples-operator/master/okd-e2e-aws-jenkins 21143f3466bd2b7f35dcd5bfc6861fb135d0a118 link unknown /test pj-rehearse
ci/rehearse/openshift/alibaba-cloud-csi-driver/master/e2e-alibabacloud-disk-csi 497ccf89fde55273ec2a5a011a03b8ad3808507b link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-insights-operator-master-insights-operator-e2e-tests-periodic 497ccf89fde55273ec2a5a011a03b8ad3808507b link unknown /test pj-rehearse
ci/rehearse/periodic-ci-opendatahub-io-odh-manifests-master-48-odh-manifests-e2e-nightly-48 497ccf89fde55273ec2a5a011a03b8ad3808507b link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-dns-operator/master/e2e-aws-single-node 21143f3466bd2b7f35dcd5bfc6861fb135d0a118 link unknown /test pj-rehearse
ci/rehearse/openshift/installer/master/okd-e2e-vsphere af1e0fed85035e7bc3fdb63334239d7ccb1708d1 link unknown /test pj-rehearse
ci/rehearse/openshift/installer/master/okd-e2e-gcp-upgrade af1e0fed85035e7bc3fdb63334239d7ccb1708d1 link unknown /test pj-rehearse
ci/rehearse/openshift/csi-node-driver-registrar/master/e2e-gcp-csi af1e0fed85035e7bc3fdb63334239d7ccb1708d1 link unknown /test pj-rehearse
ci/rehearse/openshift/csi-livenessprobe/release-4.5/e2e-aws-csi b740442c978f00a1f3279cd62e37eee109a7761f link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-hypershift-main-periodics-e2e-conformance-azure b740442c978f00a1f3279cd62e37eee109a7761f link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-multiarch-master-nightly-4.10-ocp-e2e-aws-upi-arm64 484273005643156f4b3152f272ed913742b7d884 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-hypershift-main-periodics-e2e-conformance-proxy b740442c978f00a1f3279cd62e37eee109a7761f link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jianlinliu
Copy link
Contributor

jianlinliu commented Apr 14, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2022
@droslean
Copy link
Member

droslean commented Apr 14, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, jianli-wei, jianlinliu, yunjiang29

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2022
@openshift-merge-robot openshift-merge-robot merged commit af8636d into openshift:master Apr 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2022

@yunjiang29: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-verification-tests-master__installer-rehearse.yaml using file ci-operator/config/openshift/verification-tests/openshift-verification-tests-master__installer-rehearse.yaml
  • job-config-master-periodics configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-verification-tests-master-periodics.yaml using file ci-operator/jobs/openshift/verification-tests/openshift-verification-tests-master-periodics.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key aws-deprovision-bastionhost-commands.sh using file ``
    • key OWNERS using file ci-operator/step-registry/aws/deprovision/cco-manual-users/OWNERS
    • key OWNERS using file ci-operator/step-registry/aws/deprovision/cco-manual-users/static/OWNERS
    • key aws-deprovision-cco-manual-users-static-commands.sh using file ci-operator/step-registry/aws/deprovision/cco-manual-users/static/aws-deprovision-cco-manual-users-static-commands.sh
    • key aws-deprovision-cco-manual-users-static-ref.metadata.json using file ci-operator/step-registry/aws/deprovision/cco-manual-users/static/aws-deprovision-cco-manual-users-static-ref.metadata.json
    • key aws-deprovision-bastionhost-ref.yaml using file ``
    • key aws-deprovision-cco-manual-users-static-ref.yaml using file ci-operator/step-registry/aws/deprovision/cco-manual-users/static/aws-deprovision-cco-manual-users-static-ref.yaml
    • key OWNERS using file ``
    • key OWNERS using file ci-operator/step-registry/aws/deprovision/s3buckets/OWNERS
    • key aws-deprovision-s3buckets-commands.sh using file ci-operator/step-registry/aws/deprovision/s3buckets/aws-deprovision-s3buckets-commands.sh
    • key aws-deprovision-bastionhost-ref.metadata.json using file ``
    • key aws-deprovision-s3buckets-ref.metadata.json using file ci-operator/step-registry/aws/deprovision/s3buckets/aws-deprovision-s3buckets-ref.metadata.json
    • key aws-deprovision-s3buckets-ref.yaml using file ci-operator/step-registry/aws/deprovision/s3buckets/aws-deprovision-s3buckets-ref.yaml
    • key OWNERS using file ``
    • key OWNERS using file ci-operator/step-registry/aws/deprovision/stacks/OWNERS
    • key aws-deprovision-stacks-commands.sh using file ci-operator/step-registry/aws/deprovision/stacks/aws-deprovision-stacks-commands.sh
    • key aws-deprovision-vpc-ref.metadata.json using file ``
    • key aws-deprovision-stacks-ref.metadata.json using file ci-operator/step-registry/aws/deprovision/stacks/aws-deprovision-stacks-ref.metadata.json
    • key aws-deprovision-vpc-ref.yaml using file ``
    • key aws-deprovision-stacks-ref.yaml using file ci-operator/step-registry/aws/deprovision/stacks/aws-deprovision-stacks-ref.yaml
    • key aws-deprovision-vpc-commands.sh using file ``
    • key aws-provision-bastionhost-commands.sh using file ci-operator/step-registry/aws/provision/bastionhost/aws-provision-bastionhost-commands.sh
    • key OWNERS using file ci-operator/step-registry/aws/provision/cco-manual-users/OWNERS
    • key OWNERS using file ci-operator/step-registry/aws/provision/cco-manual-users/static/OWNERS
    • key aws-provision-cco-manual-users-static-commands.sh using file ci-operator/step-registry/aws/provision/cco-manual-users/static/aws-provision-cco-manual-users-static-commands.sh
    • key aws-provision-cco-manual-users-static-ref.metadata.json using file ci-operator/step-registry/aws/provision/cco-manual-users/static/aws-provision-cco-manual-users-static-ref.metadata.json
    • key aws-provision-cco-manual-users-static-ref.yaml using file ci-operator/step-registry/aws/provision/cco-manual-users/static/aws-provision-cco-manual-users-static-ref.yaml
    • key OWNERS using file ci-operator/step-registry/aws/provision/vpc/disconnected/OWNERS
    • key aws-provision-vpc-disconnected-commands.sh using file ci-operator/step-registry/aws/provision/vpc/disconnected/aws-provision-vpc-disconnected-commands.sh
    • key aws-provision-vpc-disconnected-ref.metadata.json using file ci-operator/step-registry/aws/provision/vpc/disconnected/aws-provision-vpc-disconnected-ref.metadata.json
    • key aws-provision-vpc-disconnected-ref.yaml using file ci-operator/step-registry/aws/provision/vpc/disconnected/aws-provision-vpc-disconnected-ref.yaml
    • key aws-provision-vpc-shared-commands.sh using file ci-operator/step-registry/aws/provision/vpc/shared/aws-provision-vpc-shared-commands.sh
    • key OWNERS using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/disconnected/OWNERS
    • key OWNERS using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/disconnected/private/OWNERS
    • key cucushift-installer-rehearse-aws-ipi-disconnected-private-workflow.metadata.json using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/disconnected/private/cucushift-installer-rehearse-aws-ipi-disconnected-private-workflow.metadata.json
    • key cucushift-installer-rehearse-aws-ipi-disconnected-private-workflow.yaml using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/disconnected/private/cucushift-installer-rehearse-aws-ipi-disconnected-private-workflow.yaml
    • key OWNERS using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/disconnected/private/deprovision/OWNERS
    • key cucushift-installer-rehearse-aws-ipi-disconnected-private-deprovision-chain.metadata.json using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/disconnected/private/deprovision/cucushift-installer-rehearse-aws-ipi-disconnected-private-deprovision-chain.metadata.json
    • key cucushift-installer-rehearse-aws-ipi-disconnected-private-deprovision-chain.yaml using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/disconnected/private/deprovision/cucushift-installer-rehearse-aws-ipi-disconnected-private-deprovision-chain.yaml
    • key OWNERS using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/disconnected/private/provision/OWNERS
    • key cucushift-installer-rehearse-aws-ipi-disconnected-private-provision-chain.metadata.json using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/disconnected/private/provision/cucushift-installer-rehearse-aws-ipi-disconnected-private-provision-chain.metadata.json
    • key cucushift-installer-rehearse-aws-ipi-disconnected-private-provision-chain.yaml using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/disconnected/private/provision/cucushift-installer-rehearse-aws-ipi-disconnected-private-provision-chain.yaml
    • key cucushift-installer-rehearse-aws-ipi-private-deprovision-chain.yaml using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/private/deprovision/cucushift-installer-rehearse-aws-ipi-private-deprovision-chain.yaml
    • key cucushift-installer-rehearse-aws-ipi-private-provision-chain.yaml using file ci-operator/step-registry/cucushift/installer/rehearse/aws/ipi/private/provision/cucushift-installer-rehearse-aws-ipi-private-provision-chain.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/conf/aws/custom-vpc/OWNERS
    • key ipi-conf-aws-custom-vpc-commands.sh using file ci-operator/step-registry/ipi/conf/aws/custom-vpc/ipi-conf-aws-custom-vpc-commands.sh
    • key ipi-conf-aws-custom-vpc-ref.metadata.json using file ci-operator/step-registry/ipi/conf/aws/custom-vpc/ipi-conf-aws-custom-vpc-ref.metadata.json
    • key ipi-conf-aws-custom-vpc-ref.yaml using file ci-operator/step-registry/ipi/conf/aws/custom-vpc/ipi-conf-aws-custom-vpc-ref.yaml
    • key ipi-conf-aws-privatecluster-commands.sh using file ``
    • key ipi-conf-aws-privatecluster-ref.yaml using file ``
    • key OWNERS using file ci-operator/step-registry/ipi/conf/mirror/OWNERS
    • key ipi-conf-mirror-commands.sh using file ci-operator/step-registry/ipi/conf/mirror/ipi-conf-mirror-commands.sh
    • key ipi-conf-mirror-ref.metadata.json using file ci-operator/step-registry/ipi/conf/mirror/ipi-conf-mirror-ref.metadata.json
    • key ipi-conf-mirror-ref.yaml using file ci-operator/step-registry/ipi/conf/mirror/ipi-conf-mirror-ref.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/install/install/aws/OWNERS
    • key ipi-install-install-aws-commands.sh using file ci-operator/step-registry/ipi/install/install/aws/ipi-install-install-aws-commands.sh
    • key ipi-install-install-aws-ref.metadata.json using file ci-operator/step-registry/ipi/install/install/aws/ipi-install-install-aws-ref.metadata.json
    • key ipi-install-install-aws-ref.yaml using file ci-operator/step-registry/ipi/install/install/aws/ipi-install-install-aws-ref.yaml
    • key OWNERS using file ``
    • key OWNERS using file ci-operator/step-registry/mirror-images/OWNERS
    • key OWNERS using file ci-operator/step-registry/mirror-images/by-oc-adm/OWNERS
    • key mirror-images-by-oc-adm-commands.sh using file ci-operator/step-registry/mirror-images/by-oc-adm/mirror-images-by-oc-adm-commands.sh
    • key ipi-conf-aws-privatecluster-ref.metadata.json using file ``
    • key mirror-images-by-oc-adm-ref.metadata.json using file ci-operator/step-registry/mirror-images/by-oc-adm/mirror-images-by-oc-adm-ref.metadata.json
    • key mirror-images-by-oc-adm-ref.yaml using file ci-operator/step-registry/mirror-images/by-oc-adm/mirror-images-by-oc-adm-ref.yaml
Details

In response to this:

Allow creating a cluster in a disconnected network:

chain:
 as: cucushift-installer-rehearse-aws-ipi-disconnected-private-provision
 steps:
   - ref: ipi-install-rbac
   - ref: openshift-cluster-bot-rbac
   - ref: aws-provision-vpc-disconnected
   - ref: aws-provision-bastionhost
   - ref: aws-provision-cco-manual-users-static
   - ref: mirror-images-by-oc-adm
   - ref: ipi-conf
   - ref: ipi-conf-mirror
   - ref: ipi-conf-aws-custom-vpc
   - ref: ipi-conf-manual-creds
   - ref: ipi-conf-aws
   - ref: ipi-install-monitoringpvc
   - ref: proxy-config-generate
   - ref: ipi-install-install-aws
   - ref: ipi-install-times-collection
 env:
 - name: ADD_INGRESS_RECORDS_MANUALLY
   default: "yes"
   documentation: "Enable manually create apps dns record."
 - name: PUBLISH
   default: "Internal"
   documentation: "Cluster publish strategy."

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yunjiang29 yunjiang29 deleted the aws-disconnected-private branch April 14, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpei gpei Awaiting requested review from gpei

2 more reviewers

@jianlinliu jianlinliu jianlinliu left review comments

@jianli-wei jianli-wei jianli-wei requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jianlinliu jianlinliu

@jianli-wei jianli-wei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yunjiang29 @mhanss @jianlinliu @jianli-wei @droslean @openshift-merge-robot