Skip to content

Add tests for Alibaba Disk CSI driver operator #25815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Feb 25, 2022
Merged

Add tests for Alibaba Disk CSI driver operator #25815

openshift-merge-robot merged 2 commits into from
Feb 25, 2022

Conversation

@jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Jan 31, 2022 •
edited
Loading

CSI driver tests need a YAML manifest with definition of supported features to run openshift-tests binary. This manifest is in the alibaba-disk-csi-driver-operator github repo, but we will need it in tests for other repos (like the driver itself). To be able to find / use the manifest in the other repos, we need to:

  • Distribute the driver test manifest.yaml as image alibaba-disk-csi-driver-operator-test.
  • Add a step to copy the manifest from the image to $SHARED_DIR.
  • Add workflow to install a cluster + copy the manifest to $SHARED_DIR (via the step above) + run the tests (that already knows where the manifest is in $SHARED_DIR.

@openshift-ci openshift-ci bot requested review from dobsonj and gnufied January 31, 2022 13:59
@jsafrane
Copy link
Contributor Author

jsafrane commented Jan 31, 2022

/retest

1 similar comment
@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 1, 2022

/retest

@jsafrane jsafrane force-pushed the add-alibaba-csi-driver-image branch from a1233a9 to 4351bd2 Compare February 1, 2022 09:11
@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 1, 2022

/hold
It's not possible to install a cluster

: Run multi-stage test e2e-alibabacloud-disk-csi - e2e-alibabacloud-disk-csi-ipi-conf-alibabacloud container test expand_less | 0s
-- | --
Alibaba region: us-west-2 /bin/bash: line 18: CI_RESOURCE_GROUP_ID: unbound variable

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2022
@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 2, 2022

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 3, 2022

daily check if Aliabab works ;-)
/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 4, 2022

/retest

6 similar comments
@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 7, 2022

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 7, 2022

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 8, 2022

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 9, 2022

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 10, 2022

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 14, 2022

/retest

@jsafrane jsafrane force-pushed the add-alibaba-csi-driver-image branch from 4351bd2 to 1963337 Compare February 21, 2022 09:26
@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 22, 2022

/retest

@jsafrane jsafrane force-pushed the add-alibaba-csi-driver-image branch 2 times, most recently from 277833b to 1c66d09 Compare February 22, 2022 12:18
@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 22, 2022

/retest

1 similar comment
@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 22, 2022

/retest

@jsafrane jsafrane force-pushed the add-alibaba-csi-driver-image branch from 1c66d09 to 4d61877 Compare February 22, 2022 17:37
@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 23, 2022

/retest

@jsafrane jsafrane force-pushed the add-alibaba-csi-driver-image branch from 49dbfd7 to 7e17ef2 Compare February 23, 2022 11:01
@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 23, 2022

/retest

1 similar comment
@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 23, 2022

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 24, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2022
@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 24, 2022

The tests fail in gather-alibabacloud-console step, which is unrelated to CSI. The same test fails in other Alibaba e2e tests: openshift/installer#5604 / https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_installer/5604/pull-ci-openshift-installer-master-e2e-alibaba/1496424012073406464

@jsafrane
Add tests for Alibaba Disk CSI driver operator
b00be54 
* Distribute an image with the driver test manifest.yaml as image alibaba-disk-csi-driver-operator-test.
* Add steps to copy the manifest from the image to $SHARED_DIR.
* Add workflow to install a cluster + copy the manifest to $SHARED_DIR + run the tests.
@jsafrane
Add e2e tests to Alibaba CSI driver repo
d242574
@jsafrane jsafrane force-pushed the add-alibaba-csi-driver-image branch from 7e17ef2 to d242574 Compare February 24, 2022 16:21
@jsafrane
Copy link
Contributor Author

jsafrane commented Feb 24, 2022

I'm marking the tests as optional until the console is fixed.

bertinatto
bertinatto reviewed Feb 25, 2022
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2022
kwoodson
kwoodson approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@kwoodson kwoodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bparees
Copy link
Contributor

bparees commented Feb 25, 2022

image name looks fine
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, bparees, jsafrane, kwoodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2022

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/alibaba-disk-csi-driver-operator/release-4.10/images a1233a9d490070a48e581168c99c9a74e93f4c12 link unknown /test pj-rehearse
ci/prow/prow-config 277833be8ceaf7d3e7ab47365173f54146b22514 link true /test prow-config
ci/rehearse/openshift/alibaba-cloud-csi-driver/master/e2e-alibabacloud-disk-csi d242574 link unknown /test pj-rehearse
ci/prow/pj-rehearse d242574 link false /test pj-rehearse
ci/rehearse/openshift/alibaba-disk-csi-driver-operator/master/e2e-alibabacloud-disk-csi d242574 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6c6f33c into openshift:master Feb 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2022

@jsafrane: Updated the following 4 configmaps:

  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/alibabacloud/disk-csi/OWNERS
    • key openshift-e2e-alibabacloud-disk-csi-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/alibabacloud/disk-csi/openshift-e2e-alibabacloud-disk-csi-workflow.metadata.json
    • key openshift-e2e-alibabacloud-disk-csi-workflow.yaml using file ci-operator/step-registry/openshift/e2e/alibabacloud/disk-csi/openshift-e2e-alibabacloud-disk-csi-workflow.yaml
    • key OWNERS using file ci-operator/step-registry/storage/conf/csi-alibaba-disk/OWNERS
    • key storage-conf-csi-alibaba-disk-commands.sh using file ci-operator/step-registry/storage/conf/csi-alibaba-disk/storage-conf-csi-alibaba-disk-commands.sh
    • key storage-conf-csi-alibaba-disk-ref.metadata.json using file ci-operator/step-registry/storage/conf/csi-alibaba-disk/storage-conf-csi-alibaba-disk-ref.metadata.json
    • key storage-conf-csi-alibaba-disk-ref.yaml using file ci-operator/step-registry/storage/conf/csi-alibaba-disk/storage-conf-csi-alibaba-disk-ref.yaml
  • image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:
    • key mapping_origin_4_11 using file core-services/image-mirroring/openshift/mapping_origin_4_11
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-alibaba-cloud-csi-driver-master.yaml using file ci-operator/config/openshift/alibaba-cloud-csi-driver/openshift-alibaba-cloud-csi-driver-master.yaml
    • key openshift-alibaba-disk-csi-driver-operator-master.yaml using file ci-operator/config/openshift/alibaba-disk-csi-driver-operator/openshift-alibaba-disk-csi-driver-operator-master.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-alibaba-cloud-csi-driver-master-presubmits.yaml using file ci-operator/jobs/openshift/alibaba-cloud-csi-driver/openshift-alibaba-cloud-csi-driver-master-presubmits.yaml
    • key openshift-alibaba-disk-csi-driver-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/alibaba-disk-csi-driver-operator/openshift-alibaba-disk-csi-driver-operator-master-presubmits.yaml
Details

In response to this:

CSI driver tests need a YAML manifest with definition of supported features to run openshift-tests binary. This manifest is in the alibaba-disk-csi-driver-operator github repo, but we will need it in tests for other repos (like the driver itself). To be able to find / use the manifest in the other repos, we need to:

  • Distribute the driver test manifest.yaml as image alibaba-disk-csi-driver-operator-test.
  • Add a step to copy the manifest from the image to $SHARED_DIR.
  • Add workflow to install a cluster + copy the manifest to $SHARED_DIR (via the step above) + run the tests (that already knows where the manifest is in $SHARED_DIR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dobsonj dobsonj Awaiting requested review from dobsonj

@gnufied gnufied Awaiting requested review from gnufied

2 more reviewers

@bertinatto bertinatto bertinatto left review comments

@kwoodson kwoodson kwoodson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bertinatto bertinatto

@kwoodson kwoodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jsafrane @bparees @openshift-bot @bertinatto @kwoodson @openshift-merge-robot