knative-eventing: lower resource requests#26101
Merged
Merged
Conversation
openshift-ci
Bot
added
the
approved
petr-muller
force-pushed
the
knative-cpus
branch
from
c9b9f4a to
07e9a12
Compare
Member
Author
|
/test pj-rehearse |
1 similar comment
Member
|
/test pj-rehearse |
knative-eventing requests are very high (OpenShift CI clusters' workers have 16CPUs so can basically fit just three Pods that request 4 CPUs) and its jobs spawn a lot of pods (mostly image builds). This causes massive scale-up events in OpenShift CI (easily 150+ instances) which are not actually necessary because the pods do not actually consume that many resources. For some time, OpenShift CI has [pod-scaler](https://resources.ci.openshift.org) which automatically sets requests to a .8 quantile of the consumption peak of that workload if that value is higher than whatever is set in the ci-operator config, so lowering these resources should not result in any resource-related problems.
petr-muller
force-pushed
the
knative-cpus
branch
from
07e9a12 to
01a00b4
Compare
Member
Author
|
Retrying of infrastructure-failed builds (openshift/ci-tools#2659) kicked in, good |
Member
|
This seems related from https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/26101/rehearse-26101-pull-ci-openshift-knative-eventing-release-v1.1-47-e2e-aws-ocp-47/1491440007888506880: |
Member
Author
|
Yes, that's possible - the samples for that specific image build are a little all over the place but if they are consistently high then |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@petr-muller: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
@petr-muller: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pierDipi
added a commit
to pierDipi/eventing
that referenced
this pull request
Feb 14, 2022
See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot
pushed a commit
to openshift/knative-eventing
that referenced
this pull request
Feb 14, 2022
See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/knative-eventing
that referenced
this pull request
Feb 14, 2022
See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/knative-eventing
that referenced
this pull request
Feb 14, 2022
See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/knative-eventing
that referenced
this pull request
Feb 14, 2022
See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/knative-eventing
that referenced
this pull request
Feb 14, 2022
See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/knative-eventing
that referenced
this pull request
Feb 14, 2022
See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot
pushed a commit
to openshift/knative-eventing
that referenced
this pull request
Feb 14, 2022
See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Feb 14, 2022
Same as: openshift/knative-eventing@a94c97b See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot
pushed a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Feb 14, 2022
Same as: openshift/knative-eventing@a94c97b See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/eventing-kafka-broker
that referenced
this pull request
Feb 14, 2022
Same as: openshift/knative-eventing@a94c97b See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/eventing-kafka-broker
that referenced
this pull request
Feb 14, 2022
Same as: openshift/knative-eventing@a94c97b See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot
pushed a commit
to openshift/knative-eventing
that referenced
this pull request
Feb 14, 2022
See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot
pushed a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Feb 14, 2022
Same as: openshift/knative-eventing@a94c97b See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot
pushed a commit
to openshift/knative-eventing
that referenced
this pull request
Feb 14, 2022
See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot
pushed a commit
to openshift/knative-eventing
that referenced
this pull request
Feb 15, 2022
See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Feb 15, 2022
Same as: openshift/knative-eventing@a94c97b See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot
pushed a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Feb 15, 2022
Same as: openshift/knative-eventing@a94c97b See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/eventing-kafka-broker
that referenced
this pull request
Feb 15, 2022
Same as: openshift/knative-eventing@a94c97b See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot
pushed a commit
to openshift/knative-eventing
that referenced
this pull request
Feb 15, 2022
See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot
pushed a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Feb 15, 2022
Same as: openshift/knative-eventing@a94c97b See openshift/release#26101 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
knative-eventing requests are very high (OpenShift CI clusters' workers have 16CPUs so can basically fit just three Pods that request 4 CPUs) and its jobs spawn a lot of pods (mostly image builds). This causes massive scale-up events in OpenShift CI (easily 150+ instances) which are not actually necessary because the pods do not actually consume that many resources.
For some time, OpenShift CI has pod-scaler which automatically sets requests to a .8 quantile of the consumption peak of that workload if that value is higher than whatever is set in the ci-operator config, so lowering these resources should not result in any resource-related problems.
For example, the
binbuild of therelease-next__48builds is known to consume around 2.5CPU so that value would be dynamically set to that Pod./cc @mgencur @lberk @jupierce