Skip to content

Update OLM CI to use custom CI image#26704

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
perdasilva:fix_olm
Mar 3, 2022
Merged

Update OLM CI to use custom CI image#26704
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
perdasilva:fix_olm

Conversation

@perdasilva
Copy link
Copy Markdown
Contributor

@perdasilva perdasilva commented Mar 2, 2022

This PR adds an additional image based on the build/test environment needed for CI and updates the CI jobs to use that image.

@openshift-ci openshift-ci Bot requested review from dinhxuanvu and exdx March 2, 2022 23:02
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@openshift-ci openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2022
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2022
@perdasilva perdasilva changed the title Revert "Honor OLM's upstream .ci-operator.yaml" Update OLM CI to use custom CI image Mar 3, 2022
@perdasilva perdasilva force-pushed the fix_olm branch 2 times, most recently from af874a9 to 5b507a8 Compare March 3, 2022 10:25
@openshift-ci openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2022
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not want to promote this image, you should use excluded_images and then the tools will not require changing this file (https://github.com/openshift/release/pull/26716/files#diff-b0a8f6feb1bde5878f221db73719e280f35a896e2f5404dce4dcecee7e3fef7eR33-R34 )

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I feel stupid coz I actually had it in my changes originally, but I made a mistake committing which meant I had to re-do it and lost that bit. But ass-you-me'd I had redone it correctly. Thank you and the review process =D

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2022
@openshift-ci openshift-ci Bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 3, 2022
@fgiloux
Copy link
Copy Markdown
Contributor

fgiloux commented Mar 3, 2022

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 3, 2022

@fgiloux: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot removed do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 3, 2022
@davegord
Copy link
Copy Markdown

davegord commented Mar 3, 2022

/LGTM

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022
@perdasilva
Copy link
Copy Markdown
Contributor Author

/approve

Signed-off-by: perdasilva <perdasilva@redhat.com>
@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Mar 3, 2022
@davegord
Copy link
Copy Markdown

davegord commented Mar 3, 2022

/LGTM

@exdx
Copy link
Copy Markdown
Contributor

exdx commented Mar 3, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davegord, exdx, fgiloux, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 884ee6d into openshift:master Mar 3, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 3, 2022

@perdasilva: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-operator-framework-olm-master.yaml using file ci-operator/config/openshift/operator-framework-olm/openshift-operator-framework-olm-master.yaml
Details

In response to this:

This PR adds an additional image based on the build/test environment needed for CI and updates the CI jobs to use that image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 3, 2022

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants