Skip to content

release-controller: Remove advanced-virt repo#26811

Closed
etrunko wants to merge 1 commit intoopenshift:masterfrom
etrunko:master
Closed

release-controller: Remove advanced-virt repo#26811
etrunko wants to merge 1 commit intoopenshift:masterfrom
etrunko:master

Conversation

@etrunko
Copy link
Copy Markdown

@etrunko etrunko commented Mar 7, 2022

From RHEL 8.6 onwards there is no advanced virtualization repository
anymore.

Signed-off-by: Eduardo Lima (Etrunko) etrunko@redhat.com

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 7, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 7, 2022

Hi @etrunko. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from bbguimaraes and droslean March 7, 2022 19:05
@miabbott
Copy link
Copy Markdown
Member

miabbott commented Mar 7, 2022

/ok-to-test
/approve

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2022
@HuijingHei
Copy link
Copy Markdown
Contributor

@etrunko there is new file core-services/release-controller/_repos/ocp-4.11-rhel86.repo refer to #27333, could you help to remove advanced-virt repo in core-services/release-controller/_repos/ocp-4.11-rhel86.repo, thanks!

@etrunko
Copy link
Copy Markdown
Author

etrunko commented Apr 1, 2022

@etrunko there is new file core-services/release-controller/_repos/ocp-4.11-rhel86.repo refer to #27333, could you help to remove advanced-virt repo in core-services/release-controller/_repos/ocp-4.11-rhel86.repo, thanks!

Should I revert the changes on ocp-4.11.rhel85.repo?

From RHEL 8.6 onwards there is no advanced virtualization repository
anymore.

Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
@HuijingHei
Copy link
Copy Markdown
Contributor

@etrunko there is new file core-services/release-controller/_repos/ocp-4.11-rhel86.repo refer to #27333, could you help to remove advanced-virt repo in core-services/release-controller/_repos/ocp-4.11-rhel86.repo, thanks!

Should I revert the changes on ocp-4.11.rhel85.repo?

I think no need, ocp-4.11.rhel85.repo will be removed when move to rhel8.6, but not sure, need confirm from @miabbott

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Apr 1, 2022

I think no need, ocp-4.11.rhel85.repo will be removed when move to rhel8.6, but not sure, need confirm from @miabbott

Correct, we can leave the 8.5 repo definition as is; 8.6 is our future.

@etrunko
Copy link
Copy Markdown
Author

etrunko commented Apr 1, 2022

I think no need, ocp-4.11.rhel85.repo will be removed when move to rhel8.6, but not sure, need confirm from @miabbott

Correct, we can leave the 8.5 repo definition as is; 8.6 is our future.

Okay then, I'm leaving it.

@etrunko
Copy link
Copy Markdown
Author

etrunko commented Apr 4, 2022

Are we able to merge this one now?

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Apr 4, 2022

/lgtm
/assign @jupierce

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 4, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: etrunko, miabbott
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2022
@etrunko
Copy link
Copy Markdown
Author

etrunko commented Apr 22, 2022

Hi, is there anything pending with this MR?

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 25, 2022

@etrunko: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@miabbott
Copy link
Copy Markdown
Member

@travier
Copy link
Copy Markdown
Member

travier commented May 17, 2022

I'm merging this one into #28521

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 17, 2022

@etrunko: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Copy Markdown
Member

travier commented May 17, 2022

/close

@openshift-ci openshift-ci Bot closed this May 17, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 17, 2022

@travier: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants