Skip to content

ci-operator: Introduce a dedicated prowjob for running OLM's psm unit tests#27305

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
timflannagan:olm/dedicated-unit-psm-prowjobs
Mar 28, 2022
Merged

ci-operator: Introduce a dedicated prowjob for running OLM's psm unit tests#27305
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
timflannagan:olm/dedicated-unit-psm-prowjobs

Conversation

@timflannagan
Copy link
Copy Markdown
Contributor

The PSM is a sub-component of OLM that was introduced in 4.9. These unit tests are currently run by through the unit/olm prowjob as an original hack to get CI coverage without having to introduce a new prowjob, but we never fixed that hack after the PSM work was merged.

Signed-off-by: timflannagan timflannagan@gmail.com

@openshift-ci openshift-ci Bot requested review from awgreene and dinhxuanvu March 25, 2022 19:04
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2022
@timflannagan
Copy link
Copy Markdown
Contributor Author

Looks like the rehearsals worked:

go test /go/src/github.com/openshift/operator-framework-olm/pkg/package-server-manager/...
ok github.com/openshift/operator-framework-olm/pkg/package-server-manager 0.050s

Copy link
Copy Markdown
Contributor

@exdx exdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these changes also incorporate changes to OLM to not run the PSM unit tests as part of it's own unit suite run? Just making sure we aren't duplicating running the same tests twice in CI

@timflannagan
Copy link
Copy Markdown
Contributor Author

@exdx Nope - that's needs to be done as a follow-up (I'm tracking this locally) once the upstream sync lands and CI is a bit more stable.

@exdx
Copy link
Copy Markdown
Contributor

exdx commented Mar 28, 2022

Ok cool -- let's do it as a followup
/lgtm

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2022
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: exdx, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

… tests

Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan timflannagan force-pushed the olm/dedicated-unit-psm-prowjobs branch from d4d7952 to 63e4078 Compare March 28, 2022 13:38
@openshift-ci openshift-ci Bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 28, 2022
@exdx
Copy link
Copy Markdown
Contributor

exdx commented Mar 28, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit 3fd9d6f into openshift:master Mar 28, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 28, 2022

@timflannagan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants