Skip to content

cluster-api-provider-openstack: optional unit test#27640

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:capo_skip_envtest
Apr 7, 2022
Merged

cluster-api-provider-openstack: optional unit test#27640
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:capo_skip_envtest

Conversation

@pierreprinetti
Copy link
Copy Markdown
Contributor

Let code flow in to be used as a library, until we figure out how to
properly run unit tests downstream.

@openshift-ci openshift-ci Bot requested review from mdbooth and stephenfin April 7, 2022 10:00
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2022
@dulek
Copy link
Copy Markdown
Contributor

dulek commented Apr 7, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2022
Let code flow in to be used as a library, until we figure out how to
properly run unit tests downstream.

Also reset the test command to replicate what happens upstream.
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2022
@mdbooth
Copy link
Copy Markdown
Contributor

mdbooth commented Apr 7, 2022

/lgtm

The unit tests are expected to fail, which is a problem we need to fix.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 7, 2022

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/pj-rehearse f834373 link false /test pj-rehearse
ci/rehearse/openshift/cluster-api-provider-openstack/main/unit f834373 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, mdbooth, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c14ad3e into openshift:master Apr 7, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 7, 2022

@pierreprinetti: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-api-provider-openstack-main.yaml using file ci-operator/config/openshift/cluster-api-provider-openstack/openshift-cluster-api-provider-openstack-main.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-api-provider-openstack-main-presubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-openstack/openshift-cluster-api-provider-openstack-main-presubmits.yaml
Details

In response to this:

Let code flow in to be used as a library, until we figure out how to
properly run unit tests downstream.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the capo_skip_envtest branch April 7, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants