ci-operator/templates: make directory for installer artifacts

[staebler]

There needs to be a directory for installer artifacts to hold the install-config.yaml file needed when the installer runs.

The command to create the installer artifacts directory was inadvertently removed as part of #2962.

[wking]

I think it would be better to have these right before their first consumer, but we need this fix.

/lgtm

[wking]

@vrutkovs, @sdodson?

[sdodson]

/lgtm

[sdodson]

/approve

[staebler]

I think it would be better to have these right before their first consumer, but we need this fix.

/lgtm

They are, if you consider the EXPORT commands as part of the consumer.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, staebler, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/templates/openshift/installer/OWNERS [staebler,wking]
• ci-operator/templates/openshift/openshift-ansible/OWNERS [sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@staebler: Updated the following 8 configmaps:

• prow-job-cluster-launch-e2e-40 configmap in namespace ci using the following files:
  • key cluster-launch-e2e-40.yaml using file ci-operator/templates/openshift/openshift-ansible/cluster-launch-e2e-40.yaml
• prow-job-cluster-launch-e2e-40 configmap in namespace ci-stg using the following files:
  • key cluster-launch-e2e-40.yaml using file ci-operator/templates/openshift/openshift-ansible/cluster-launch-e2e-40.yaml
• prow-job-cluster-scaleup-e2e-40 configmap in namespace ci using the following files:
  • key cluster-scaleup-e2e-40.yaml using file ci-operator/templates/openshift/openshift-ansible/cluster-scaleup-e2e-40.yaml
• prow-job-cluster-scaleup-e2e-40 configmap in namespace ci-stg using the following files:
  • key cluster-scaleup-e2e-40.yaml using file ci-operator/templates/openshift/openshift-ansible/cluster-scaleup-e2e-40.yaml
• prow-job-cluster-launch-installer-e2e configmap in namespace ci using the following files:
  • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
• prow-job-cluster-launch-installer-e2e configmap in namespace ci-stg using the following files:
  • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
• prow-job-cluster-launch-installer-src configmap in namespace ci using the following files:
  • key cluster-launch-installer-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml
• prow-job-cluster-launch-installer-src configmap in namespace ci-stg using the following files:
  • key cluster-launch-installer-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml

Details

In response to this:

There needs to be a directory for installer artifacts to hold the install-config.yaml file needed when the installer runs.

The command to create the installer artifacts directory was inadvertently removed as part of #2962.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

I think it would be better to have these right before their first consumer, but we need this fix.

They are, if you consider the EXPORT commands as part of the consumer

I don't because the export calls would succeed without the directory, and the installer creates its asset directory if necessary. I just forgotten about the install-config.yaml creation, which does need these mkdir calls, and having the mkdirs live closer to the here-docs would make that mistake less likely in the future. Not a big deal though ;).