Skip to content

Add separate e2e-aws-console-olm suite #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 14, 2019
Merged

Add separate e2e-aws-console-olm suite #3088

openshift-merge-robot merged 1 commit into from
Mar 14, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Mar 13, 2019

Requires openshift/console#1282

@petr-muller this adds OWNERS files for console

/cc @jcaianirh @stevekuznetsov @petr-muller

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2019
@spadgett spadgett mentioned this pull request Mar 13, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 13, 2019
jcaianirh
jcaianirh suggested changes Mar 13, 2019
View reviewed changes
Copy link
Member

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spadgett remove
ci-operator/config/openshift/console
ci-operator/jobs/openshift/console
from release/hack/validate-owners.sh

@spadgett spadgett force-pushed the olm-suite branch 2 times, most recently from 6107377 to 33499ff Compare March 13, 2019 18:52
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2019
@spadgett spadgett changed the title [WIP] Add separate console-e2e-olm suite [WIP] Add separate e2e-aws-console-olm suite Mar 13, 2019
@spadgett
Copy link
Member Author

spadgett commented Mar 13, 2019

@jcaianirh I renamed console-e2e to e2e-aws-console to be consistent with e2e-aws

@spadgett spadgett changed the title [WIP] Add separate e2e-aws-console-olm suite Add separate e2e-aws-console-olm suite Mar 13, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2019
jcaianirh
jcaianirh approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

petr-muller
petr-muller approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, petr-muller, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2019
@openshift-merge-robot openshift-merge-robot merged commit 2ba6342 into openshift:master Mar 14, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 14, 2019

@spadgett: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-console-master.yaml using file ci-operator/config/openshift/console/openshift-console-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-console-master.yaml using file ci-operator/config/openshift/console/openshift-console-master.yaml
  • job-config-master configmap in namespace ci using the following files:
    • key openshift-console-master-presubmits.yaml using file ci-operator/jobs/openshift/console/openshift-console-master-presubmits.yaml
Details

In response to this:

Requires openshift/console#1282

@petr-muller this adds OWNERS files for console

/cc @jcaianirh @stevekuznetsov @petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the olm-suite branch March 14, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

2 more reviewers

@petr-muller petr-muller petr-muller approved these changes

@jcaianirh jcaianirh jcaianirh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@petr-muller petr-muller

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@spadgett @openshift-ci-robot @petr-muller @jcaianirh @openshift-merge-robot