Skip to content

stop building coreos-assembler, reverse mirroring#31015

Merged
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
dustymabe:dusty-drop-cosa-mirroring
Aug 3, 2022
Merged

stop building coreos-assembler, reverse mirroring#31015
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
dustymabe:dusty-drop-cosa-mirroring

Conversation

@dustymabe
Copy link
Copy Markdown
Member

@dustymabe dustymabe commented Aug 2, 2022

stop building coreos-assembler, reverse mirroring

We're now building them upstream for all architectures and
syncing them to quay.io directly. See coreos/fedora-coreos-tracker#1027

Let's stop building them here and reverse the mirroring until we
can get all references to registry.ci.openshift.org cleaned up.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Aug 3, 2022

OK, I've found examples of mirroring from Quay.io to app.ci: https://github.com/openshift/release/blob/master/core-services/image-mirroring/supplemental-ci-images/mapping_supplemental_ci_images_ci. So I think indeed it is supported.

So... how about instead we:

  • instead of deleting those lines, we flip the order so that Quay.io images are mirrored to app.ci
  • we git rm clusters/app.ci/supplemental-ci-images/coreos/cosa-rhcos-branched-bc.yaml so we don't still have internal builds clobbering what we just mirrored

?

And then eventually, we can drop the mirroring once we've moved everything to point to Quay.io.

We're now building them upstream for all architectures and
syncing them to quay.io directly. See coreos/fedora-coreos-tracker#1027

Let's stop building them here and reverse the mirroring until we
can get all references to registry.ci.openshift.org cleaned up.
@dustymabe dustymabe force-pushed the dusty-drop-cosa-mirroring branch from e2dc4bf to 6724729 Compare August 3, 2022 15:34
@dustymabe dustymabe changed the title remove mirroring of coreos-assembler images to quay.io stop building coreos-assembler, reverse mirroring Aug 3, 2022
Copy link
Copy Markdown
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!
/lgtm

Might need to regenerate the jobs, but let's see what CI says.

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Aug 3, 2022

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2022
@dustymabe
Copy link
Copy Markdown
Member Author

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 3, 2022

@dustymabe: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot merged commit 6244bd8 into openshift:master Aug 3, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 3, 2022

@dustymabe: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_coreos_assembler_coreos_assembler using file core-services/image-mirroring/coreos/mapping_coreos_assembler_coreos_assembler
Details

In response to this:

stop building coreos-assembler, reverse mirroring

We're now building them upstream for all architectures and
syncing them to quay.io directly. See coreos/fedora-coreos-tracker#1027

Let's stop building them here and reverse the mirroring until we
can get all references to registry.ci.openshift.org cleaned up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dustymabe dustymabe deleted the dusty-drop-cosa-mirroring branch August 3, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants