Skip to content

Add 4.10-tls and drop 4.8, 4.9 from serving next#31034

Merged
openshift-ci[bot] merged 3 commits into
openshift:masterfrom
nak3:add-410-tls
Aug 5, 2022
Merged

Add 4.10-tls and drop 4.8, 4.9 from serving next#31034
openshift-ci[bot] merged 3 commits into
openshift:masterfrom
nak3:add-410-tls

Conversation

@nak3
Copy link
Copy Markdown
Contributor

@nak3 nak3 commented Aug 3, 2022

As per openshift/knative-serving#1203, this patch adds 4.10-tls and drop 4.8&4.9 from serving next CI.

@openshift-ci openshift-ci Bot requested review from mgencur and mvinkler August 3, 2022 13:54
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2022
@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented Aug 4, 2022

/cc @skonto @mgencur

- --report-credentials-file=/etc/report/credentials
- --target=[images]
- --variant=4.9
- --target=src
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for?

Copy link
Copy Markdown
Contributor Author

@nak3 nak3 Aug 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The auto generated script added this.
Actually other CI config has it like this but only release-next did not have it.

dockerfile_path: openshift/ci-operator/build-image/Dockerfile
canonical_go_repository: knative.dev/serving
images:
- dockerfile_path: openshift/ci-operator/knative-images/webhook/Dockerfile
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to touch 4.6?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with the comment above. The auto generated script changed the order 😞

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok

@skonto
Copy link
Copy Markdown
Contributor

skonto commented Aug 4, 2022

/retest

@skonto
Copy link
Copy Markdown
Contributor

skonto commented Aug 5, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 5, 2022

@nak3: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot merged commit 27fdeae into openshift:master Aug 5, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 5, 2022

@nak3: Updated the following 2 configmaps:

  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-knative-serving-release-next__4.10.yaml using file ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-next__4.10.yaml
    • key openshift-knative-serving-release-next__4.6.yaml using file ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-next__4.6.yaml
    • key openshift-knative-serving-release-next__4.7.yaml using file ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-next__4.7.yaml
    • key openshift-knative-serving-release-next__4.9.yaml using file ``
    • key openshift-knative-serving-release-next__4.8.yaml using file ``
    • key openshift-knative-serving-release-next__410-tls.yaml using file ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-next__410-tls.yaml
  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-knative-serving-release-next-postsubmits.yaml using file ci-operator/jobs/openshift/knative-serving/openshift-knative-serving-release-next-postsubmits.yaml
    • key openshift-knative-serving-release-next-presubmits.yaml using file ci-operator/jobs/openshift/knative-serving/openshift-knative-serving-release-next-presubmits.yaml
Details

In response to this:

As per openshift/knative-serving#1203, this patch adds 4.10-tls and drop 4.8&4.9 from serving next CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants