Skip to content

Bump Knative serving internal TLS CI to 4.11#32080

Merged
openshift-merge-robot merged 5 commits into
openshift:masterfrom
nak3:bump-tls-411
Sep 8, 2022
Merged

Bump Knative serving internal TLS CI to 4.11#32080
openshift-merge-robot merged 5 commits into
openshift:masterfrom
nak3:bump-tls-411

Conversation

@nak3
Copy link
Copy Markdown
Contributor

@nak3 nak3 commented Sep 7, 2022

This patch bumps Knative Serving internal TLS CI to 4.11.

It failed for some reason so still uses on 4.10. Please also refer to #31756 (comment)

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@openshift-ci openshift-ci Bot requested review from mvinkler and rhuss September 7, 2022 13:23
@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented Sep 8, 2022

knative-serving repo test passed openshift/knative-serving#1227 but this repo does not - log.

I guess the name 411-tls exceeds some name limitation.

@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented Sep 8, 2022

#32080 (comment) is an old name's result. It should be ignored.

@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented Sep 8, 2022

/cc @skonto @mgencur

@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Sep 8, 2022

There's already a file called openshift-knative-serving-release-next__411.yaml which calls the make target test-e2e. And now you're adding a file called openshift-knative-serving-release-next__tls.yaml which has two prow checks and then call both make test-e2e and make test-e2e-tls. So there's duplication. The CI will run the same target twice (make test-e2e).
Aside from that the two prow checks from this new file are called tls-e2e-aws-ocp-tls-411 and tls-e2e-aws-ocp-411 even though just one of them runs tls.
You should probably delete the file openshift-knative-serving-release-next__tls.yaml completely and move the prow check for tls to openshift-knative-serving-release-next__411.yaml.

@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Sep 8, 2022

Need to run make jobs again.

@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Sep 8, 2022

/lgtm
/hold
Hold for tests.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2022
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ci-operator.openshift.io/variant: 410-tls
ci.openshift.io/generator: prowgen
max_concurrency: 1
name: branch-ci-openshift-knative-serving-release-next-410-tls-images
Copy link
Copy Markdown
Contributor

@skonto skonto Sep 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this run elsewhere? I guess we remove 4.10 completely in favor of 4.11.

Copy link
Copy Markdown
Contributor

@mgencur mgencur Sep 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, we had:

openshift-knative-serving-release-next__410-tls.yaml
openshift-knative-serving-release-next__411.yaml
openshift-knative-serving-release-next__46.yaml
openshift-knative-serving-release-next__47.yaml

IMO, it would be fine to have just 4.8 and 4.11. It depends what you want. Please also see my comment here: openshift/knative-serving#1239 (comment)

Copy link
Copy Markdown
Contributor

@skonto skonto Sep 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of running against the oldest and the newest version more because release-next is supposed to introduce new stuff and for sure we want to test compatibility to know ahead in time if something fails.
So I agree with the comment we can update later for 1.26 anyway.

@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented Sep 8, 2022

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit c26ec4c into openshift:master Sep 8, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 8, 2022

@nak3: Updated the following 2 configmaps:

  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-knative-serving-release-next__410-tls.yaml using file ``
    • key openshift-knative-serving-release-next__411.yaml using file ci-operator/config/openshift/knative-serving/openshift-knative-serving-release-next__411.yaml
  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-knative-serving-release-next-postsubmits.yaml using file ci-operator/jobs/openshift/knative-serving/openshift-knative-serving-release-next-postsubmits.yaml
    • key openshift-knative-serving-release-next-presubmits.yaml using file ci-operator/jobs/openshift/knative-serving/openshift-knative-serving-release-next-presubmits.yaml
Details

In response to this:

This patch bumps Knative Serving internal TLS CI to 4.11.

It failed for some reason so still uses on 4.10. Please also refer to #31756 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 8, 2022

@nak3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/knative-serving/release-next/tls-e2e-aws-ocp-tls-411 d301f01 link unknown /test pj-rehearse
ci/rehearse/openshift/knative-serving/release-next/411-tls-e2e-aws-ocp-411-continuous 5f6b32f link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants