Skip to content

OTA-740: ci-operator/config/openshift/origin/openshift-origin-master: Disable Telemetry for e2e-aws#32252

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
wking:disable-telemetry-for-openshift-origin-master-e2e-aws
Sep 13, 2022
Merged

OTA-740: ci-operator/config/openshift/origin/openshift-origin-master: Disable Telemetry for e2e-aws#32252
openshift-merge-robot merged 1 commit into
openshift:masterfrom
wking:disable-telemetry-for-openshift-origin-master-e2e-aws

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented Sep 13, 2022

I'd disabled Telemetry for the bulk of the CI fleet in 3c1da8e (#32153). But that lead to many failures for:

Prometheus when installed on the cluster should report telemetry if a cloud.openshift.com token is present

so I'd flipped the default to keeping Telemetry enabled in d61129c (#32249). Now I'm looking to teach the origin test-case skip about the mechanism I used to disable Telemetry, and I want an origin master presubmit with Telemetry disabled. The only run_if_changed origin master presubmits are e2e-gcp-builds, e2e-aws-jenkins, e2e-gcp-image-ecosystem, and e2e-aws-image-registry, and none of those sound like job that will run the test-case I'm interested in (although maybe they do; I haven't dug in to confirm). But e2e-aws is optional, so having the presubmit temporarily failing for other origin master pull requests won't block changes from landing.

We'll revert this change and return the job to the CI-wide Telemetry default once we've confirmed that the test-case skips are smart enough.

…Telemetry for e2e-aws

I'd disabled Telemetry for the bulk of the CI fleet in 3c1da8e
(OTA-740: ci-operator/step-registry/ipi/conf/telemetry: Disable
Telemetry (openshift#32153), 2022-09-13).  But that lead to many failures for:

  Prometheus when installed on the cluster should report telemetry if a cloud.openshift.com token is present

so I'd flipped the default to keeping Telemetry enabled in d61129c
(ci-operator/step-registry/ipi/conf/telemetry: Restore Telemetry
(openshift#32249), 2022-09-13).  Now I'm looking to teach the origin test-case
skip about the mechanism I used to disable Telemetry, and I want an
origin master presubmit with Telemetry disabled.  The only
run_if_changed origin master presubmits are e2e-gcp-builds,
e2e-aws-jenkins, e2e-gcp-image-ecosystem, and e2e-aws-image-registry,
and none of those sound like job that will run the test-case I'm
interested in (although maybe they do; I haven't dug in to confirm).
But e2e-aws is optional, so having the presubmit temporarily failing
for other origin master pull requests won't block changes from
landing.

We'll revert this change and return the job to the CI-wide Telemetry
default once we've confirmed that the test-case skips are smart
enough.
@openshift-ci openshift-ci Bot requested review from bparees and sjenning September 13, 2022 17:23
@stbenjam
Copy link
Copy Markdown
Member

/lgtm
/hold

Please only merge when you're ready to test the PR :)

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2022
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2022
@wking
Copy link
Copy Markdown
Member Author

wking commented Sep 13, 2022

I've got my origin branch ready to go, so putting this change in the pipe:

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2022
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 727354f and 2 for PR HEAD 0d0ee0e in total

@openshift-merge-robot openshift-merge-robot merged commit 3f99353 into openshift:master Sep 13, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 13, 2022

@wking: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-origin-master.yaml using file ci-operator/config/openshift/origin/openshift-origin-master.yaml
Details

In response to this:

I'd disabled Telemetry for the bulk of the CI fleet in 3c1da8e (#32153). But that lead to many failures for:

Prometheus when installed on the cluster should report telemetry if a cloud.openshift.com token is present

so I'd flipped the default to keeping Telemetry enabled in d61129c (#32249). Now I'm looking to teach the origin test-case skip about the mechanism I used to disable Telemetry, and I want an origin master presubmit with Telemetry disabled. The only run_if_changed origin master presubmits are e2e-gcp-builds, e2e-aws-jenkins, e2e-gcp-image-ecosystem, and e2e-aws-image-registry, and none of those sound like job that will run the test-case I'm interested in (although maybe they do; I haven't dug in to confirm). But e2e-aws is optional, so having the presubmit temporarily failing for other origin master pull requests won't block changes from landing.

We'll revert this change and return the job to the CI-wide Telemetry default once we've confirmed that the test-case skips are smart enough.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the disable-telemetry-for-openshift-origin-master-e2e-aws branch September 13, 2022 20:18
@wking wking changed the title ci-operator/config/openshift/origin/openshift-origin-master: Disable Telemetry for e2e-aws OTA-740: ci-operator/config/openshift/origin/openshift-origin-master: Disable Telemetry for e2e-aws Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants