OTA-740: ci-operator/config/openshift/origin/openshift-origin-master: Disable Telemetry for e2e-aws#32252
Conversation
…Telemetry for e2e-aws I'd disabled Telemetry for the bulk of the CI fleet in 3c1da8e (OTA-740: ci-operator/step-registry/ipi/conf/telemetry: Disable Telemetry (openshift#32153), 2022-09-13). But that lead to many failures for: Prometheus when installed on the cluster should report telemetry if a cloud.openshift.com token is present so I'd flipped the default to keeping Telemetry enabled in d61129c (ci-operator/step-registry/ipi/conf/telemetry: Restore Telemetry (openshift#32249), 2022-09-13). Now I'm looking to teach the origin test-case skip about the mechanism I used to disable Telemetry, and I want an origin master presubmit with Telemetry disabled. The only run_if_changed origin master presubmits are e2e-gcp-builds, e2e-aws-jenkins, e2e-gcp-image-ecosystem, and e2e-aws-image-registry, and none of those sound like job that will run the test-case I'm interested in (although maybe they do; I haven't dug in to confirm). But e2e-aws is optional, so having the presubmit temporarily failing for other origin master pull requests won't block changes from landing. We'll revert this change and return the job to the CI-wide Telemetry default once we've confirmed that the test-case skips are smart enough.
|
/lgtm Please only merge when you're ready to test the PR :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I've got my origin branch ready to go, so putting this change in the pipe: /hold cancel |
|
@wking: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'd disabled Telemetry for the bulk of the CI fleet in 3c1da8e (#32153). But that lead to many failures for:
so I'd flipped the default to keeping Telemetry enabled in d61129c (#32249). Now I'm looking to teach the origin test-case skip about the mechanism I used to disable Telemetry, and I want an origin master presubmit with Telemetry disabled. The only run_if_changed origin master presubmits are e2e-gcp-builds, e2e-aws-jenkins, e2e-gcp-image-ecosystem, and e2e-aws-image-registry, and none of those sound like job that will run the test-case I'm interested in (although maybe they do; I haven't dug in to confirm). But e2e-aws is optional, so having the presubmit temporarily failing for other origin master pull requests won't block changes from landing.
We'll revert this change and return the job to the CI-wide Telemetry default once we've confirmed that the test-case skips are smart enough.