Skip to content

Let cluster-bot use regular ci aws account for hypershift guest clusters#32613

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
enxebre:hypershift-split-aws-account-for-clusterbot
Sep 27, 2022
Merged

Let cluster-bot use regular ci aws account for hypershift guest clusters#32613
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
enxebre:hypershift-split-aws-account-for-clusterbot

Conversation

@enxebre
Copy link
Copy Markdown
Member

@enxebre enxebre commented Sep 26, 2022

This let cluster-bot to use the regular ocp CI aws account for the guest clusters infra when requesting a hypershift cluster

@openshift-ci openshift-ci Bot requested review from imain and wking September 26, 2022 15:57
@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Sep 26, 2022

PTAL @bradmwilliams @sjenning @csrwng

@bradmwilliams
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2022
HYPERSHIFT_NODE_COUNT: 2
HYPERSHIFT_ZONES: "us-east-1a"
HYPERSHIFT_NAMESPACE: "cluster-bot"
HYPERSHIFT_GUEST_INFRA_OCP_ACCOUNT: "true"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also set this var for our other jobs like the presubmits?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, I was wanting to merge this one first, test it, then extend it

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I'm thinking we can change it here for some or the others and the reharse would tell us

@csrwng
Copy link
Copy Markdown
Contributor

csrwng commented Sep 27, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, csrwng, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 27, 2022

@enxebre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/pj-rehearse 4025f4a link false /test pj-rehearse
ci/rehearse/openshift/apiserver-network-proxy/master/e2e-hypershift 4025f4a link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 800adee into openshift:master Sep 27, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 27, 2022

@enxebre: Updated the job-config-misc configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-release-infra-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-infra-periodics.yaml
Details

In response to this:

This let cluster-bot to use the regular ocp CI aws account for the guest clusters infra when requesting a hypershift cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants