Let cluster-bot use regular ci aws account for hypershift guest clusters#32613
Conversation
|
/approve |
| HYPERSHIFT_NODE_COUNT: 2 | ||
| HYPERSHIFT_ZONES: "us-east-1a" | ||
| HYPERSHIFT_NAMESPACE: "cluster-bot" | ||
| HYPERSHIFT_GUEST_INFRA_OCP_ACCOUNT: "true" |
There was a problem hiding this comment.
Shouldn't we also set this var for our other jobs like the presubmits?
There was a problem hiding this comment.
sgtm, I was wanting to merge this one first, test it, then extend it
There was a problem hiding this comment.
Actually I'm thinking we can change it here for some or the others and the reharse would tell us
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bradmwilliams, csrwng, enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@enxebre: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@enxebre: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This let cluster-bot to use the regular ocp CI aws account for the guest clusters infra when requesting a hypershift cluster