Add etcd-scaling workflows to step-registry #32623
Conversation
|
I think it probably makes sense to add a periodic to openshift/release running on some interval - once a day? With the intention of graduating them to payload informers. You could open it as a separate PR |
|
Yeah good idea. I was also thinking of periodics to cover all the required platforms. I'll do a follow up once I know these steps are correctly running the new |
|
You may also want to move the 4.11 jobs to another PR as well - we'll have to backport the origin PR first before those can work. |
There was a problem hiding this comment.
also add @wking, I'm sure he also will have to go and plumb some stuff there once in a while.
There was a problem hiding this comment.
feel free to add update in your follow-up PR, let's get this through first ;)
|
/lgtm |
There was a problem hiding this comment.
Do we need a new line here as the other files ?
|
/approve Pending merge of the origin side, feel free to remove hold when ready |
openshift-ci
bot
added
do-not-merge/hold
hasbro17
force-pushed
the
add-etcd-scaling-job-step
branch
from
6f19d5d to
b0df5ab
Compare
|
Since we're still waiting for CI to go through on the origin PR, I've updated this one to remove the 4.11 presubmits until we get that backported in origin. @tjungblu if you could retag again that would be great. |
|
yes sir! |
openshift-merge-robot
added
the
needs-rebase
hasbro17
force-pushed
the
add-etcd-scaling-job-step
branch
from
b0df5ab to
dc6b4e4
Compare
openshift-merge-robot
removed
the
needs-rebase
|
@stbenjam I've also lumped in the changes for nightly periodics for the scaling job but let me know if you'd prefer that to be a follow up. Also since these aren't informing jobs I'm not exactly sure where these would these show up. Just wondering how we can monitor and get alerted on these jobs, as other repos like the CPSMO would likely break these again in the future. |
|
I think it's fine to keep it all here. The periodics on the openshift/release repo will show up in Sippy, TRT can also configure monitoring for you, maybe on the 7 day pass rate. Once the job is proven stable, you can graduate to be a release informer. Drop a card in https://issues.redhat.com/secure/CreateIssue.jspa?pid=12323832&issuetype=17 with 1) names of the periodic jobs, 2) channel to send the alert to, 3) reasonable 7 day threshold (maybe 60% to start?) |
hasbro17
force-pushed
the
add-etcd-scaling-job-step
branch
from
a51a985 to
1038a91
Compare
openshift-merge-robot
added
the
needs-rebase
hasbro17
force-pushed
the
add-etcd-scaling-job-step
branch
from
0918eff to
0b6cf97
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/test pj-rehearse |
|
/hold I'm expecting as some early/late tests might fail for the vertical scaling test. |
There was a problem hiding this comment.
Also not sure why make jobs is now marking all jobs as always run. Wasn't doing that the last time I updated these.
Possibly an update in ci-operator but need to confirm what to tweak in the presubmits to not run these. Don't just want to edit these back manually.
There was a problem hiding this comment.
Also not sure why make jobs is pruning these now.
hasbro17
force-pushed
the
add-etcd-scaling-job-step
branch
from
0b6cf97 to
91165ac
Compare
|
Fixed the extraneous /test pj-rehearse |
|
/lgtm The kubePodNotReady failures look like something TRT is currently investigating, but I think the rehearsals look good otherwise? |
openshift-merge-robot
added
the
needs-rebase
hasbro17
force-pushed
the
add-etcd-scaling-job-step
branch
from
91165ac to
830ff97
Compare
openshift-merge-robot
removed
the
needs-rebase
|
Taking a closer look at some of the rehearse jobs: But the test suite exists for other jobs, e.g: And more confusingly it's showing the Perhaps because it's the nightly that's outdated? |
This commit adds new workflows to run the etcd-scaling test suite on aws/gcp/azure/vsphere platforms. This also adds the presubmits to run these jobs as CI for the cluster-etcd-operator repo as well as periodic jobs.
hasbro17
force-pushed
the
add-etcd-scaling-job-step
branch
from
830ff97 to
39b2540
Compare
|
@stbenjam I think we can merge this now if you want to tag again. /test pj-rehearse The rehearse jobs look good to me. The test itself is passing on all platforms for both Only puzzling thing is the absence of rehearse runs for the 4.13 nightly periodic
https://prow.ci.openshift.org/pr-history/?org=openshift&repo=release&pr=32623 |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Elbehery, hasbro17, stbenjam, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
openshift-ci-robot
added
the
rehearsals-ack
|
@hasbro17: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@hasbro17: Updated the following 7 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Adds the
etcd-scalingworkflow for aws/azure/gcp/vsphere which runs theopenshift/etcd/scalingtest suite.The following presubmits are added to master/4.13/4.12 branches for openshift/cluster-etcd-operator CI:
Along with nightly jobs for aws/azure/gcp/vsphere for 4.12/4.13
This is required since the etcd vertical scaling test is being moved out of
openshift/conformance/serialintoopenshift/etcd/scalingin order to reduce disruptions in the serial suite.See openshift/origin#27444