Skip to content

Wire heterogeneous upgrade jobs to multiarch release-controller#33934

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
petr-muller:wire-multiarch-jobs-to-rc
Nov 11, 2022
Merged

Wire heterogeneous upgrade jobs to multiarch release-controller#33934
openshift-merge-robot merged 1 commit into
openshift:masterfrom
petr-muller:wire-multiarch-jobs-to-rc

Conversation

@petr-muller
Copy link
Copy Markdown
Member

@petr-muller petr-muller commented Nov 10, 2022 •
edited
Loading

Configure multiarch release-controller to trigger multiarch upgrade jobs added in
#33761. Like the non-multiarch release-controllers, the *-upgrade-from-nightly*
jobs are not configured to be triggered by the release-controller, only the within-minor
upgrade jobs and *-upgrade-from-stable-* jobs are.

Needs #33761 to merge, it brings the actual referenced jobs.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 10, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 10, 2022
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 10, 2022

@petr-muller: no rehearsable tests are affected by this change

wking
wking approved these changes Nov 10, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2022
@petr-muller petr-muller marked this pull request as ready for review November 10, 2022 18:15
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2022
@bradmwilliams
Copy link
Copy Markdown
Contributor

bradmwilliams commented Nov 10, 2022

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2022
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 10, 2022

/retest-required

Remaining retests: 0 against base HEAD ec16f10 and 2 for PR HEAD bcfac7d0fe1c05d975755dd2c2afc2911765b4ca in total

@petr-muller
Copy link
Copy Markdown
Member Author

petr-muller commented Nov 10, 2022

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2022
@petr-muller petr-muller force-pushed the wire-multiarch-jobs-to-rc branch from bcfac7d to 23ce2e2 Compare November 11, 2022 16:48
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2022
@petr-muller petr-muller force-pushed the wire-multiarch-jobs-to-rc branch from 23ce2e2 to 55f98cb Compare November 11, 2022 16:58
@petr-muller
Copy link
Copy Markdown
Member Author

petr-muller commented Nov 11, 2022

🤦 ffs typos

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 11, 2022

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@petr-muller
Copy link
Copy Markdown
Member Author

petr-muller commented Nov 11, 2022

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2022
@petr-muller
Copy link
Copy Markdown
Member Author

petr-muller commented Nov 11, 2022

@bradmwilliams @wking can I have a re-tag?

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 186caf4 into openshift:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stbenjam stbenjam Awaiting requested review from stbenjam

2 more reviewers

@wking wking wking approved these changes

@bradmwilliams bradmwilliams bradmwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

@bradmwilliams bradmwilliams

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petr-muller @openshift-ci-robot @bradmwilliams @wking @openshift-merge-robot