Skip to content

Conversation

@mgencur
Copy link
Contributor

@mgencur mgencur commented Nov 14, 2022

This PR replaces #33929

@openshift-ci-robot
Copy link
Contributor

@mgencur: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-knative-serving-release-v1.8-411-e2e-aws-ocp-411 openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.8-411-images openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.8-48-e2e-aws-ocp-48 openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.8-48-images openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.8-49-e2e-aws-ocp-49 openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.8-49-images openshift-knative/serving presubmit Presubmit changed
periodic-ci-openshift-knative-serving-release-v1.8-411-e2e-aws-ocp-tls-411 N/A periodic Periodic changed
periodic-ci-openshift-knative-serving-release-v1.8-411-e2e-aws-ocp-411-continuous N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from droslean and mvinkler November 14, 2022 15:35
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2022
@skonto
Copy link
Contributor

skonto commented Nov 14, 2022

/pj-rehearse more

@nak3
Copy link
Contributor

nak3 commented Nov 15, 2022

/retest

I hope openshift-knative/serving#8 fixed the CI error.

@nak3
Copy link
Contributor

nak3 commented Nov 15, 2022

/pj-rehearse

@nak3
Copy link
Contributor

nak3 commented Nov 16, 2022

I'm guessing we need openshift/knative-serving#1287 for 1.8 branch.

@nak3
Copy link
Contributor

nak3 commented Nov 24, 2022

/retest

@nak3
Copy link
Contributor

nak3 commented Nov 24, 2022

/pj-rehearse

Finally openshift-knative/serving#31 was merged. Let's see.

@nak3
Copy link
Contributor

nak3 commented Nov 24, 2022

/pj-rehearse

@nak3
Copy link
Contributor

nak3 commented Nov 24, 2022

openshift-knative/serving#39 is necessary.

@nak3
Copy link
Contributor

nak3 commented Nov 24, 2022

/pj-rehearse

@nak3
Copy link
Contributor

nak3 commented Dec 5, 2022

/retest

@nak3
Copy link
Contributor

nak3 commented Dec 5, 2022

/pj-rehearse

@nak3
Copy link
Contributor

nak3 commented Dec 5, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nak3
Copy link
Contributor

nak3 commented Dec 6, 2022

/rehearsals-ack

@nak3
Copy link
Contributor

nak3 commented Dec 6, 2022

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2022

@mgencur: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7677a4e into openshift:master Dec 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2022

@mgencur: Updated the following 3 configmaps:

  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-knative-serving-release-v1.8-periodics.yaml using file ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.8-periodics.yaml
    • key openshift-knative-serving-release-v1.8-postsubmits.yaml using file ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.8-postsubmits.yaml
    • key openshift-knative-serving-release-v1.8-presubmits.yaml using file ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.8-presubmits.yaml
  • image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:
    • key mapping_knative_v1_8_quay using file core-services/image-mirroring/knative/mapping_knative_v1_8_quay
  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-knative-serving-release-v1.8__411.yaml using file ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.8__411.yaml
    • key openshift-knative-serving-release-v1.8__48.yaml using file ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.8__48.yaml
    • key openshift-knative-serving-release-v1.8__49.yaml using file ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.8__49.yaml
Details

In response to this:

This PR replaces #33929

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants