Skip to content

Add AWS byo CONTROL_PLANE_INSTANCE_TYPE support#34059

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
yunjiang29:fix-m6a
Nov 16, 2022
Merged

Add AWS byo CONTROL_PLANE_INSTANCE_TYPE support#34059
openshift-merge-robot merged 1 commit into
openshift:masterfrom
yunjiang29:fix-m6a

Conversation

@yunjiang29
Copy link
Copy Markdown
Contributor

@yunjiang29
Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2022
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@yunjiang29: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-priv-windows-machine-config-operator-master-aws-e2e-ccm-install openshift-priv/windows-machine-config-operator presubmit Registry content changed
pull-ci-openshift-priv-windows-machine-config-operator-master-aws-e2e-upgrade openshift-priv/windows-machine-config-operator presubmit Registry content changed
pull-ci-openshift-priv-openshift-tests-private-master-debug-disasterrecovery-aws-ipi openshift-priv/openshift-tests-private presubmit Registry content changed
pull-ci-openshift-cluster-logging-operator-release-4.8-e2e-operator openshift/cluster-logging-operator presubmit Registry content changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-image-index-sno-aws kubevirt/hyperconverged-cluster-operator presubmit Registry content changed
pull-ci-openshift-priv-ovn-kubernetes-release-4.9-e2e-aws-ovn-shared-to-local-gateway-mode-migration openshift-priv/ovn-kubernetes presubmit Registry content changed
pull-ci-kubevirt-node-maintenance-operator-master-openshift-e2e kubevirt/node-maintenance-operator presubmit Registry content changed
pull-ci-openshift-sdn-master-e2e-aws-sdn-multitenant openshift/sdn presubmit Registry content changed
pull-ci-openshift-priv-csi-driver-shared-resource-operator-master-e2e-aws-csi-driver openshift-priv/csi-driver-shared-resource-operator presubmit Registry content changed
pull-ci-openshift-kubernetes-master-e2e-aws-disruptive openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-master-e2e-aws openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-master-k8s-e2e-aws openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-master-k8s-e2e-aws-ovn-serial openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-master-configmap-scale openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-local-to-shared-gateway-mode-migration openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-shared-to-local-gateway-mode-migration openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-platform-operators-main-e2e-aws-techpreview-operator openshift/platform-operators presubmit Registry content changed
pull-ci-openshift-priv-cloud-credential-operator-master-e2e-aws-manual-oidc openshift-priv/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-priv-origin-master-e2e-aws-image-registry openshift-priv/origin presubmit Registry content changed
pull-ci-openshift-priv-origin-master-e2e-aws-ovn-single-node-upgrade openshift-priv/origin presubmit Registry content changed
pull-ci-openshift-cluster-capi-operator-main-e2e-aws-ovn-techpreview openshift/cluster-capi-operator presubmit Registry content changed
pull-ci-openshift-priv-app-netutil-master-e2e-aws openshift-priv/app-netutil presubmit Registry content changed
pull-ci-openshift-csi-node-driver-registrar-release-4.5-e2e-aws-csi openshift/csi-node-driver-registrar presubmit Registry content changed
pull-ci-openshift-priv-cluster-etcd-operator-master-e2e-aws-disruptive-ovn openshift-priv/cluster-etcd-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-workers-rhel8 openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-cluster-samples-operator-master-okd-scos-e2e-aws-builds openshift/cluster-samples-operator presubmit Registry content changed
pull-ci-openshift-cluster-samples-operator-master-okd-scos-e2e-aws-image-ecosystem openshift/cluster-samples-operator presubmit Registry content changed
pull-ci-openshift-cluster-samples-operator-master-okd-scos-e2e-aws-jenkins openshift/cluster-samples-operator presubmit Registry content changed
pull-ci-openshift-priv-cloud-provider-aws-master-openshift-e2e-aws-techpreview-upgrade openshift-priv/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-priv-cluster-dns-operator-master-e2e-aws-operator openshift-priv/cluster-dns-operator presubmit Registry content changed
pull-ci-openshift-priv-cluster-dns-operator-master-e2e-aws-serial openshift-priv/cluster-dns-operator presubmit Registry content changed
pull-ci-openshift-priv-cluster-dns-operator-master-e2e-aws-single-node openshift-priv/cluster-dns-operator presubmit Registry content changed
pull-ci-openshift-cluster-cloud-controller-manager-operator-master-e2e-aws-ccm openshift/cluster-cloud-controller-manager-operator presubmit Registry content changed
pull-ci-openshift-cluster-cloud-controller-manager-operator-master-e2e-aws-ccm-install openshift/cluster-cloud-controller-manager-operator presubmit Registry content changed

A total of 123 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2022
@yunjiang29
Copy link
Copy Markdown
Contributor Author

/test pj-rehearse

@jianlinliu
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianlinliu, yunjiang29

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yunjiang29
Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2022
@yunjiang29
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@yunjiang29 yunjiang29 closed this Nov 16, 2022
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 16, 2022
@yunjiang29 yunjiang29 reopened this Nov 16, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 16, 2022

@yunjiang29: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift-priv/cluster-network-operator/master/e2e-ovn-ipsec-step-registry e00ea97 link unknown /pj-rehearse
ci/rehearse/openshift/metallb-operator/main/operator-e2e e00ea97 link unknown /pj-rehearse
ci/rehearse/openshift-priv/csi-external-resizer/master/e2e-aws-csi e00ea97 link unknown /pj-rehearse
ci/rehearse/openshift-priv/csi-external-provisioner/release-4.5/e2e-aws-csi e00ea97 link unknown /pj-rehearse
ci/prow/pj-rehearse e00ea97 link false /test pj-rehearse
ci/rehearse/openshift-priv/cluster-api/master/e2e-aws-serial e00ea97 link unknown /pj-rehearse
ci/rehearse/openshift-priv/cluster-network-operator/master/e2e-ovn-hybrid-step-registry e00ea97 link unknown /pj-rehearse
ci/rehearse/openshift-priv/cluster-logging-operator/release-4.8/e2e-operator e00ea97 link unknown /pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c65df74 into openshift:master Nov 16, 2022
@yunjiang29 yunjiang29 deleted the fix-m6a branch July 21, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants