Skip to content

USHIFT-377: MicroShift Rebase presubmit#36269

Closed
pmtk wants to merge 4 commits intoopenshift:masterfrom
pmtk:ushift/rebase/presubmit
Closed

USHIFT-377: MicroShift Rebase presubmit#36269
pmtk wants to merge 4 commits intoopenshift:masterfrom
pmtk:ushift/rebase/presubmit

Conversation

@pmtk
Copy link
Copy Markdown
Member

@pmtk pmtk commented Feb 10, 2023 •
edited
Loading

  • Moved main periodics into openshift-microshift-main.yaml - they're together with presubmits. Reason for that is for rebase-presubmit to reuse microshift-rebase image
  • Removed jq-cli intermediate image
  • Added workflow & step rebase-presubmit and set it up as optional presubmit

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 10, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 10, 2023

@pmtk: GitHub didn't allow me to request PR reviews from the following users: pmtk.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 10, 2023

@pmtk: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-microshift-main-rebase-presubmit openshift/microshift presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 10, 2023

/pj-rehearse

@pmtk pmtk force-pushed the ushift/rebase/presubmit branch 2 times, most recently from cff8618 to 29b5867 Compare February 13, 2023 17:16
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 13, 2023

/pj-rehearse

@pmtk pmtk force-pushed the ushift/rebase/presubmit branch 2 times, most recently from 418fe14 to 52434ce Compare February 13, 2023 17:38
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 13, 2023

/pj-rehearse

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 13, 2023

/pj-rehearse abort

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 13, 2023

/pj-rehearse pull-ci-openshift-microshift-main-rebase-presubmit

4 similar comments
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 13, 2023

/pj-rehearse pull-ci-openshift-microshift-main-rebase-presubmit

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 14, 2023

/pj-rehearse pull-ci-openshift-microshift-main-rebase-presubmit

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 14, 2023

/pj-rehearse pull-ci-openshift-microshift-main-rebase-presubmit

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 14, 2023

/pj-rehearse pull-ci-openshift-microshift-main-rebase-presubmit

@pmtk pmtk force-pushed the ushift/rebase/presubmit branch from 52434ce to 2736821 Compare February 14, 2023 09:06
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2023
pmtk added 2 commits February 14, 2023 10:12
@pmtk
keep microshift's main branch jobs in one files
589d717 
copr-rpm-health-check and rebase-on-nightlies presubmits moved to main
test-unit, test-srpm, and e2e-reboot removed
@pmtk
add rebase presubmit
bf74367
@pmtk pmtk force-pushed the ushift/rebase/presubmit branch from 2736821 to b271bf1 Compare February 14, 2023 09:17
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2023
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 14, 2023

/pj-rehearse pull-ci-openshift-microshift-main-rebase-presubmit

@pmtk pmtk force-pushed the ushift/rebase/presubmit branch from b271bf1 to 1af8488 Compare February 14, 2023 10:03
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 14, 2023

/pj-rehearse pull-ci-openshift-microshift-main-rebase-presubmit

@pmtk pmtk force-pushed the ushift/rebase/presubmit branch from 1af8488 to 72e6379 Compare February 14, 2023 12:31
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 14, 2023

/pj-rehearse pull-ci-openshift-microshift-main-rebase-presubmit

@pmtk pmtk force-pushed the ushift/rebase/presubmit branch from 72e6379 to 42801e2 Compare February 14, 2023 13:59
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 14, 2023

/pj-rehearse pull-ci-openshift-microshift-main-rebase-presubmit

@pmtk pmtk changed the title WIP microshift - rebase presubmit USHIFT-377: MicroShift Rebase presubmit Feb 14, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 14, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 14, 2023 •
edited by openshift-ci Bot
Loading

@pmtk: This pull request references USHIFT-377 which is a valid jira issue.

Details

In response to this:

/cc
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2023
pmtk added 2 commits February 14, 2023 15:22
@pmtk
remove intermediate yq-cli image
f3920de 
- it's only used for rebase
- building one image should improve execution
  time at least somehow
@pmtk
test
06d496c
@pmtk pmtk force-pushed the ushift/rebase/presubmit branch from 42801e2 to 06d496c Compare February 14, 2023 14:22
@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 14, 2023

/pj-rehearse pull-ci-openshift-microshift-main-rebase-presubmit

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 14, 2023

Waits for openshift/microshift#1351 which waits for openshift/microshift#1347

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 14, 2023 •
edited by openshift-ci Bot
Loading

@pmtk: This pull request references USHIFT-377 which is a valid jira issue.

Details

In response to this:

  • Moved main periodics into openshift-microshift-main.yaml - they're together with presubmits. Reason for that is for rebase-presubmit to reuse microshift-rebase image
  • Removed jq-cli intermediate image
  • Added workflow & step rebase-presubmit and set it up as optional presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 14, 2023

/pj-rehearse

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 14, 2023

@pmtk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-microshift-main-copr-rpm-health-check 06d496c link unknown /pj-rehearse periodic-ci-openshift-microshift-main-copr-rpm-health-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Feb 15, 2023

It's not needed right now. openshift/microshift#1351 will be part of make verify.

@pmtk pmtk closed this Feb 15, 2023
@pmtk pmtk deleted the ushift/rebase/presubmit branch November 6, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pmtk @openshift-ci-robot @openshift-merge-robot