Skip to content

add cni to coredns presubmit job names in 4.12+#37849

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jluhrsen:coredns-presubmit-renames
Mar 31, 2023
Merged

add cni to coredns presubmit job names in 4.12+#37849
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jluhrsen:coredns-presubmit-renames

Conversation

@jluhrsen
Copy link
Copy Markdown
Contributor

This adds -ovn- to all coredns presubmit job names in 4.12 and higher since the running CNI now defaults to OVNKubernetes in those releases.

One job, the gcp-serial job, is kept w/ OpenShiftSDN and thus is renamed with the -sdn- string. The gcp-ovn-serial job does not pass and the original job for gcp-serial was created with OpenShiftSDN was the default.

@openshift-ci openshift-ci Bot requested review from frobware and rfredette March 29, 2023 21:51
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@jluhrsen: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-coredns-master-e2e-aws-ovn openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-master-e2e-aws-ovn-upgrade openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-master-e2e-gcp-sdn-serial openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-master-e2e-metal-ipi-ovn openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-master-e2e-metal-ipi-ovn-dualstack openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.12-e2e-aws-ovn openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.12-e2e-aws-ovn-upgrade openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.12-e2e-gcp-sdn-serial openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.12-e2e-metal-ipi-ovn openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.12-e2e-metal-ipi-ovn-dualstack openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.13-e2e-aws-ovn-upgrade openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.13-e2e-gcp-sdn-serial openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.13-e2e-metal-ipi-ovn openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.13-e2e-metal-ipi-ovn-dualstack openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.14-e2e-aws-ovn openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.14-e2e-aws-ovn-upgrade openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.14-e2e-gcp-sdn-serial openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.14-e2e-metal-ipi-ovn openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.14-e2e-metal-ipi-ovn-dualstack openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.15-e2e-aws-ovn openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.15-e2e-aws-ovn-upgrade openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.15-e2e-gcp-sdn-serial openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.15-e2e-metal-ipi-ovn openshift/coredns presubmit Presubmit changed
pull-ci-openshift-coredns-release-4.15-e2e-metal-ipi-ovn-dualstack openshift/coredns presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jluhrsen
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@jluhrsen jluhrsen force-pushed the coredns-presubmit-renames branch from c718771 to 0fba19c Compare March 29, 2023 21:54
@jluhrsen
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

Comment thread ci-operator/config/openshift/coredns/openshift-coredns-release-4.13.yaml Outdated
Comment thread ci-operator/jobs/openshift/coredns/openshift-coredns-master-presubmits.yaml Outdated
@jluhrsen jluhrsen force-pushed the coredns-presubmit-renames branch 2 times, most recently from 6c3ddd0 to f2e12ed Compare March 30, 2023 18:09
@jluhrsen
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

This adds -ovn- to all coredns presubmit job names in 4.12
and higher since the running CNI now defaults to OVNKubernetes
in those releases.

One job, the gcp-serial job, is kept w/ OpenShiftSDN and
thus is renamed with the -sdn- string. The gcp-ovn-serial
job does not pass and the original job for gcp-serial was
created with OpenShiftSDN was the default.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen jluhrsen force-pushed the coredns-presubmit-renames branch from f2e12ed to 2f77b9e Compare March 30, 2023 21:45
@jluhrsen
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@gcs278
Copy link
Copy Markdown
Contributor

gcs278 commented Mar 30, 2023

Thanks!
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278, jluhrsen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2023
@jluhrsen
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 31, 2023
@openshift-merge-robot openshift-merge-robot merged commit 4b5cd34 into openshift:master Mar 31, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 31, 2023

@jluhrsen: Updated the following 10 configmaps:

  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-coredns-release-4.12.yaml using file ci-operator/config/openshift/coredns/openshift-coredns-release-4.12.yaml
  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-coredns-release-4.13.yaml using file ci-operator/config/openshift/coredns/openshift-coredns-release-4.13.yaml
  • job-config-4.12 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-coredns-release-4.12-presubmits.yaml using file ci-operator/jobs/openshift/coredns/openshift-coredns-release-4.12-presubmits.yaml
  • job-config-4.13 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-coredns-release-4.13-presubmits.yaml using file ci-operator/jobs/openshift/coredns/openshift-coredns-release-4.13-presubmits.yaml
  • job-config-4.14 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-coredns-release-4.14-presubmits.yaml using file ci-operator/jobs/openshift/coredns/openshift-coredns-release-4.14-presubmits.yaml
  • job-config-4.15 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-coredns-release-4.15-presubmits.yaml using file ci-operator/jobs/openshift/coredns/openshift-coredns-release-4.15-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-coredns-master.yaml using file ci-operator/config/openshift/coredns/openshift-coredns-master.yaml
  • ci-operator-4.14-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-coredns-release-4.14.yaml using file ci-operator/config/openshift/coredns/openshift-coredns-release-4.14.yaml
  • ci-operator-4.15-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-coredns-release-4.15.yaml using file ci-operator/config/openshift/coredns/openshift-coredns-release-4.15.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-coredns-master-presubmits.yaml using file ci-operator/jobs/openshift/coredns/openshift-coredns-master-presubmits.yaml
Details

In response to this:

This adds -ovn- to all coredns presubmit job names in 4.12 and higher since the running CNI now defaults to OVNKubernetes in those releases.

One job, the gcp-serial job, is kept w/ OpenShiftSDN and thus is renamed with the -sdn- string. The gcp-ovn-serial job does not pass and the original job for gcp-serial was created with OpenShiftSDN was the default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jlarriba pushed a commit to jlarriba/release that referenced this pull request Apr 4, 2023
This adds -ovn- to all coredns presubmit job names in 4.12
and higher since the running CNI now defaults to OVNKubernetes
in those releases.

One job, the gcp-serial job, is kept w/ OpenShiftSDN and
thus is renamed with the -sdn- string. The gcp-ovn-serial
job does not pass and the original job for gcp-serial was
created with OpenShiftSDN was the default.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen jluhrsen deleted the coredns-presubmit-renames branch April 4, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants