Skip to content

Conversation

@abhinavdahiya
Copy link
Contributor

Installer 1 is in progress to move to terraform version 0.12, which has breaking changes for formatting.
To add to that, upi terraform templates will be moved over to 0.12 at a later stage.

Therefore marking this optional for the time being until we have moved entire code base to 0.12.

/cc @wking

Installer [1] is in progress to move to terraform version 0.12, which has breaking changes for formatting.
To add to that, `upi` terraform templates will be moved over to 0.12 at a later stage.

Therefore marking this optional for the time being until we have moved entire code base to 0.12.

[1]: openshift/installer#1739
@openshift-ci-robot openshift-ci-robot requested a review from wking May 15, 2019 18:50
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 15, 2019
@wking
Copy link
Member

wking commented May 15, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3da535c into openshift:master May 15, 2019
@openshift-ci-robot
Copy link
Contributor

@abhinavdahiya: Updated the job-config-master configmap in namespace ci using the following files:

  • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
Details

In response to this:

Installer 1 is in progress to move to terraform version 0.12, which has breaking changes for formatting.
To add to that, upi terraform templates will be moved over to 0.12 at a later stage.

Therefore marking this optional for the time being until we have moved entire code base to 0.12.

/cc @wking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants