Skip to content

Installer: decouple installer-artifacts#38975

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
patrickdillon:decouple-installer-artifacts
Dec 2, 2023
Merged

Installer: decouple installer-artifacts#38975
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
patrickdillon:decouple-installer-artifacts

Conversation

@patrickdillon
Copy link
Copy Markdown
Contributor

Removes the dependency in installer-artifacts on the installer image in order to allow the images to be built in parallel.

Depends on openshift/installer#7159

Removes the depenendcy in installer-artifacts on the installer
image in order to allow the images to be built in parallel.
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@patrickdillon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-master-agent-integration-tests openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-aro-unit openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-agent-compact-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-agent-ha-dualstack openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-agent-sno-ipv6 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-alibaba openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-aws-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-aws-ovn-disruptive openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-aws-ovn-fips openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-aws-ovn-imdsv2 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-aws-ovn-proxy openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-aws-ovn-public-subnets openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-aws-ovn-shared-vpc openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-aws-ovn-single-node openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-aws-ovn-upgrade openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-aws-ovn-upi openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-aws-ovn-workers-rhel8 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-aws-upi-proxy openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-azure-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-azure-ovn-resourcegroup openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-azure-ovn-shared-vpc openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-azure-ovn-upi openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-azurestack openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-azurestack-upi openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-crc openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-gcp-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-gcp-ovn-shared-vpc openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-gcp-ovn-upi openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-gcp-ovn-xpn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-gcp-secureboot openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-gcp-upgrade openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-gcp-upi-xpn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-ibmcloud-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-libvirt openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-e2e-metal-assisted openshift/installer presubmit Ci-operator config changed

A total of 79 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@openshift-ci openshift-ci Bot requested review from jhixson74 and r4f4 May 3, 2023 16:05
@patrickdillon
Copy link
Copy Markdown
Contributor Author

/hold
needs discussion and depends on openshift/installer#7159

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
@openshift-bot
Copy link
Copy Markdown
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2023
@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Jun 3, 2023

/remove-lifecycle stale

@openshift-ci openshift-ci Bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2023
@openshift-bot
Copy link
Copy Markdown
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2023
@openshift-bot
Copy link
Copy Markdown
Contributor

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 29, 2023
@openshift-bot
Copy link
Copy Markdown
Contributor

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci Bot closed this Aug 13, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 13, 2023

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Nov 30, 2023

/reopen

@openshift-ci openshift-ci Bot reopened this Nov 30, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 30, 2023

@r4f4: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Nov 30, 2023

/remove-lifecycle rotten

@openshift-ci openshift-ci Bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 30, 2023
@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Nov 30, 2023

Waiting on openshift/installer#7782 before removing the hold.

@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Nov 30, 2023

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Dec 2, 2023

openshift/installer#7782 has merged.
/hold cancel
/pj-rehearse pull-ci-openshift-installer-master-aro-unit

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2023
@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Dec 2, 2023

/pj-rehearse pull-ci-openshift-installer-master-images

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@r4f4, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase candidate onto master: %!w(<nil>)

1 similar comment
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@r4f4, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase candidate onto master: %!w(<nil>)

@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Dec 2, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 2, 2023
@r4f4
Copy link
Copy Markdown
Contributor

r4f4 commented Dec 2, 2023

See tests results in #46337

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8d5801b and 2 for PR HEAD 09d5965 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 2, 2023

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 74d3631 into openshift:master Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants