Skip to content

USHIFT-1298: disable cgo when cross-compiling#39934

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
dhellmann:USHIFT-1298-enable-cgo
Jun 5, 2023
Merged

USHIFT-1298: disable cgo when cross-compiling#39934
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
dhellmann:USHIFT-1298-enable-cgo

Conversation

@dhellmann
Copy link
Copy Markdown
Contributor

@dhellmann dhellmann commented Jun 1, 2023

The MicroShift build sets CGO_ENABLED=1 by default, but that does not
work when cross-compiling to aarch64 so disable it in the CI build step.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 1, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 1, 2023 •
edited by openshift-ci Bot
Loading

@dhellmann: This pull request references USHIFT-1298 which is a valid jira issue.

Details

In response to this:

The MicroShift build sets CGO_ENABLED=1 by default, but that does not
work when cross-compiling to aarch64 so disable it in the CI build step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented Jun 1, 2023

/assign @pacevedom @pmtk

@dhellmann dhellmann mentioned this pull request Jun 1, 2023
Merged
@openshift-ci openshift-ci Bot requested review from copejon and pacevedom June 1, 2023 17:57
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2023
@dhellmann
USHIFT-1298: disable cgo when cross-compiling
91044ec 
The MicroShift build sets CGO_ENABLED=1 by default, but that does not
work when cross-compiling to aarch64 so disable it in the CI build step.
@dhellmann dhellmann force-pushed the USHIFT-1298-enable-cgo branch from 9c6f927 to 91044ec Compare June 1, 2023 18:04
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 1, 2023

[REHEARSALNOTIFIER]
@dhellmann: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-microshift-release-4.15-e2e-openshift-conformance-reduced openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.15-e2e-openshift-conformance-reduced-arm openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.15-images openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.15-microshift-e2e openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.15-microshift-e2e-arm openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.15-test-srpm openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.15-test-unit openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.15-verify openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced-arm openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-images openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-microshift-e2e openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-microshift-e2e-arm openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-test-srpm openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-test-unit openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-verify openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.14-e2e-openshift-conformance-reduced openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.14-e2e-openshift-conformance-reduced-arm openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.14-images openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.14-microshift-e2e openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.14-microshift-e2e-arm openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.14-test-srpm openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.14-test-unit openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.14-verify openshift/microshift presubmit Ci-operator config changed
periodic-ci-openshift-microshift-main-rebase-on-nightlies N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented Jun 1, 2023

/pj-rehearse

@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented Jun 1, 2023

openshift-tests panicked, but that means we want past the point where the compilation of MicroShift would be different. The actual change to the Makefile is coming separately in openshift/microshift#1869

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 1, 2023
@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented Jun 2, 2023

/retest-required

@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented Jun 2, 2023

/pj-rehearse

@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented Jun 2, 2023

/pj-rehearse ack

The e2e tests passed but the job failed to collect the debug data so it failed. The conformance job shows the same panic that has been fixed, which comes from running openshift-tests after successfully building. The ARM jobs are failing the tests, which also means the build was successful.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 3, 2023

@dhellmann: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/microshift/release-4.14/e2e-openshift-conformance-reduced 91044ec link unknown /pj-rehearse pull-ci-openshift-microshift-release-4.14-e2e-openshift-conformance-reduced
ci/rehearse/openshift/microshift/release-4.14/e2e-openshift-conformance-reduced-arm 91044ec link unknown /pj-rehearse pull-ci-openshift-microshift-release-4.14-e2e-openshift-conformance-reduced-arm
ci/rehearse/openshift/microshift/release-4.14/microshift-e2e-arm 91044ec link unknown /pj-rehearse pull-ci-openshift-microshift-release-4.14-microshift-e2e-arm
ci/rehearse/openshift/microshift/release-4.15/e2e-openshift-conformance-reduced-arm 91044ec link unknown /pj-rehearse pull-ci-openshift-microshift-release-4.15-e2e-openshift-conformance-reduced-arm
ci/rehearse/openshift/microshift/main/microshift-e2e-arm 91044ec link unknown /pj-rehearse pull-ci-openshift-microshift-main-microshift-e2e-arm
ci/rehearse/openshift/microshift/main/e2e-openshift-conformance-reduced-arm 91044ec link unknown /pj-rehearse pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced-arm
ci/rehearse/openshift/microshift/main/microshift-e2e 91044ec link unknown /pj-rehearse pull-ci-openshift-microshift-main-microshift-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pacevedom
pacevedom approved these changes Jun 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9106378 into openshift:master Jun 5, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2023

@dhellmann: Updated the following 3 configmaps:

  • ci-operator-main-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-microshift-main.yaml using file ci-operator/config/openshift/microshift/openshift-microshift-main.yaml
  • ci-operator-4.14-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-microshift-release-4.14.yaml using file ci-operator/config/openshift/microshift/openshift-microshift-release-4.14.yaml
  • ci-operator-4.15-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-microshift-release-4.15.yaml using file ci-operator/config/openshift/microshift/openshift-microshift-release-4.15.yaml
Details

In response to this:

The MicroShift build sets CGO_ENABLED=1 by default, but that does not
work when cross-compiling to aarch64 so disable it in the CI build step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@copejon copejon Awaiting requested review from copejon

1 more reviewer

@pacevedom pacevedom pacevedom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pmtk pmtk

@pacevedom pacevedom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhellmann @openshift-ci-robot @pacevedom @pmtk @openshift-merge-robot