Skip to content

Hive/master: Use latest HCP for e2e-pool#39941

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
2uasimojo:HIVE-2234/master-e2e-pool-hcp-latest
Aug 3, 2023
Merged

Hive/master: Use latest HCP for e2e-pool#39941
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
2uasimojo:HIVE-2234/master-e2e-pool-hcp-latest

Conversation

@2uasimojo
Copy link
Copy Markdown
Member

@2uasimojo 2uasimojo commented Jun 1, 2023 •
edited by openshift-ci Bot
Loading

Hive/master: Use latest HCP for e2e-pool

Convert e2e-pool from using the CI-owned 4.12 ClusterPool to
requesting a hosted control plane (hypershift) cluster at the latest
release (currently 4.14).

Leaving e2e alone for now, as it improves our coverage to have it
continue testing on a "classic" hub at 4.12.

HIVE-2234

@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Jun 1, 2023

/pj-rehearse

@openshift-ci openshift-ci Bot requested review from jstuever and suhanime June 1, 2023 20:38
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2023
@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Jun 1, 2023

/pj-rehearse pull-ci-openshift-hive-master-e2e-pool

@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Jun 2, 2023

Azure and gcp both failing consistently on autoscaling.

/pj-rehearse ci/rehearse/openshift/hive/master/e2e-gcp
/pj-rehearse ci/rehearse/openshift/hive/master/e2e-azure

e2e-pool failing consistently trying to get a hcp for the test bed.

/pj-rehearse ci/rehearse/openshift/hive/master/e2e-pool

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 2, 2023

@2uasimojo: job(s): ci/rehearse/openshift/hive/master/e2e-gcp either don't exist or were not found to be affected, and cannot be rehearsed

@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Jun 2, 2023

/pj-rehearse pull-ci-openshift-hive-master-e2e-gcp pull-ci-openshift-hive-master-e2e-azure pull-ci-openshift-hive-master-e2e-pool

@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Jun 2, 2023

Also

/pj-rehearse pull-ci-openshift-hive-master-e2e

@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Jun 2, 2023

/pj-rehearse pull-ci-openshift-hive-master-e2e-pool

One more try before picking up the phone to testplatform...

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 2, 2023

@2uasimojo, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout 00ded131c4badf80ce2f51f7f5b3de9bc89a634a]' failed with out: fatal: reference is not a tree: 00ded131c4badf80ce2f51f7f5b3de9bc89a634a
and error exit status 128

If the problem persists, please contact Test Platform.

@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Jun 6, 2023

https://issues.redhat.com/browse/DPTP-3490 asking about the HCP failz

@2uasimojo 2uasimojo force-pushed the HIVE-2234/master-e2e-pool-hcp-latest branch from 80d7a70 to a145326 Compare June 12, 2023 20:38
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 12, 2023

@2uasimojo, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase repo client
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@2uasimojo 2uasimojo force-pushed the HIVE-2234/master-e2e-pool-hcp-latest branch from a145326 to befe486 Compare June 12, 2023 20:40
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2023
@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Jun 12, 2023

/pj-rehearse pull-ci-openshift-hive-master-e2e-pool

2 similar comments
@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Jun 13, 2023

/pj-rehearse pull-ci-openshift-hive-master-e2e-pool

@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Jun 13, 2023

/pj-rehearse pull-ci-openshift-hive-master-e2e-pool

@2uasimojo 2uasimojo force-pushed the HIVE-2234/master-e2e-pool-hcp-latest branch from befe486 to 51df656 Compare June 13, 2023 18:09
@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Jun 13, 2023

/pj-rehearse pull-ci-openshift-hive-master-e2e-pool

1 similar comment
@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Jun 14, 2023

/pj-rehearse pull-ci-openshift-hive-master-e2e-pool

@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Jun 14, 2023

Well, that's a slightly different permission error, which encourages me to try again...

/pj-rehearse pull-ci-openshift-hive-master-e2e-pool

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2023
@2uasimojo 2uasimojo force-pushed the HIVE-2234/master-e2e-pool-hcp-latest branch from 51df656 to e0f6d1c Compare June 23, 2023 21:23
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2023
@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Jun 23, 2023

/pj-rehearse pull-ci-openshift-hive-master-e2e-pool

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2023
@2uasimojo 2uasimojo force-pushed the HIVE-2234/master-e2e-pool-hcp-latest branch from e0f6d1c to 5aee56e Compare June 30, 2023 20:53
@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Aug 1, 2023

/pj-rehearse pull-ci-openshift-hive-master-e2e-pool

@2uasimojo 2uasimojo force-pushed the HIVE-2234/master-e2e-pool-hcp-latest branch from c9bd4a9 to 7701074 Compare August 2, 2023 01:52
@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Aug 2, 2023

/pj-rehearse pull-ci-openshift-hive-master-e2e-pool

@2uasimojo
Hive/master: Use latest HCP for e2e-pool
698f172 
Convert `e2e-pool` from using the CI-owned 4.12 ClusterPool to
requesting a hosted control plane (hypershift) cluster at the `latest`
release (currently 4.13).

Leaving `e2e` alone for now, as it improves our coverage to have it
continue testing on a "classic" hub at 4.12.

HIVE-2234
@2uasimojo 2uasimojo force-pushed the HIVE-2234/master-e2e-pool-hcp-latest branch from 7701074 to 698f172 Compare August 2, 2023 01:54
@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Aug 2, 2023

/pj-rehearse pull-ci-openshift-hive-master-e2e-pool

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 2, 2023

[REHEARSALNOTIFIER]
@2uasimojo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hive-master-e2e-pool openshift/hive presubmit Presubmit changed
pull-ci-openshift-hive-master-images openshift/hive presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Aug 2, 2023

/pj-rehearse pull-ci-openshift-hive-master-e2e-pool

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 2, 2023 •
edited
Loading

@2uasimojo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/hive/master/e2e-gcp 80d7a70a575f0a763f9ed5c46fb1c9d682ae1474 link unknown /pj-rehearse pull-ci-openshift-hive-master-e2e-gcp
ci/rehearse/openshift/hive/master/e2e-azure 80d7a70a575f0a763f9ed5c46fb1c9d682ae1474 link unknown /pj-rehearse pull-ci-openshift-hive-master-e2e-azure
ci/build-farm/build04-dry 5aee56eeca33afc31cad6c4dee4d64ad525e56a8 link true /test build04-dry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Aug 2, 2023

/pj-rehearse pull-ci-openshift-hive-master-e2e-pool

We're getting real close.

@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Aug 2, 2023

/pj-rehearse ack

🥳

/assign @lleshchi

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 2, 2023
@2uasimojo
Copy link
Copy Markdown
Member Author

2uasimojo commented Aug 3, 2023

/cc @suhanime

2uasimojo
2uasimojo commented Aug 3, 2023
View reviewed changes
Comment thread ci-operator/config/openshift/hive/openshift-hive-master.yaml
Comment on lines +136 to +137
export AWS_ACCESS_KEY_ID=$(cat /tmp/hivesecret/hive-aws-creds/AWS_ACCESS_KEY_ID)
export AWS_SECRET_ACCESS_KEY=$(cat /tmp/hivesecret/hive-aws-creds/AWS_SECRET_ACCESS_KEY)
Copy link
Copy Markdown
Member Author

@2uasimojo 2uasimojo Aug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See DPTP-3490 for context on /tmp/secret => /tmp/hivesecret.

@lleshchi
Copy link
Copy Markdown
Contributor

lleshchi commented Aug 3, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, lleshchi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4898544 into openshift:master Aug 3, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 3, 2023

@2uasimojo: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-hive-master.yaml using file ci-operator/config/openshift/hive/openshift-hive-master.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-hive-master-presubmits.yaml using file ci-operator/jobs/openshift/hive/openshift-hive-master-presubmits.yaml
Details

In response to this:

Hive/master: Use latest HCP for e2e-pool

Convert e2e-pool from using the CI-owned 4.12 ClusterPool to
requesting a hosted control plane (hypershift) cluster at the latest
release (currently 4.14).

Leaving e2e alone for now, as it improves our coverage to have it
continue testing on a "classic" hub at 4.12.

HIVE-2234

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@2uasimojo 2uasimojo deleted the HIVE-2234/master-e2e-pool-hcp-latest branch August 3, 2023 21:26
@2uasimojo 2uasimojo mentioned this pull request Aug 15, 2023
Merged
2uasimojo added a commit to 2uasimojo/release that referenced this pull request Aug 15, 2023
@2uasimojo
Revert "Hive/master: Use latest HCP for e2e-pool (openshift#39941)"
962dacf 
This reverts commit 4898544.

Per DPTP-3611 hypershift isn't being supported, and we're running into too many problems with it.
openshift-merge-robot pushed a commit that referenced this pull request Aug 15, 2023
@2uasimojo
Revert "Hive/master: Use latest HCP for e2e-pool (#39941)" (#42373)
9bbfd08 
This reverts commit 4898544.

Per DPTP-3611 hypershift isn't being supported, and we're running into too many problems with it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@suhanime suhanime Awaiting requested review from suhanime

Assignees

@lleshchi lleshchi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@2uasimojo @openshift-ci-robot @bear-redhat @lleshchi @openshift-merge-robot