ROX-17751: Add GKE target for sensor-integration tests by vikin91 · Pull Request #40290 · openshift/release

vikin91 · 2023-06-13T09:31:57Z

Requires stackrox/stackrox#6480 for the rehearsals to pass

openshift-ci-robot · 2023-06-13T09:32:00Z

@vikin91: This pull request references ROX-17751 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vikin91 · 2023-06-13T09:42:32Z

/pj-rehearse

vikin91 · 2023-06-13T10:42:02Z

Requires stackrox/stackrox#6416 or stackrox/stackrox#6480 for the rehearsals to pass

openshift-ci-robot · 2023-06-13T10:42:18Z

@vikin91: This pull request references ROX-17751 which is a valid jira issue.

Details

In response to this:

Requires stackrox/stackrox#6416 for the rehearsals to pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-06-13T12:34:34Z

@vikin91: This pull request references ROX-17751 which is a valid jira issue.

Details

In response to this:

Requires stackrox/stackrox#6480 for the rehearsals to pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vikin91 · 2023-06-13T14:31:57Z

/pj-rehearse

vikin91 · 2023-06-13T15:09:00Z

/pj-rehearse pull-ci-stackrox-stackrox-release-x.y-gke-sensor-integration-tests

vikin91 · 2023-06-13T16:55:19Z

/pj-rehearse

openshift-ci-robot · 2023-06-13T16:56:14Z

@vikin91, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: job pull-ci-stackrox-stackrox-master-gke-sensor-integration-tests is set to always run but also declares skip_if_only_changed targets, which are mutually exclusive

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-ci-robot · 2023-06-13T16:58:01Z

@vikin91, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: job pull-ci-stackrox-stackrox-master-gke-sensor-integration-tests is set to always run but also declares skip_if_only_changed targets, which are mutually exclusive

If the problem persists, please contact Test Platform.

vikin91 · 2023-06-13T17:02:29Z

/pj-rehearse

gavin-stackrox · 2023-06-13T17:05:19Z

  steps:
    test:
    - ref: stackrox-e2e
+- as: gke-sensor-integration-tests


You will need to add a merge- a postsubmit: true version of this.

Added that in fec3275

gavin-stackrox · 2023-06-13T17:10:52Z

          secretName: result-aggregator
    trigger: (?m)^/test( | .* )gke-scale-tests,?($|\s.*)
+  - agent: kubernetes
+    always_run: true


Suggested change

always_run: true

always_run: false

And use skip_if_only_changed: ^ui/ https://docs.prow.k8s.io/docs/jobs/#triggering-jobs-based-on-changes

Added that in fec3275

gavin-stackrox · 2023-06-13T17:12:07Z

    test:
    - ref: stackrox-e2e
+- as: gke-sensor-integration-tests
+  optional: true


All of nightlies are postsubmit jobs.

Suggested change

optional: true

postsubmit: true

Added that in fec3275

openshift-ci-robot · 2023-06-13T17:23:54Z

[REHEARSALNOTIFIER]
@vikin91: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-stackrox-stackrox-master-gke-sensor-integration-tests	stackrox/stackrox	presubmit	Presubmit changed
pull-ci-stackrox-stackrox-release-x.y-gke-sensor-integration-tests	stackrox/stackrox	presubmit	Presubmit changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

vikin91 · 2023-06-13T17:36:54Z

/pj-rehearse

openshift-ci · 2023-06-13T18:24:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vikin91, vjwilson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/stackrox/stackrox/OWNERS~~ [vjwilson]
~~ci-operator/jobs/stackrox/stackrox/OWNERS~~ [vjwilson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vikin91 · 2023-06-14T01:07:52Z

/pj-rehearse auto-ack

vikin91 · 2023-06-14T07:11:08Z

/pj-rehearse pull-ci-stackrox-stackrox-release-x.y-gke-sensor-integration-tests

vikin91 · 2023-06-14T08:04:50Z

/pj-rehearse ack

openshift-ci · 2023-06-14T08:42:56Z

@vikin91: Updated the following 5 configmaps:

job-config-misc configmap in namespace ci at cluster app.ci using the following files:
- key stackrox-stackrox-nightlies-postsubmits.yaml using file ci-operator/jobs/stackrox/stackrox/stackrox-stackrox-nightlies-postsubmits.yaml
- key stackrox-stackrox-release-x.y-postsubmits.yaml using file ci-operator/jobs/stackrox/stackrox/stackrox-stackrox-release-x.y-postsubmits.yaml
- key stackrox-stackrox-release-x.y-presubmits.yaml using file ci-operator/jobs/stackrox/stackrox/stackrox-stackrox-release-x.y-presubmits.yaml
ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
- key stackrox-stackrox-master.yaml using file ci-operator/config/stackrox/stackrox/stackrox-stackrox-master.yaml
ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
- key stackrox-stackrox-nightlies.yaml using file ci-operator/config/stackrox/stackrox/stackrox-stackrox-nightlies.yaml
- key stackrox-stackrox-release-x.y.yaml using file ci-operator/config/stackrox/stackrox/stackrox-stackrox-release-x.y.yaml
job-config-master-postsubmits configmap in namespace ci at cluster app.ci using the following files:
- key stackrox-stackrox-master-postsubmits.yaml using file ci-operator/jobs/stackrox/stackrox/stackrox-stackrox-master-postsubmits.yaml
job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
- key stackrox-stackrox-master-presubmits.yaml using file ci-operator/jobs/stackrox/stackrox/stackrox-stackrox-master-presubmits.yaml

Details

In response to this:

Requires stackrox/stackrox#6480 for the rehearsals to pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* X-Smart-Branch-Parent: master * Add gke sensor integration tests * Run ocp-sensor-integration tests less * Remove skip_if_only_changed from gke-sensor-integration-tests * Address review comments #1

vikin91 added 2 commits June 13, 2023 09:13

X-Smart-Branch-Parent: master

6b0434a

Add gke sensor integration tests

0862b73

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 13, 2023

openshift-ci Bot requested review from JoukoVirtanen and vjwilson June 13, 2023 09:32

vikin91 added a commit to stackrox/stackrox that referenced this pull request Jun 13, 2023

Add gke_sensor_integration.py needed by openshift/release#40290

7dfc8f9

vikin91 added a commit to stackrox/stackrox that referenced this pull request Jun 13, 2023

Add gke_sensor_integration.py needed by openshift/release#40290

9ebe174

vikin91 mentioned this pull request Jun 13, 2023

ROX-17673: Add target for GKE-based sensor-integration tests stackrox/stackrox#6480

Merged

5 tasks

vikin91 added a commit to stackrox/stackrox that referenced this pull request Jun 13, 2023

Add gke_sensor_integration.py needed by openshift/release#40290

6c9de29

vikin91 mentioned this pull request Jun 13, 2023

ROX-17673: Remove pre and post tests from sensor-integration target stackrox/stackrox#6484

Merged

5 tasks

Run ocp-sensor-integration tests less

5f01186

Remove skip_if_only_changed from gke-sensor-integration-tests

f765189

gavin-stackrox suggested changes Jun 13, 2023

View reviewed changes

openshift-ci Bot assigned gavin-stackrox Jun 13, 2023

Address review comments #1

fec3275

vjwilson approved these changes Jun 13, 2023

View reviewed changes

openshift-ci Bot assigned vjwilson Jun 13, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 14, 2023

openshift-merge-robot merged commit 1ed40f0 into openshift:master Jun 14, 2023

Conversation

vikin91 commented Jun 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 13, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vikin91 commented Jun 13, 2023

Uh oh!

vikin91 commented Jun 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 13, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 13, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vikin91 commented Jun 13, 2023

Uh oh!

vikin91 commented Jun 13, 2023

Uh oh!

vikin91 commented Jun 13, 2023

Uh oh!

openshift-ci-robot commented Jun 13, 2023

Uh oh!

openshift-ci-robot commented Jun 13, 2023

Uh oh!

vikin91 commented Jun 13, 2023

Uh oh!

gavin-stackrox Jun 13, 2023

Choose a reason for hiding this comment

Uh oh!

vikin91 Jun 13, 2023

Choose a reason for hiding this comment

Uh oh!

gavin-stackrox Jun 13, 2023

Choose a reason for hiding this comment

Uh oh!

vikin91 Jun 13, 2023

Choose a reason for hiding this comment

Uh oh!

gavin-stackrox Jun 13, 2023

Choose a reason for hiding this comment

Uh oh!

vikin91 Jun 13, 2023

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jun 13, 2023

Uh oh!

vikin91 commented Jun 13, 2023

Uh oh!

openshift-ci Bot commented Jun 13, 2023

Uh oh!

vikin91 commented Jun 14, 2023

Uh oh!

vikin91 commented Jun 14, 2023

Uh oh!

vikin91 commented Jun 14, 2023

Uh oh!

openshift-ci Bot commented Jun 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vikin91 commented Jun 13, 2023 •

edited

Loading

openshift-ci-robot commented Jun 13, 2023 •

edited by openshift-ci Bot

Loading

vikin91 commented Jun 13, 2023 •

edited

Loading

openshift-ci-robot commented Jun 13, 2023 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Jun 13, 2023 •

edited by openshift-ci Bot

Loading