Skip to content

Run make release-controllers#40296

Closed
stbenjam wants to merge 1 commit intoopenshift:masterfrom
stbenjam:make-release-controllers
Closed

Run make release-controllers#40296
stbenjam wants to merge 1 commit intoopenshift:masterfrom
stbenjam:make-release-controllers

Conversation

@stbenjam
Copy link
Copy Markdown
Member

@stbenjam stbenjam commented Jun 13, 2023

#39897 didn't run make release-controllers.

@stbenjam
Run make release-controllers
ee2a33d 
openshift#39897 didn't run `make
release-controllers`.
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 13, 2023

[REHEARSALNOTIFIER]
@stbenjam: no rehearsable tests are affected by this change

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 13, 2023
@stbenjam stbenjam mentioned this pull request Jun 13, 2023
Merged
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 13, 2023

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Jun 13, 2023

Nevermind, changes were included in my other PR #40298

@stbenjam stbenjam closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DennisPeriquet DennisPeriquet Awaiting requested review from DennisPeriquet

@xueqzhan xueqzhan Awaiting requested review from xueqzhan

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stbenjam @openshift-ci-robot