Skip to content

Conversation

@joelanford
Copy link
Member

Use script from repo instead of hard-coded command for test_binary_build_commands.

See operator-framework/operator-sdk#1572

/cc @AlexNPavel @lilic @estroz

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 19, 2019
@estroz
Copy link
Contributor

estroz commented Jun 19, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ac59dbb into openshift:master Jun 19, 2019
@openshift-ci-robot
Copy link
Contributor

@joelanford: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key operator-framework-operator-sdk-master.yaml using file ci-operator/config/operator-framework/operator-sdk/operator-framework-operator-sdk-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key operator-framework-operator-sdk-master.yaml using file ci-operator/config/operator-framework/operator-sdk/operator-framework-operator-sdk-master.yaml
Details

In response to this:

Use script from repo instead of hard-coded command for test_binary_build_commands.

See operator-framework/operator-sdk#1572

/cc @AlexNPavel @lilic @estroz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joelanford joelanford deleted the operator-sdk-test-binary-build-commands branch February 14, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants