Reverting logic that causes validation to silently fail#41384
Reverting logic that causes validation to silently fail#41384openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
|
[REHEARSALNOTIFIER] |
|
@bradmwilliams: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bradmwilliams, jupierce The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reverting a change, from #39897, that's causing the release-controller validation script to silently fail since it was introduced:
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/39897/pull-ci-openshift-release-master-release-controller-config/1666153420840505344
While I appreciate the rationale behind the change we specifically added the "ERROR" verbiage, to this test, to tell you exactly what needs to be done to address the problem. Sure, a git diff might be nice to see, but ultimately it's the
make release-controllersthat will fix this issue.@wking If this is truly a show-stopper, then let me know and we'll make the necessary changes to support it.