Skip to content

Add slack alert when 4.13 rollback job fails#41525

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shellyyang1989:rollback-alert
Jul 31, 2023
Merged

Add slack alert when 4.13 rollback job fails#41525
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shellyyang1989:rollback-alert

Conversation

@shellyyang1989
Copy link
Copy Markdown
Contributor

Per slack thread, we've decided to make a slack alert for the 4.13 rollback failures.

The channel I use here doesn't exist, I'll create it if it looks good to reviewers.

@openshift-ci openshift-ci Bot requested review from deepsm007 and jupierce July 21, 2023 10:04
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 21, 2023
Comment thread ci-operator/jobs/openshift/release/openshift-release-master-periodics.yaml Outdated
@jianlinliu
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
Comment thread ci-operator/jobs/openshift/release/openshift-release-master-periodics.yaml Outdated
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@shellyyang1989
Copy link
Copy Markdown
Contributor Author

@deepsm007 could you please help approve it?

@deepsm007
Copy link
Copy Markdown
Contributor

/lgtm
For approval you need someone from https://github.com/openshift/release/blob/master/ci-operator/jobs/openshift/release/OWNERS list of approvers to tag it.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@shellyyang1989
Copy link
Copy Markdown
Contributor Author

Per the slack channel convention, looks like we need to rename it to alerts-ocp-rollback-ci. WDYT @wking @jianlinliu

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@jianlinliu
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2023
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are reporting both failure and error, it might be worth including {{.Status.State}} here, like:

Job {{.Spec.Job}} ended with {{.Status.State}}, see <{{.Status.URL}}|here>.

or some such. <{{.Status.URL}}|View logs> seems more popular grepping for existing report_template content, and personally there is more in the job-details page in logs, so I like here. But it's not pinging me, so 🤷, feel free to take this feedback and do whatever you want with it, including leaving the string you're currently using in place.

/approve
/hold in case you did want to make changes

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Trevor! Updated.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@shellyyang1989: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Copy Markdown
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, jianlinliu, shellyyang1989, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@openshift-merge-robot openshift-merge-robot merged commit de68dab into openshift:master Jul 31, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 31, 2023

@shellyyang1989: Updated the job-config-master-periodics configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-release-master-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-periodics.yaml
Details

In response to this:

Per slack thread, we've decided to make a slack alert for the 4.13 rollback failures.

The channel I use here doesn't exist, I'll create it if it looks good to reviewers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants