Add slack alert when 4.13 rollback job fails#41525
Add slack alert when 4.13 rollback job fails#41525openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
165b415 to
ec9ab43
Compare
ec9ab43 to
60606b0
Compare
|
/lgtm |
60606b0 to
47a59fa
Compare
|
@deepsm007 could you please help approve it? |
|
/lgtm |
|
Per the slack channel convention, looks like we need to rename it to |
47a59fa to
885637b
Compare
|
/lgtm |
There was a problem hiding this comment.
If we are reporting both failure and error, it might be worth including {{.Status.State}} here, like:
Job {{.Spec.Job}} ended with {{.Status.State}}, see <{{.Status.URL}}|here>.
or some such. <{{.Status.URL}}|View logs> seems more popular grepping for existing report_template content, and personally there is more in the job-details page in logs, so I like here. But it's not pinging me, so 🤷, feel free to take this feedback and do whatever you want with it, including leaving the string you're currently using in place.
/approve
/hold in case you did want to make changes
There was a problem hiding this comment.
Thank you Trevor! Updated.
885637b to
7eadd4c
Compare
|
[REHEARSALNOTIFIER] Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepsm007, jianlinliu, shellyyang1989, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@shellyyang1989: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Per slack thread, we've decided to make a slack alert for the 4.13 rollback failures.
The channel I use here doesn't exist, I'll create it if it looks good to reviewers.