Skip to content

add explanation of blocking jobs in master before service streams#43418

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:add-explanation
Sep 18, 2023
Merged

add explanation of blocking jobs in master before service streams#43418
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:add-explanation

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Sep 15, 2023

This isn't generally obvious, so it's worth explaining in the doc. A linter would be even better, but I'm unsure of where such a linter would be.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 15, 2023
Comment on lines 7 to 10
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This means that a new job must first become blocking on master before becoming blocking on service
streams in order to be confident that our backports will pass our service stream testing.
If an exception is required due to instability of a job on master, that exception must be accepted
by the party responsible for service stream quality, currently the rotation of patch managers.
This means that a new job must first become blocking on master before becoming blocking on release
branches in order to be confident that our backports will pass our release branch testing.
If an exception is required due to instability of a job on master, that exception must be accepted
by the party responsible for release branch quality, currently the rotation of patch managers.

I feel like this is a more commonly understood term but maybe I'm wrong. Fine either way.

@sdodson
Copy link
Copy Markdown
Member

sdodson commented Sep 15, 2023

/lgtm
/hold
Feel free to clear the hold and disregard my wording feedback or happy to lgtm after you've updated.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2023
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2023
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Sep 18, 2023

updated word choice.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@deads2k: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Sep 18, 2023

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2023
@sdodson
Copy link
Copy Markdown
Member

sdodson commented Sep 18, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 18, 2023

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit dbcbb85 into openshift:master Sep 18, 2023
wking added a commit to wking/openshift-release that referenced this pull request Sep 21, 2023
4.14, becasue we want to freeze these through the life of 4.14,
following the existing pattern, most recently d666767
(ci-operator/config/openshift/release/openshift-release-master__nightly-4.13:
Add oldest-* jobs, 2023-04-26, openshift#38728).  I'm not pulling in the
rollback job this time, because that's moving under QE and is in
flight separately in [1].

I'm also adding a 4.15 cred-freeze job this time, to catch up with
dbcbb85 (add explanation of blocking jobs in master before service
streams, 2023-09-18, openshift#43418).  As I pointed out in d666767, I'm
still concerned about the amount of churn that I expect will land
during the engineering candidate, but I'm not on the release-oversight
team, and if they perfer having a blocker job in the development
branch with occasional pin bumps, that's fine with me.

The bulk of the ci-operator/jobs content is from:

  $ make jobs

But then I manually edited to inject reporter_config, as described in
08db24d (ci-operator/jobs/openshift/release: Ping @Patch-Manager
for cred-freeze failures, 2021-12-08, openshift#24177).

[1]: openshift#43401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants