Skip to content

Sync Serverless CI #44332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-ci merged 6 commits into from
Oct 13, 2023
Merged

Sync Serverless CI #44332

openshift-ci merged 6 commits into from
Oct 13, 2023

Conversation

@serverless-qe
Copy link
Contributor

@serverless-qe serverless-qe commented Oct 13, 2023

Sync Serverless CI using openshift-knative/hack.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2023

Hi @serverless-qe. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from alanfx and aliok October 13, 2023 06:12
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 13, 2023

[REHEARSALNOTIFIER]
@serverless-qe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-knative-serving-release-v1.10-411-images openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411 openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411 openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-images openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411 openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411 openshift-knative/serving presubmit Presubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.10-411-images openshift-knative/net-kourier presubmit Presubmit changed
pull-ci-openshift-knative-net-kourier-release-v1.11-411-images openshift-knative/net-kourier presubmit Presubmit changed
pull-ci-openshift-knative-net-istio-release-v1.10-411-images openshift-knative/net-istio presubmit Presubmit changed
pull-ci-openshift-knative-net-istio-release-v1.11-411-images openshift-knative/net-istio presubmit Presubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-images openshift-knative/eventing-kafka-broker presubmit Presubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411 openshift-knative/eventing-kafka-broker presubmit Presubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411 openshift-knative/eventing-kafka-broker presubmit Presubmit changed
pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411 openshift-knative/eventing-kafka-broker presubmit Presubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411 openshift-knative/eventing-istio presubmit Presubmit changed
pull-ci-openshift-knative-eventing-istio-release-v1.10-411-images openshift-knative/eventing-istio presubmit Presubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-images openshift-knative/eventing presubmit Presubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411 openshift-knative/eventing presubmit Presubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411 openshift-knative/eventing presubmit Presubmit changed
pull-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411 openshift-knative/eventing presubmit Presubmit changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-reconciler-aws-ocp-411-continuous N/A periodic Periodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-tls-aws-ocp-411-continuous N/A periodic Periodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-conformance-aws-ocp-411-continuous N/A periodic Periodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-e2e-aws-ocp-411-continuous N/A periodic Periodic changed
periodic-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411-continuous N/A periodic Periodic changed
periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuous N/A periodic Periodic changed
periodic-ci-openshift-knative-eventing-istio-release-v1.10-411-e2e-tests-aws-ocp-411-continuous N/A periodic Periodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-tls-aws-ocp-411-continuous N/A periodic Periodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-conformance-aws-ocp-411-continuous N/A periodic Periodic changed
periodic-ci-openshift-knative-serving-release-v1.11-411-test-e2e-aws-ocp-411-continuous N/A periodic Periodic changed
periodic-ci-openshift-knative-eventing-release-v1.10-411-test-e2e-aws-ocp-411-continuous N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@skonto
Copy link
Contributor

skonto commented Oct 13, 2023

For reference this comes from: openshift-knative/hack#78.

@skonto
Copy link
Contributor

skonto commented Oct 13, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2023
@skonto
Copy link
Contributor

skonto commented Oct 13, 2023

/pj-rehearse max

@skonto
Copy link
Contributor

skonto commented Oct 13, 2023

/hold for tests

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
@skonto
Copy link
Contributor

skonto commented Oct 13, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@skonto
Copy link
Contributor

skonto commented Oct 13, 2023

cc @pierDipi for the approval.

@ReToCode ReToCode mentioned this pull request Oct 13, 2023
Merged
@skonto
Copy link
Contributor

skonto commented Oct 13, 2023

or @matzew could you approve?

@skonto
Copy link
Contributor

skonto commented Oct 13, 2023

Serving job failed with:

{  failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

@skonto
Copy link
Contributor

skonto commented Oct 13, 2023

/pj-rehearse pull-ci-openshift-knative-serving-release-v1.10-411-test-e2e-aws-ocp-411

@skonto
Copy link
Contributor

skonto commented Oct 13, 2023

/pj-rehearse periodic-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411-continuous

@skonto
Copy link
Contributor

skonto commented Oct 13, 2023

/pj-rehearse pull-ci-openshift-knative-eventing-kafka-broker-release-v1.10-411-test-reconciler-aws-ocp-411

@pierDipi
Copy link
Member

pierDipi commented Oct 13, 2023

/lgtm
/approve

pierDipi
pierDipi approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, serverless-qe, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@pierDipi
Copy link
Member

pierDipi commented Oct 13, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2023
@skonto
Copy link
Contributor

skonto commented Oct 13, 2023

/unhold

@pierDipi
Copy link
Member

pierDipi commented Oct 13, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 13, 2023
@openshift-ci openshift-ci bot merged commit 064bff3 into openshift:master Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanfx alanfx Awaiting requested review from alanfx

@aliok aliok Awaiting requested review from aliok

1 more reviewer

@pierDipi pierDipi pierDipi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@skonto skonto

@pierDipi pierDipi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serverless-qe @openshift-ci-robot @skonto @pierDipi