Skip to content

Update openstack pull-secret to use attachement#4823

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
dprince:openstack_secrets
Aug 23, 2019
Merged

Update openstack pull-secret to use attachement#4823
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
dprince:openstack_secrets

Conversation

@dprince
Copy link
Contributor

@dprince dprince commented Aug 22, 2019

Similar to d2e72ba
OpenStack also needs this update.

As the merge_pull_secrets is no longer used it is dropped
as well.

Similar to d2e72ba
OpenStack also needs this update.

As the merge_pull_secrets is no longer used it is dropped
as well.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 22, 2019
@wking
Copy link
Member

wking commented Aug 22, 2019

c7389d3 looks good to me, although I don't actually understand how all this is wired together. Wish there was a way to rehearse the affected jobs...

Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stevekuznetsov
Copy link
Contributor

/approve

@droslean
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, droslean, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [droslean,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2019
@openshift-merge-robot openshift-merge-robot merged commit 974743e into openshift:master Aug 23, 2019
@hongkailiu
Copy link
Member

hongkailiu commented Aug 23, 2019

$ git log  -1 --oneline 
974743e0b (HEAD -> master, origin/master, origin/HEAD) Merge pull request #4823 from dprince/openstack_secrets

$ oc get secret -n ci cluster-secrets-openstack  -o yaml > ~/Downloads/cluster-secrets-openstack.yaml
$ export BW_SESSION="B..."

$ ./ci-operator/populate-secrets-from-bitwarden.sh
...
+ name=cluster-secrets-openstack
+ oc create secret generic cluster-secrets-openstack --from-file=pull-secret=/tmp/tmp.NF1Ko7huba/pull-secret --from-file=clouds.yaml=/tmp/tmp.NF1Ko7huba/clouds.yaml --from-file=insights-live.yaml=/tmp/tmp.NF1Ko7huba/insights-live.yaml --from-file=ssh-privatekey=/tmp/tmp.NF1Ko7huba/ssh-privatekey --from-file=ssh-publickey=/tmp/tmp.NF1Ko7huba/ssh-publickey --dry-run -o yaml
+ oc apply -f -
secret/cluster-secrets-openstack created
+ oc label secret --overwrite cluster-secrets-openstack ci.openshift.io/managed=true
secret/cluster-secrets-openstack labeled

$ bw logout
You have logged out.
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants