Add openstack beta repos mirror#4835
Conversation
In order to be able to properly test latest features of ironic and related services, we need to enable the beta openstack repos with the latest content available.
openshift-ci-robot
added
the
size/L
juliakreger
left a comment
juliakreger
left a comment
There was a problem hiding this comment.
LGTM, and aligns both image build processes. Thanks!
|
@smarterclayton Any chance we can get eyes on this? This merging would at least allow CI images to be testable fully with the correct versions matching downstream. |
Makefile
Outdated
| --from-file=cluster/test-deploy/gcp/ops-mirror.pem \ | ||
| --from-file=ci-operator/infra/openshift/release-controller/repos/ocp-4.2-openstack.repo \ | ||
| -o yaml --dry-run | oc apply -n ocp -f - | ||
| oc create secret generic openstack-beta-rhel8-4-2-repos \ |
There was a problem hiding this comment.
This is not consistent with our naming system. You would call this openstack-beta or openstack-next. We are trying to avoid endless variants with inscrutable names for the repos - your name should capture the reason the mirrors exist, not what content they contain. Are you trying to test these within 4.2 (which is now code freeze)? Are these going to be used by optional 4.2 or 4.3 jobs? Mixing "beta" and "4.2" doesn't really make sense for default jobs.
There was a problem hiding this comment.
I feel like the naming standard can be debated, after seeing some of the other repository configurations. Regardless, I agree openstack-beta makes the most sense. Riccardo went ahead and gave me access to edit his branch so I should be able to revise this without any issues.
Ultimately, the desire is to be able to build CI jobs and people do testing with the upstream CI images, at least as I understand it.
The side-effect of this is that no 4.2 images will ever be built with the correct RPMs as the the original configuration that was supplied in the upstream image build process pointed to the prior release's software. Performing as a separate change so the prior configuration can be recovered and reviewed as opposed to force-push overwrite.
openshift-ci-robot
added
size/M
|
@smarterclayton hi! Anything we could do to move forward with this ? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo, juliakreger, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
5 participants
In order to be able to properly test latest features of ironic
and related services, we need to enable the beta openstack
repos with the latest content available.