Skip to content

Use ubi 8 as base image for ironic #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 1, 2019
Merged

Use ubi 8 as base image for ironic #5090

openshift-merge-robot merged 1 commit into from
Oct 1, 2019

Conversation

@elfosardo
Copy link
Contributor

@elfosardo elfosardo commented Sep 19, 2019

This should install correct base python3 packages.
We might need to combine this with #4836 to have the correct
ironic packages installed.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2019
@elfosardo
Copy link
Contributor Author

elfosardo commented Sep 20, 2019

/retest

@elfosardo elfosardo force-pushed the base-to-ubi8 branch 2 times, most recently from d29829f to beaf07c Compare September 20, 2019 11:33
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2019
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 24, 2019
@elfosardo
Copy link
Contributor Author

elfosardo commented Sep 24, 2019

we need mooooaarrr repos #5161

@petr-muller
Copy link
Member

petr-muller commented Sep 24, 2019 •
edited
Loading

/retest

@elfosardo #5161 was merged and deployed

@elfosardo
Copy link
Contributor Author

elfosardo commented Sep 24, 2019

/retest

2 similar comments
@elfosardo
Copy link
Contributor Author

elfosardo commented Sep 24, 2019

/retest

@elfosardo
Copy link
Contributor Author

elfosardo commented Sep 24, 2019

/retest

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2019
@elfosardo
Copy link
Contributor Author

elfosardo commented Sep 27, 2019 •
edited
Loading

so apparently the path for the repos are wrong yet one more time
correction here: #5191

@elfosardo
Copy link
Contributor Author

elfosardo commented Sep 30, 2019

/retest

2 similar comments
@elfosardo
Copy link
Contributor Author

elfosardo commented Oct 1, 2019

/retest

@elfosardo
Copy link
Contributor Author

elfosardo commented Oct 1, 2019

/retest

@elfosardo
Use ubi 8 as base image for ironic
0cb774a 
This should install correct base python3 packages.
We might need to combine this with openshift#4836 to have the correct
ironic packages installed.
@elfosardo
Copy link
Contributor Author

elfosardo commented Oct 1, 2019

@russellb @hardys @juliakreger please review :)

@elfosardo elfosardo mentioned this pull request Oct 1, 2019
Closed
@russellb
Copy link
Contributor

russellb commented Oct 1, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, russellb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 56af4f9 into openshift:master Oct 1, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 1, 2019

@elfosardo: Updated the following 2 configmaps:

  • ci-operator-4.3-configs configmap in namespace ci using the following files:
    • key openshift-ironic-image-release-4.3.yaml using file ci-operator/config/openshift/ironic-image/openshift-ironic-image-release-4.3.yaml
  • ci-operator-4.3-configs configmap in namespace ci-stg using the following files:
    • key openshift-ironic-image-release-4.3.yaml using file ci-operator/config/openshift/ironic-image/openshift-ironic-image-release-4.3.yaml
Details

In response to this:

This should install correct base python3 packages.
We might need to combine this with #4836 to have the correct
ironic packages installed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hardys hardys Awaiting requested review from hardys

@russellb russellb Awaiting requested review from russellb

Assignees

@russellb russellb

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@elfosardo @petr-muller @russellb @openshift-ci-robot @openshift-merge-robot