Skip to content

Lint job for the velero project (konveyor-dev branch)#55969

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
mpryc:velero_lint_jobs
Sep 6, 2024
Merged

Lint job for the velero project (konveyor-dev branch)#55969
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
mpryc:velero_lint_jobs

Conversation

@mpryc
Copy link
Copy Markdown
Contributor

@mpryc mpryc commented Aug 27, 2024

  • adds lint job for the velero project (konveyor-dev branch)
  • adds run_if_changed for unit and lint jobs to trigger only for a relevant files.

@openshift-ci openshift-ci Bot requested review from hhpatel14 and weshayutin August 27, 2024 11:37
@mpryc mpryc mentioned this pull request Aug 27, 2024
Merged
@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 4, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@mpryc
Copy link
Copy Markdown
Contributor Author

mpryc commented Sep 4, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 4, 2024

@mpryc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
@mpryc mpryc mentioned this pull request Sep 5, 2024
Merged
@mpryc
Copy link
Copy Markdown
Contributor Author

mpryc commented Sep 5, 2024

Current lint is br8ken in velero project. To fix it this needs to be merged and backported to other branches openshift/velero#343

@mpryc
Copy link
Copy Markdown
Contributor Author

mpryc commented Sep 5, 2024

/pj-rehearse pull-ci-openshift-velero-konveyor-dev-lint

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 5, 2024

@mpryc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

weshayutin
weshayutin approved these changes Sep 5, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2024
@mpryc
Copy link
Copy Markdown
Contributor Author

mpryc commented Sep 5, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 5, 2024

@mpryc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 5, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 5, 2024

/retest-required

Remaining retests: 0 against base HEAD 4bacdfb and 2 for PR HEAD bb8d759 in total

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 5, 2024

/retest-required

Remaining retests: 0 against base HEAD 98fc3c4 and 1 for PR HEAD bb8d759 in total

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 5, 2024

/retest-required

Remaining retests: 0 against base HEAD 93e7eb1 and 0 for PR HEAD bb8d759 in total

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 6, 2024

/hold

Revision bb8d759 was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2024
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2024
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 6, 2024
@mpryc
Copy link
Copy Markdown
Contributor Author

mpryc commented Sep 6, 2024

Some internal prow issue where the cluster is selected randomly and it doesn't match what was generated with make jobs.

@mpryc
Copy link
Copy Markdown
Contributor Author

mpryc commented Sep 6, 2024

/retest

@mpryc
Lint job for the velero project (konveyor-dev branch)
dd6190e 
- adds lint job for the velero project (konveyor-dev branch)
- adds run_if_changed for unit and lint jobs to trigger only
  for a relevant files.

Signed-off-by: Michal Pryc <mpryc@redhat.com>
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 6, 2024

[REHEARSALNOTIFIER]
@mpryc: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-velero-konveyor-dev-images openshift/velero presubmit Presubmit changed
pull-ci-openshift-velero-konveyor-dev-lint openshift/velero presubmit Presubmit changed
pull-ci-openshift-velero-konveyor-dev-unit-test openshift/velero presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mpryc
Copy link
Copy Markdown
Contributor Author

mpryc commented Sep 6, 2024

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 6, 2024

@mpryc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mpryc
Copy link
Copy Markdown
Contributor Author

mpryc commented Sep 6, 2024

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 6, 2024

@mpryc: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 6, 2024
@mpryc
Copy link
Copy Markdown
Contributor Author

mpryc commented Sep 6, 2024

@weshayutin could you please re-approve? The config job was failing due to the issue in the ci-operator-config job which has nothing to do with this change. Now it's passing.

weshayutin
weshayutin approved these changes Sep 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpryc, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 73955f6 into openshift:master Sep 6, 2024
acornett21 pushed a commit to acornett21/openshift-release that referenced this pull request Sep 6, 2024
@mpryc @acornett21
Lint job for the velero project (konveyor-dev branch) (openshift#55969)
21855cc 
- adds lint job for the velero project (konveyor-dev branch)
- adds run_if_changed for unit and lint jobs to trigger only
  for a relevant files.

Signed-off-by: Michal Pryc <mpryc@redhat.com>
MiguelCarpio pushed a commit to MiguelCarpio/release that referenced this pull request Sep 12, 2024
@mpryc @MiguelCarpio
Lint job for the velero project (konveyor-dev branch) (openshift#55969)
b320189 
- adds lint job for the velero project (konveyor-dev branch)
- adds run_if_changed for unit and lint jobs to trigger only
  for a relevant files.

Signed-off-by: Michal Pryc <mpryc@redhat.com>
obochan-rh pushed a commit to obochan-rh/release that referenced this pull request Sep 24, 2024
@mpryc @obochan-rh
Lint job for the velero project (konveyor-dev branch) (openshift#55969)
f77418c 
- adds lint job for the velero project (konveyor-dev branch)
- adds run_if_changed for unit and lint jobs to trigger only
  for a relevant files.

Signed-off-by: Michal Pryc <mpryc@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hhpatel14 hhpatel14 Awaiting requested review from hhpatel14

2 more reviewers

@weshayutin weshayutin weshayutin approved these changes

@sseago sseago sseago approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@weshayutin weshayutin

@sseago sseago

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mpryc @openshift-ci-robot @weshayutin @sseago @openshift-merge-robot