Skip to content

HCP/OSP: introduce new NFV workflow + cleanup#58694

Merged
openshift-merge-bot[bot] merged 5 commits intoopenshift:masterfrom
shiftstack:hcp_osp_nfv
Jan 13, 2025
Merged

HCP/OSP: introduce new NFV workflow + cleanup#58694
openshift-merge-bot[bot] merged 5 commits intoopenshift:masterfrom
shiftstack:hcp_osp_nfv

Conversation

@EmilienM
Copy link
Copy Markdown
Member

@EmilienM EmilienM commented Nov 11, 2024 •
edited
Loading

HCP/OSP: Introduce new NFV workflow

This workflow allows testing Hypershift Nodepools running NFV workloads using PerformanceProfile, DPDK, and SR-IOV on the OpenStack platform.

Changes:

  • Load the nested_kubeconfig where we need it (to work on the HostedCluster and not on the management cluster).
  • Adds a new step registry to handle PerformanceProfile with Hypershift. This step is re-usable by any platform and lives in the Hypershift directory. The defaults are safe and proved to work on the OpenStack platform.
    The configuration has nothing specific to OpenStack which makes it re-usable.
  • Modified ci-operator/config/openshift-priv/hypershift/openshift-priv-hypershift-main.yaml
    • Removed HYPERSHIFT_ZONES as the default is good enough for our needs.
    • Changed the test workflow to hypershift-openstack-nfv
  • Modified ci-operator/config/openshift-priv/hypershift/openshift-priv-hypershift-release-4.18.yaml
    • Removed HYPERSHIFT_ZONES as the default is good enough for our needs.
    • Added RHCOS_IMAGE_NAME
    • Changed the test workflow to hypershift-openstack-nfv
  • Modified ci-operator/config/openshift-priv/hypershift/openshift-priv-hypershift-release-4.19.yaml
    • Removed HYPERSHIFT_ZONES as the default is good enough for our needs.
    • Changed the test workflow to hypershift-openstack-nfv

This update improves the testing of NFV workloads on the OpenStack platform by using the new workflow specific to Hypershift and OpenStack NFV.

Cleanups

  • Remove NFV specifics we did for 4.9 and 4.10.
  • Stop overriding HYPERSHIFT_ZONES, the default is good enough for us.

@openshift-ci openshift-ci Bot requested review from gryf and hector-vido November 11, 2024 19:33
@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Nov 11, 2024

/uncc gryf hector-vido

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Nov 11, 2024

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-openstack-nfv

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 11, 2024

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Nov 11, 2024

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-openstack-nfv

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 11, 2024

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Nov 12, 2024

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-openstack-nfv

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 12, 2024

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Nov 12, 2024

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-openstack-nfv

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 12, 2024

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Nov 12, 2024

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-openstack-nfv

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 12, 2024

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Nov 12, 2024

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-openstack-nfv

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 12, 2024

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Nov 13, 2024

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-openstack-nfv

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 13, 2024

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Nov 13, 2024

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-openstack-nfv

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 13, 2024

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Nov 13, 2024

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-openstack-nfv

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 13, 2024

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Nov 13, 2024

/pj-rehearse periodic-ci-shiftstack-ci-release-4.18-e2e-openstack-nfv-intel
for regression

@EmilienM EmilienM requested a review from mandre January 10, 2025 13:14
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 10, 2025
@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Jan 10, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 10, 2025

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 10, 2025
@hector-vido
Copy link
Copy Markdown
Contributor

hector-vido commented Jan 11, 2025

/retest

mandre
mandre reviewed Jan 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Jan 13, 2025

/retest

@EmilienM
dnsrecords: fix a typo
ce6f4c5
@EmilienM
HCP/OSP: introduce new NFV workflow
ebe9d36 
This workflow will allow to test Hypershift Nodepools running NFV
workloads using PerformanceProfile, DPDK and SR-IOV on OpenStack
platform.
@EmilienM
Remove HYPERSHIFT_ZONES where we don't it
156463f
@EmilienM
openstack/nfv: remove 4.9/4.10 specifics
37f9f0c
@EmilienM
make update + missing slack
8fc9933
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Jan 13, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 13, 2025

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 13, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 13, 2025

[REHEARSALNOTIFIER]
@EmilienM: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-master-e2e-openstack-ovn openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-master-e2e-openstack-serial openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.20-e2e-openstack-ovn openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.20-e2e-openstack-serial openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.19-e2e-openstack-ovn openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.19-e2e-openstack-serial openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.18-e2e-openstack-ovn openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.18-e2e-openstack-serial openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.17-e2e-openstack-ovn openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.17-e2e-openstack-serial openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-openstack-ovn openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-openstack-serial openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.15-e2e-openstack-ovn openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.15-e2e-openstack-serial openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.14-e2e-openstack-ovn openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.14-e2e-openstack-kuryr openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.14-e2e-openstack-serial openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.13-e2e-openstack-ovn openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.13-e2e-openstack-kuryr openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.13-e2e-openstack-serial openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.12-e2e-openstack-ovn openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.12-e2e-openstack-kuryr openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.12-e2e-openstack-serial openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.11-e2e-openstack openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.11-e2e-openstack-serial openshift/origin presubmit Registry content changed

A total of 1039 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mandre
Copy link
Copy Markdown
Member

mandre commented Jan 13, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, EmilienM, mandre, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Jan 13, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 13, 2025

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 13, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 13, 2025

@EmilienM: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 5118501 into openshift:master Jan 13, 2025
@openshift-merge-bot openshift-merge-bot Bot deleted the hcp_osp_nfv branch January 13, 2025 14:34
krishvoor pushed a commit to krishvoor/release that referenced this pull request Jan 29, 2025
@EmilienM @krishvoor
HCP/OSP: introduce new NFV workflow + cleanup (openshift#58694)
e6e8eae 
* dnsrecords: fix a typo

* HCP/OSP: introduce new NFV workflow

This workflow will allow to test Hypershift Nodepools running NFV
workloads using PerformanceProfile, DPDK and SR-IOV on OpenStack
platform.

* Remove HYPERSHIFT_ZONES where we don't it

* openstack/nfv: remove 4.9/4.10 specifics

* `make update` + missing slack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

@MiguelCarpio MiguelCarpio Awaiting requested review from MiguelCarpio

@stephenfin stephenfin Awaiting requested review from stephenfin

3 more reviewers

@mandre mandre mandre left review comments

@bryan-cox bryan-cox bryan-cox left review comments

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

@yuqi-zhang yuqi-zhang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@EmilienM @openshift-ci-robot @mandre @bryan-cox @hector-vido @stephenfin @yuqi-zhang