Skip to content

CAPO: add hypershift job#58844

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
shiftstack:capo-hcp
Nov 15, 2024
Merged

CAPO: add hypershift job#58844
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
shiftstack:capo-hcp

Conversation

@EmilienM
Copy link
Copy Markdown
Member

@EmilienM EmilienM commented Nov 14, 2024

Add a required job in downstream CAPO to test Hypershift on OpenStack.
CAPO is being used in Hypershift, so we want to test every change and
make sure there is no regression, especially when we rebase or merge
from upstream.

@openshift-ci openshift-ci Bot requested review from gryf and stephenfin November 14, 2024 16:12
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2024
@EmilienM
Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-e2e-hypershift-openstack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-e2e-hypershift

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Add a voting job in downstream CAPO to test Hypershift on OpenStack.
CAPO is being used in Hypershift, so we want to test every change and
make sure there is no regression, especially when we rebase or merge
from upstream.
@EmilienM
Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-e2e-hypershift

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Copy Markdown
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you say "voting job", do you mean we need it to be passing to merge code ("required" in prow terminology) ? Looks like the job is currently not configured that way, so we'll need change the code or clarify the commit message.

Anyway, let's see this job running first...

@EmilienM
Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-e2e-hypershift

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 15, 2024
@EmilienM EmilienM requested a review from mandre November 15, 2024 00:10
Copy link
Copy Markdown
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

But just to clarify, contrary to what the commit claims, this is not a voting job but an informational one that doesn't have the power to block code from merging.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit e0e921f into openshift:master Nov 15, 2024
@openshift-merge-bot openshift-merge-bot Bot deleted the capo-hcp branch November 15, 2024 10:24
obochan-rh pushed a commit to obochan-rh/release that referenced this pull request Nov 17, 2024
Add a voting job in downstream CAPO to test Hypershift on OpenStack.
CAPO is being used in Hypershift, so we want to test every change and
make sure there is no regression, especially when we rebase or merge
from upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants