CAPO: add hypershift job#58844
Conversation
|
/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-e2e-hypershift-openstack |
|
@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-e2e-hypershift |
|
@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Add a voting job in downstream CAPO to test Hypershift on OpenStack. CAPO is being used in Hypershift, so we want to test every change and make sure there is no regression, especially when we rebase or merge from upstream.
|
/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-e2e-hypershift |
|
@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
mandre
left a comment
There was a problem hiding this comment.
When you say "voting job", do you mean we need it to be passing to merge code ("required" in prow terminology) ? Looks like the job is currently not configured that way, so we'll need change the code or clarify the commit message.
Anyway, let's see this job running first...
|
/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-e2e-hypershift |
|
@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
mandre
left a comment
There was a problem hiding this comment.
/lgtm
But just to clarify, contrary to what the commit claims, this is not a voting job but an informational one that doesn't have the power to block code from merging.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add a voting job in downstream CAPO to test Hypershift on OpenStack. CAPO is being used in Hypershift, so we want to test every change and make sure there is no regression, especially when we rebase or merge from upstream.
Add a required job in downstream CAPO to test Hypershift on OpenStack.
CAPO is being used in Hypershift, so we want to test every change and
make sure there is no regression, especially when we rebase or merge
from upstream.