Skip to content

OSASINFRA-3678: hcp/osp: nested job#59599

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
shiftstack:sos_hcp
Jan 9, 2025
Merged

OSASINFRA-3678: hcp/osp: nested job#59599
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
shiftstack:sos_hcp

Conversation

@EmilienM
Copy link
Copy Markdown
Member

@EmilienM EmilienM commented Dec 6, 2024

This is a first iteration for having Hypershift deployed on a ShiftOnStack management cluster.

@EmilienM EmilienM changed the title hcp/osp: nested job OSASINFRA-3678: hcp/osp: nested job Dec 6, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 6, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 6, 2024

@EmilienM: This pull request references OSASINFRA-3678 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This is a first iteration for having Hypershift deployed on a
ShiftOnStack management cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from bertinatto and dobsonj December 6, 2024 01:06
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 6, 2024

@EmilienM: This pull request references OSASINFRA-3678 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This is a first iteration for having Hypershift deployed on a ShiftOnStack management cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Dec 6, 2024

/cc MaysaMacedo mandre

@openshift-ci openshift-ci Bot requested review from MaysaMacedo and mandre December 6, 2024 01:07
@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Dec 6, 2024

/hold
depends-on #59598

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2024
@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Dec 6, 2024

/pj-rehearse periodic-ci-shiftstack-ci-release-4.18-e2e-openstack-ovn-parallel periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-openstack-nested-conformance periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-openstack-aws
for regression testing & the new job as well

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

resource_type: openstack-vexxhost-quota-slice
workflow: hypershift-openstack-aws-conformance
- as: e2e-openstack-nested-conformance
minimum_interval: 240h
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now let's just use a periodic job that doesn't run that often because it's resource consuming. We can iterate on that later but I think it's fine for now.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'll run every 10 days for now, let me know if you think it's not frequent enough.

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Dec 6, 2024

/pj-rehearse periodic-ci-shiftstack-ci-release-4.18-e2e-openstack-ovn-parallel periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-openstack-nested-conformance periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-openstack-aws

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Dec 6, 2024

/pj-rehearse periodic-ci-shiftstack-ci-release-4.18-e2e-openstack-ovn-parallel periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-openstack-nested-conformance periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-openstack-aws

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Dec 6, 2024

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-openstack-nested-conformance

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@EmilienM, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: [workflow/hypershift-openstack-nested-conformance: parameter "LVM_CLUSTER_WIPE_DEVICE" is overridden in [workflow/hypershift-openstack-nested-conformance] but not declared in any step, workflow/hypershift-openstack-nested-conformance: parameter "LVM_CLUSTER_DEVICE_PATH" is overridden in [workflow/hypershift-openstack-nested-conformance] but not declared in any step]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@EmilienM, pj-rehearse: unable to determine affected jobs ERROR:

could not determine changed registry steps: could not load step registry: [workflow/hypershift-openstack-nested-conformance: parameter "LVM_CLUSTER_WIPE_DEVICE" is overridden in [workflow/hypershift-openstack-nested-conformance] but not declared in any step, workflow/hypershift-openstack-nested-conformance: parameter "LVM_CLUSTER_DEVICE_PATH" is overridden in [workflow/hypershift-openstack-nested-conformance] but not declared in any step]

If the problem persists, please contact Test Platform.

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Dec 6, 2024

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-openstack-nested-conformance

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2024
This is a first iteration for having Hypershift deployed on a
ShiftOnStack management cluster.
@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Dec 8, 2024

/pj-rehearse periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-openstack-nested-conformance

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@EmilienM: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kubernetes-master-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.20-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.19-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.18-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.17-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.16-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.15-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.14-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.13-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.12-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.11-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.10-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.9-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-master-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.20-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.19-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.18-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.17-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.16-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.15-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.14-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.13-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.12-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.11-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.10-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed

A total of 1016 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 8, 2024

@EmilienM: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@EmilienM
Copy link
Copy Markdown
Member Author

EmilienM commented Dec 9, 2024

@MaysaMacedo
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2024
Copy link
Copy Markdown
Contributor

@stephenfin stephenfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@EmilienM
Copy link
Copy Markdown
Member Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2024
@EmilienM
Copy link
Copy Markdown
Member Author

/pj-rehearse ack
the job passed well.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 11, 2024
@suleymanakbas91
Copy link
Copy Markdown
Contributor

/lgtm

@gnufied
Copy link
Copy Markdown
Member

gnufied commented Dec 12, 2024

/approve

@MaysaMacedo
Copy link
Copy Markdown
Contributor

/assign @bryan-cox

@bryan-cox
Copy link
Copy Markdown
Member

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, EmilienM, gnufied, MaysaMacedo, stephenfin, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 2a8d061 into openshift:master Jan 9, 2025
@openshift-merge-bot openshift-merge-bot Bot deleted the sos_hcp branch January 9, 2025 14:14
KPostOffice pushed a commit to KPostOffice/release that referenced this pull request Jan 10, 2025
* lvm-cluster: add param to wipe the device

* hcp/osp: nested job

This is a first iteration for having Hypershift deployed on a
ShiftOnStack management cluster.
krishvoor pushed a commit to krishvoor/release that referenced this pull request Jan 29, 2025
* lvm-cluster: add param to wipe the device

* hcp/osp: nested job

This is a first iteration for having Hypershift deployed on a
ShiftOnStack management cluster.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants