Skip to content

Revert "MCD RPM and os container builds for 4.2+ branches"#6216

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
kikisdeliveryservice:unbreak-my-hearrrt
Dec 3, 2019
Merged

Revert "MCD RPM and os container builds for 4.2+ branches"#6216
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
kikisdeliveryservice:unbreak-my-hearrrt

Conversation

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

@kikisdeliveryservice kikisdeliveryservice commented Dec 3, 2019

We believe that PR #5572 broke MCO CI.

This reverts commit 7a3ebbf.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 3, 2019
@kikisdeliveryservice
Copy link
Copy Markdown
Contributor Author

kikisdeliveryservice commented Dec 3, 2019

cc: @smarterclayton @yuqi-zhang @runcom

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@miabbott
Copy link
Copy Markdown
Member

miabbott commented Dec 3, 2019

cc: @LorbusChris @vrutkovs

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor Author

kikisdeliveryservice commented Dec 3, 2019

/assign @yuqi-zhang

yuqi-zhang
yuqi-zhang approved these changes Dec 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Double checked the revert since it wasn't exact, but the files look correct compared to their previous iterations

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LorbusChris
Copy link
Copy Markdown
Contributor

LorbusChris commented Dec 3, 2019

Not really sure what was wron with that.
Having only had a quick look, I don't think it's the RPM build jobs themselves that are responsible for breaking stuff here, but rather some injection/promotion going wrong (the RPM builds are needed and wanted anyway).
Instead of removing it all, we may just need something like #6181 for 4.2+ branches here to fix CI for now.

@openshift-merge-robot openshift-merge-robot merged commit 8378e12 into openshift:master Dec 3, 2019
@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Dec 3, 2019
Merged
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 3, 2019

@kikisdeliveryservice: Updated the following 13 configmaps:

  • ci-operator-4.2-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-machine-config-operator-release-4.2.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.2.yaml
  • ci-operator-4.2-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-machine-config-operator-release-4.2.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.2.yaml
  • ci-operator-4.3-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-machine-config-operator-release-4.3.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.3.yaml
  • ci-operator-4.3-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-machine-config-operator-release-4.3.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.3.yaml
  • ci-operator-4.4-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-machine-config-operator-release-4.4.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.4.yaml
  • job-config-master configmap in namespace ci at cluster default using the following files:
    • key openshift-machine-config-operator-master-postsubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-postsubmits.yaml
    • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • job-config-4.2 configmap in namespace ci at cluster default using the following files:
    • key openshift-machine-config-operator-release-4.2-postsubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.2-postsubmits.yaml
    • key openshift-machine-config-operator-release-4.2-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.2-presubmits.yaml
  • job-config-4.4 configmap in namespace ci at cluster default using the following files:
    • key openshift-machine-config-operator-release-4.4-postsubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.4-postsubmits.yaml
    • key openshift-machine-config-operator-release-4.4-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.4-presubmits.yaml
  • job-config-4.3 configmap in namespace ci at cluster default using the following files:
    • key openshift-machine-config-operator-release-4.3-postsubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.3-postsubmits.yaml
    • key openshift-machine-config-operator-release-4.3-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.3-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-4.4-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-machine-config-operator-release-4.4.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.4.yaml
Details

In response to this:

We believe that PR #5572 broke MCO CI.

This reverts commit 7a3ebbf.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuqi-zhang
Copy link
Copy Markdown
Contributor

yuqi-zhang commented Dec 3, 2019

Hm I may have jumped the gun then. Let's see if this will fix CI and then add back in necessary build jobs

@LorbusChris
Copy link
Copy Markdown
Contributor

LorbusChris commented Dec 3, 2019

thanks @yuqi-zhang

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor Author

kikisdeliveryservice commented Dec 3, 2019

We should keep the reversion and MCO release jobs should never be commited without MCO team approving. We wasted a lot of time bc we were unaware of this PR.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 4, 2019

@kikisdeliveryservice: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/machine-config-operator/release-4.3/e2e-gcp-upgrade 6d8f49e link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.4/e2e-gcp-upgrade 6d8f49e link /test pj-rehearse
ci/prow/pj-rehearse 6d8f49e link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice kikisdeliveryservice deleted the unbreak-my-hearrrt branch February 21, 2020 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

1 more reviewer

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yuqi-zhang yuqi-zhang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kikisdeliveryservice @miabbott @openshift-ci-robot @LorbusChris @yuqi-zhang @openshift-merge-robot