exit with 0 even if kill failed #6295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
This was referenced Dec 9, 2019
Contributor
There was a problem hiding this comment.
This looks correct, can you change all the others as well (i.e. every usage of this in this repo)
Contributor
Author
There was a problem hiding this comment.
@smarterclayton updated, there were two kinds of changes:
-jobs -p | xargs -r kill
+jobs -p | xargs -r kill || true-jobs -p | xargs kill || true
+jobs -p | xargs -r kill || true
Contributor
There was a problem hiding this comment.
Hrm, I thought I got all the former. Must have forked after my change.
Contributor
|
Looks correct, please apply to all others |
openshift-ci-robot
added
size/L
dmage
changed the title
Contributor
stevekuznetsov
left a comment
stevekuznetsov
left a comment
There was a problem hiding this comment.
From an outside observer this is where the complexity starts to ramp up into unsustainable territory.
Contributor
|
Except it doesn't ramp up. We fix it, it goes away, we don't worry about it. |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest ci/rehearse/openshift/cloud-credential-operator/master/e2e-gcp |
Contributor
Author
|
/retest |
Contributor
Author
|
https://prow.svc.ci.openshift.org/pr-history/?org=openshift&repo=release&pr=6295 |
Contributor
|
This is the third PR for this bash in recent memory... that sounds like ramping up to me :) |
Contributor
Author
|
/retest |
Contributor
Author
|
@smarterclayton @stevekuznetsov can we merge it? |
Contributor
Author
|
/retest |
Contributor
|
/lgtm Thanks |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
@dmage: Updated the following 39 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
@dmage: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wking
added a commit
to wking/ci-tools
that referenced
this pull request
Dec 20, 2019
Bringing over a number of changes which have landed in ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml as of openshift/release@016eb4ed27 (Merge pull request openshift/release#6505 from hongkailiu/clusterReaders, 2019-12-19). One series was improved kill logic: * openshift/release@9cd158adf3 (template: Use a more correct kill command, 2019-12-03, openshift/release#6223). * openshift/release@d0744e520d (exit with 0 even if kill failed, 2019-12-09, openshift/release#6295) Another series was around AWS instance console logs: * openshift/release@e102a16d89 (ci-operator/templates/openshift/installer/cluster-launch-installer-e2e: Gather node console logs on AWS, 2019-12-02, openshift/release#6189). * openshift/release@26fde70045 (ci-operator/templates/openshift/installer/cluster-launch-installer-e2e: Set AWS_DEFAULT_REGION, 2019-12-04, openshift/release#6249). And there was also: * openshift/release@cdf97164aa (templates: Add large and xlarge variants, 2019-11-25, openshift/release#6081). * openshift/release@8cbef5e4a7 (ci-operator/templates/openshift/installer/cluster-launch-installer-e2e: Error-catching for Google OAuth pokes, 2019-12-02, openshift/release#6190). * openshift/release@ad29eda8dd (template: Gather the prometheus target metadata during teardown, 2019-12-12, openshift/release#6379).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_image-registry/208/pull-ci-openshift-image-registry-release-3.11-integration/42
xargs returns
123 if any invocation of the command exited with status 1-125. In this case, kill failed. As we use-e, at that moment the entire script stops with the exit code 123./assign @smarterclayton
@smarterclayton you've touched this recently, is it ok to just ignore this error?