Skip to content

Populate template CMs to build01 #6335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 11, 2019
Merged

Populate template CMs to build01 #6335

openshift-merge-robot merged 1 commit into from
Dec 11, 2019

Conversation

@hongkailiu
Copy link
Member

@hongkailiu hongkailiu commented Dec 11, 2019

#6331 (comment)

/cc @openshift/openshift-team-developer-productivity-test-platform

@openshift-ci-robot openshift-ci-robot requested a review from a team December 11, 2019 03:13
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 11, 2019
stevekuznetsov
stevekuznetsov reviewed Dec 11, 2019
View reviewed changes
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't we need every single template on build01?

@hongkailiu
Copy link
Member Author

hongkailiu commented Dec 11, 2019 •
edited
Loading

Won't we need every single template on build01?

Because I do not know which are need, which are not. So only add when pod complains about it.

Adding all in.

Done.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2019
@hongkailiu hongkailiu changed the title Populate CM cluster-profile-gcp to build01 Populate template CMs to build01 Dec 11, 2019
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f1bb05b into openshift:master Dec 11, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2019

@hongkailiu: Updated the plugins configmap in namespace ci at cluster default using the following files:

  • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml
Details

In response to this:

#6331 (comment)

/cc @openshift/openshift-team-developer-productivity-test-platform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stevekuznetsov stevekuznetsov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hongkailiu @openshift-ci-robot @stevekuznetsov @openshift-merge-robot