Skip to content

Conversation

@hongkailiu
Copy link
Member

@hongkailiu hongkailiu commented Dec 11, 2019

Fixing #6331

https://coreos.slack.com/archives/GB7NB0CUC/p1576086394491000?thread_ts=1576009509.458800&cid=GB7NB0CUC

/cc @openshift/openshift-team-developer-productivity-test-platform

/hold

@openshift-ci-robot openshift-ci-robot requested a review from a team December 11, 2019 20:33
@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 11, 2019
@stevekuznetsov
Copy link
Contributor

We should think about how we want to ensure that there is never any drift. Maybe add a presubmit that runs diff on these two dirs and ensures they are identical

@hongkailiu hongkailiu force-pushed the fixYumSVC branch 11 times, most recently from b738988 to 3848eae Compare December 12, 2019 02:27
@hongkailiu
Copy link
Member Author

We should think about how we want to ensure that there is never any drift. Maybe add a presubmit that runs diff on these two dirs and ensures they are identical

Done.

Rehearsal passed.
https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_release/6354/rehearse-6354-pull-ci-openshift-release-master-build-farm-consistency/9

$ oc logs  -n ci-op-rr2w1g31 build-farm-consistency
copying ns-ttl-controller assets ...
cp -fv ./core-services/ci-ns-ttl-controller/ci-ns-ttl-controller_dc.yaml ./clusters/build-clusters/01_cluster/openshift/ci-ns-ttl-controller/ci-ns-ttl-controller_dc.yaml
'./core-services/ci-ns-ttl-controller/ci-ns-ttl-controller_dc.yaml' -> './clusters/build-clusters/01_cluster/openshift/ci-ns-ttl-controller/ci-ns-ttl-controller_dc.yaml'
copying rpms-ocp assets ...
#ensure the source is there
find ./core-services/release-controller/ -name "rpms-ocp-*.yaml" | egrep '.*'
./core-services/release-controller/rpms-ocp-4.1.yaml
./core-services/release-controller/rpms-ocp-4.2.yaml
./core-services/release-controller/rpms-ocp-4.3.yaml
./core-services/release-controller/rpms-ocp-4.4.yaml
./core-services/release-controller/rpms-ocp-4.5.yaml
find ./core-services/release-controller/ -name "rpms-ocp-*.yaml" -exec cp -v {} ./clusters/build-clusters/01_cluster/openshift/release-controller/ \;
'./core-services/release-controller/rpms-ocp-4.1.yaml' -> './clusters/build-clusters/01_cluster/openshift/release-controller/rpms-ocp-4.1.yaml'
'./core-services/release-controller/rpms-ocp-4.2.yaml' -> './clusters/build-clusters/01_cluster/openshift/release-controller/rpms-ocp-4.2.yaml'
'./core-services/release-controller/rpms-ocp-4.3.yaml' -> './clusters/build-clusters/01_cluster/openshift/release-controller/rpms-ocp-4.3.yaml'
'./core-services/release-controller/rpms-ocp-4.4.yaml' -> './clusters/build-clusters/01_cluster/openshift/release-controller/rpms-ocp-4.4.yaml'
'./core-services/release-controller/rpms-ocp-4.5.yaml' -> './clusters/build-clusters/01_cluster/openshift/release-controller/rpms-ocp-4.5.yaml'
git status -s ./clusters/build-clusters/
test -z "$(git status -s ./clusters/build-clusters/)"

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2019
@petr-muller
Copy link
Member

/retest

@hongkailiu hongkailiu force-pushed the fixYumSVC branch 9 times, most recently from fb25cb9 to 6ad6157 Compare December 12, 2019 14:41
@hongkailiu
Copy link
Member Author

@hongkailiu
Copy link
Member Author

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [hongkailiu,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b67b8b5 into openshift:master Dec 12, 2019
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: Updated the job-config-master configmap in namespace ci at cluster default using the following files:

  • key openshift-release-master-presubmits.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-presubmits.yaml
Details

In response to this:

Fixing #6331

https://coreos.slack.com/archives/GB7NB0CUC/p1576086394491000?thread_ts=1576009509.458800&cid=GB7NB0CUC

/cc @openshift/openshift-team-developer-productivity-test-platform

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hongkailiu
Copy link
Member Author

Looks good

$ oc --kubeconfig build01.config get pod -n ocp 
NAME                                  READY   STATUS    RESTARTS   AGE
base-4-1-5cb66cf88d-dndxc             1/1     Running   0          64s
base-4-1-5cb66cf88d-nlhsm             1/1     Running   0          73s
base-4-2-9578bb4ff-nbcgl              1/1     Running   0          73s
base-4-2-9578bb4ff-pq6xh              1/1     Running   0          64s
base-4-2-s390x-5dbcf7f487-4g4nh       1/1     Running   0          63s
base-4-2-s390x-5dbcf7f487-dz2vb       1/1     Running   0          72s
base-4-3-587854b594-mmhr2             1/1     Running   0          23h
base-4-3-587854b594-vpjnv             1/1     Running   0          23h
base-4-3-ppc64le-787b858477-6l8qj     1/1     Running   0          23h
base-4-3-ppc64le-787b858477-s2vq6     1/1     Running   0          23h
base-4-3-rhel8-9f56c79c8-kqtt7        1/1     Running   0          23h
base-4-3-rhel8-9f56c79c8-x82cz        1/1     Running   0          23h
base-4-3-s390x-6c685bfbf4-dvmxn       1/1     Running   0          23h
base-4-3-s390x-6c685bfbf4-rdbbb       1/1     Running   0          23h
base-4-4-9b5485fb5-dmbfk              1/1     Running   0          5h27m
base-4-4-9b5485fb5-t66cs              1/1     Running   0          5h27m
base-4-4-ppc64le-6f6c747fbb-8xn4k     1/1     Running   0          5h27m
base-4-4-ppc64le-6f6c747fbb-x62xx     1/1     Running   0          5h27m
base-4-4-rhel8-68cdb6cd9c-5lpbx       1/1     Running   0          5h27m
base-4-4-rhel8-68cdb6cd9c-5mvkc       1/1     Running   0          5h27m
base-4-4-s390x-58978f7697-drwjf       1/1     Running   0          5h27m
base-4-4-s390x-58978f7697-jf4nq       1/1     Running   0          5h27m
base-4-5-6ff547d64-5g7kg              1/1     Running   0          61s
base-4-5-6ff547d64-z2dtb              1/1     Running   0          69s
base-4-5-ppc64le-67858b9667-28ttz     1/1     Running   0          69s
base-4-5-ppc64le-67858b9667-f9lg4     1/1     Running   0          60s
base-4-5-rhel8-6b6b5ddd4d-5hprr       1/1     Running   0          60s
base-4-5-rhel8-6b6b5ddd4d-9fbxm       1/1     Running   0          69s
base-4-5-s390x-869fd8f7b8-qbmj9       1/1     Running   0          60s
base-4-5-s390x-869fd8f7b8-vshr2       1/1     Running   0          69s
base-openstack-4-2-66fbd758b4-4gj2g   1/1     Running   0          63s
base-openstack-4-2-66fbd758b4-lxvdt   1/1     Running   0          73s
base-openstack-4-3-777894bbf7-bv9m2   1/1     Running   0          23h
base-openstack-4-3-777894bbf7-vghdn   1/1     Running   0          23h
base-openstack-4-4-6d7d68bcdb-8dd9l   1/1     Running   0          5h27m
base-openstack-4-4-6d7d68bcdb-q2zbv   1/1     Running   0          5h27m
base-openstack-4-5-5c9d55c567-2t5s8   1/1     Running   0          60s
base-openstack-4-5-5c9d55c567-ksfmp   1/1     Running   0          69s
openstack-beta-4-3-5c74dbdf6-mwwlg    1/1     Running   0          23h
openstack-beta-4-3-5c74dbdf6-vkwh2    1/1     Running   0          23h
openstack-beta-4-4-b98d64fbf-69zn4    1/1     Running   0          5h27m
openstack-beta-4-4-b98d64fbf-sc6bc    1/1     Running   0          5h27m
openstack-beta-4-5-55fb5cbf8b-48jf5   1/1     Running   0          60s
openstack-beta-4-5-55fb5cbf8b-x8t6c   1/1     Running   0          69s

@hongkailiu hongkailiu deleted the fixYumSVC branch June 12, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants