base-ci-images: Add {ocp,origin}/builder:golang-1.13#6428
base-ci-images: Add {ocp,origin}/builder:golang-1.13#6428openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
|
We might not need this at all - this failed a CI test over in the Installer Go Module PR for me because the image reference to the ocp/builder images were not replaced, because image replacement in installer is misconfigured: Here it says input as build (https://github.com/openshift/release/blob/master/ci-operator/config/openshift/installer/openshift-installer-master.yaml#L17) but in the corresponding Dockerfile it is AS builder (https://github.com/openshift/installer/blob/master/images/installer/Dockerfile.ci#L4) This begs the question of where these images should be used from the internal registry, and where they should be replaced references to (the same image) from the docker registry. I think we'll definitely have to fix the Installer replacement refs. If this indeed a misconfiguration, they're wrong on all branches. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LorbusChris, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Needed for the Go 1.13 switch