Skip to content

base-ci-images: Add {ocp,origin}/builder:golang-1.13#6428

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
LorbusChris:builder-1.13
Dec 17, 2019
Merged

base-ci-images: Add {ocp,origin}/builder:golang-1.13#6428
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
LorbusChris:builder-1.13

Conversation

@LorbusChris
Copy link
Copy Markdown
Contributor

Needed for the Go 1.13 switch

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 16, 2019
@LorbusChris
Copy link
Copy Markdown
Contributor Author

We might not need this at all - this failed a CI test over in the Installer Go Module PR for me because the image reference to the ocp/builder images were not replaced, because image replacement in installer is misconfigured:

Here it says input as build (https://github.com/openshift/release/blob/master/ci-operator/config/openshift/installer/openshift-installer-master.yaml#L17) but in the corresponding Dockerfile it is AS builder (https://github.com/openshift/installer/blob/master/images/installer/Dockerfile.ci#L4)

This begs the question of where these images should be used from the internal registry, and where they should be replaced references to (the same image) from the docker registry.

I think we'll definitely have to fix the Installer replacement refs. If this indeed a misconfiguration, they're wrong on all branches.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2019
@abhinavdahiya
Copy link
Copy Markdown
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit 03e1182 into openshift:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants