Adding ipi support to cluster-launch-installer-e2e.yaml#6631
Adding ipi support to cluster-launch-installer-e2e.yaml#6631derekhiggins wants to merge 9 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: derekhiggins The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test pj-rehearse |
derekhiggins
force-pushed
the
ipi-e2e-job
branch
6 times, most recently
from
3a316f9 to
15b4a8d
Compare
|
/uncc @jstuever |
derekhiggins
force-pushed
the
ipi-e2e-job
branch
from
776a4a4 to
21f40d9
Compare
|
/test pj-rehearse |
1 similar comment
|
/test pj-rehearse |
Updating cluster-launch-installer-e2e template to for jobs that test Bare Metal provided Installer Provisioned Infrastructure. Use packet.net to spin up a single baremetal server and test the ipi installer on it.
dev-scripts can go a long time without outputing anything, add a keepalive to prevent ssh timeing out
Also added run-remote-smoke-tests
andfasano
force-pushed
the
ipi-e2e-job
branch
from
5767320 to
dd3c4f9
Compare
|
/test pj-rehearse |
1 similar comment
|
/test pj-rehearse |
|
/assign @crawford |
|
/cc |
| ci-operator.openshift.io/wait-for-container-artifacts: teardown | ||
| ci-operator.openshift.io/save-container-logs: "true" | ||
| ci-operator.openshift.io/container-sub-tests: "setup,test,teardown" | ||
| ci-operator.openshift.io/container-sub-tests: "setup,test,teardown,setup-packet" |
There was a problem hiding this comment.
This template is shared by all IPI jobs. Does this addition have an effect on IPI jobs that don't run packet?
There was a problem hiding this comment.
It shouldn't have since it execution is guarded by a condition on the CLUSTER_TYPE (see https://github.com/derekhiggins/release/blob/44d62d646ac884ec448f9e0b36f216800af2fd53/ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml#L1002) - same approach used on the other containers
There was a problem hiding this comment.
This annotation determines which tests are returned as JUnit tests so setup-packet would be displayed as a test on every test, even those not using Packet.
|
|
||
| # The setup-packet and test containers need libnns_wrapper to use ssh | ||
| # TODO(derekh): investigate if it can be added to that container images | ||
| - name: nss-wrapper-hack |
There was a problem hiding this comment.
Am I right to think we would be running this pod on every e2e install, whether it is needed or not?
There was a problem hiding this comment.
Yes, it copies a bunch of files to a shared folder since they are needed by the setup-packet container
| cp /bin/mock-nss.sh /usr/lib64/libnss_wrapper.so /tmp/shared/ | ||
| # We need to have a seperate setup container for packet.net servers | ||
| # as we need an image with terrafrom | ||
| - name: setup-packet |
There was a problem hiding this comment.
Same as above: Am I right to think we would be running this pod on every e2e install, whether it is needed or not?
There was a problem hiding this comment.
See previous comment on CLUSTER_TYPE guard
There was a problem hiding this comment.
yeah so it would run and return 0 so the setup-packet junit test I mentioned above would pass on non-packet e2e-tests. makes sense.
andfasano
left a comment
andfasano
left a comment
There was a problem hiding this comment.
I only took a brief look at this, but it seems like this would add pods to run on every e2e job, whether they need packet or not.
This seems like it needs a separate template, can you clarify?
In a previously opened PR I think that @smarterclayton suggested to include it in the current template, as originally was separate (see #5016 (comment)).
To me, adding new pods would call for creating a new template. I could see this as a template that VSphere might also need. I know there are maintenance issues with creating new templates, but I also don't want to create unnecessary dependencies. @wking I know you have informed opinions on templates, can you take a quick look? I don't feel comfortable on making that call without more informed opinions but will review the rest of the PR independent of that. |
|
after bugging the test team it looks like we should be using this: https://steps.svc.ci.openshift.org/ I will look into this. |
|
Addressed here #7727 |
|
@derekhiggins: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
9 participants
Updating cluster-launch-installer-e2e template to for
jobs that test Bare Metal provided Installer Provisioned
Infrastructure. Use packet.net to spin up a single baremetal
server and test the ipi installer on it.
Continuation of #5016 (can't seem to reopen it)