Skip to content

don't branch for rhel-coreos-config repo#67305

Merged
openshift-merge-bot[bot] merged 3 commits into
openshift:masterfrom
dustymabe:dusty-rhel-coreos-config
Jul 21, 2025
Merged

don't branch for rhel-coreos-config repo#67305
openshift-merge-bot[bot] merged 3 commits into
openshift:masterfrom
dustymabe:dusty-rhel-coreos-config

Conversation

@dustymabe
Copy link
Copy Markdown
Member

@dustymabe dustymabe commented Jul 21, 2025

  • also clean up 4.20/4.21 related config for rhel-coreos-config
  • also add testing for rhel10

Cleanup associated files that are for 4.20 and 4.21 in the config
for rhel-coreos-config. The rhel-coreos-config repo doesn't branch
for OpenShift releases.
@dustymabe dustymabe changed the title Dusty rhel coreos config don't branch for rhel-coreos-config repo Jul 21, 2025
@openshift-ci openshift-ci Bot requested review from HuijingHei and prestist July 21, 2025 16:36
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2025
@dustymabe dustymabe force-pushed the dusty-rhel-coreos-config branch from e41a326 to e8a53e7 Compare July 21, 2025 16:59
Copy link
Copy Markdown
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thanks!

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@dustymabe: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-coreos-rhel-coreos-config-main-images coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-main-rhcos-10-build-test-metal coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-main-rhcos-10-build-test-qemu coreos/rhel-coreos-config presubmit Presubmit changed
pull-ci-coreos-rhel-coreos-config-main-rhcos-9-build-test-metal coreos/rhel-coreos-config presubmit Ci-operator config changed
pull-ci-coreos-rhel-coreos-config-main-rhcos-9-build-test-qemu coreos/rhel-coreos-config presubmit Ci-operator config changed
pull-ci-coreos-rhel-coreos-config-main-rhcos-9next-build-test-metal coreos/rhel-coreos-config presubmit Ci-operator config changed
pull-ci-coreos-rhel-coreos-config-main-rhcos-9next-build-test-qemu coreos/rhel-coreos-config presubmit Ci-operator config changed
pull-ci-coreos-rhel-coreos-config-main-scos-10-build-test-metal coreos/rhel-coreos-config presubmit Ci-operator config changed
pull-ci-coreos-rhel-coreos-config-main-scos-10-build-test-qemu coreos/rhel-coreos-config presubmit Ci-operator config changed
pull-ci-coreos-rhel-coreos-config-main-scos-9-build-test-metal coreos/rhel-coreos-config presubmit Ci-operator config changed
pull-ci-coreos-rhel-coreos-config-main-scos-9-build-test-qemu coreos/rhel-coreos-config presubmit Ci-operator config changed
pull-ci-coreos-rhel-coreos-config-main-validate coreos/rhel-coreos-config presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 21, 2025

@dustymabe: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@deepsm007
Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@deepsm007: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 21, 2025
@dustymabe
Copy link
Copy Markdown
Member Author

Looks like everything passed. When I click through tide it says:

Only merges with author openshift-bot are currently allowed

@dustymabe
Copy link
Copy Markdown
Member Author

Now it says in merge pool so I think we;re good

@openshift-merge-bot openshift-merge-bot Bot merged commit 4c21d8e into openshift:master Jul 21, 2025
16 checks passed
joelcapitao added a commit to joelcapitao/rhel-coreos-config that referenced this pull request Jul 23, 2025
We need to pull the rhel10 repos since we added the PROW tests
`rhcos-10-build-test-[metal|qemu]` with [1].
Also, since we removed the Y stream from repo definitions in [2], we
have to remove them also in our manifest.

Finally, we can also enable rhel-10-early-kernel repo and pull
ose-aws-ecr-image-credential-provider RPM.

[1] openshift/release#67305
[2] openshift/release#63561
joelcapitao added a commit to joelcapitao/rhel-coreos-config that referenced this pull request Jul 23, 2025
We need to pull the rhel10 repos since we added the PROW tests
`rhcos-10-build-test-[metal|qemu]` with [1].
Also, since we removed the Y stream from repo definitions in [2], we
have to remove them also in our manifest.

Finally, we can also enable rhel-10-early-kernel repo and pull
ose-aws-ecr-image-credential-provider RPM.

[1] openshift/release#67305
[2] openshift/release#63561
joelcapitao added a commit to joelcapitao/rhel-coreos-config that referenced this pull request Jul 23, 2025
We need to pull the rhel10 repos since we added the PROW tests
`rhcos-10-build-test-[metal|qemu]` with [1].
Also, since we removed the Y stream from repo definitions in [2], we
have to remove them also in our manifest.

Finally, we can also enable rhel-10-early-kernel repo and pull
ose-aws-ecr-image-credential-provider RPM.

[1] openshift/release#67305
[2] openshift/release#63561
joelcapitao added a commit to joelcapitao/rhel-coreos-config that referenced this pull request Jul 25, 2025
We need to pull the rhel10 repos since we added the PROW tests
`rhcos-10-build-test-[metal|qemu]` with [1].
Also, since we removed the Y stream from repo definitions in [2], we
have to remove them also in our manifest.

Finally, we can also enable rhel-10-early-kernel repo and pull
ose-aws-ecr-image-credential-provider RPM.

[1] openshift/release#67305
[2] openshift/release#63561
joelcapitao added a commit to joelcapitao/rhel-coreos-config that referenced this pull request Jul 25, 2025
We need to pull the rhel10 repos since we added the PROW tests
`rhcos-10-build-test-[metal|qemu]` with [1].
Also, since we removed the Y stream from repo definitions in [2], we
have to remove them also in our manifest.

Finally, we can also enable rhel-10-early-kernel repo and pull
ose-aws-ecr-image-credential-provider RPM.

[1] openshift/release#67305
[2] openshift/release#63561
joelcapitao added a commit to joelcapitao/rhel-coreos-config that referenced this pull request Jul 25, 2025
We need to pull the rhel10 repos since we added the PROW tests
`rhcos-10-build-test-[metal|qemu]` with [1].
Also, since we removed the Y stream from repo definitions in [2], we
have to remove them also in our manifest.

Finally, we can also enable rhel-10-early-kernel repo and pull
ose-aws-ecr-image-credential-provider RPM.

[1] openshift/release#67305
[2] openshift/release#63561
joelcapitao added a commit to joelcapitao/rhel-coreos-config that referenced this pull request Jul 28, 2025
We need to pull the rhel10 repos since we added the PROW tests
`rhcos-10-build-test-[metal|qemu]` with [1].
Also, since we removed the Y stream from repo definitions in [2], we
have to remove them also in our manifest.

Finally, we can also enable rhel-10-early-kernel repo and pull
ose-aws-ecr-image-credential-provider RPM.

[1] openshift/release#67305
[2] openshift/release#63561
joelcapitao added a commit to joelcapitao/rhel-coreos-config that referenced this pull request Jul 28, 2025
We need to pull the rhel10 repos since we added the PROW tests
`rhcos-10-build-test-[metal|qemu]` with [1].
Also, since we removed the Y stream from repo definitions in [2], we
have to remove them also in our manifest.

Finally, we can also enable rhel-10-early-kernel repo and pull
ose-aws-ecr-image-credential-provider RPM.

[1] openshift/release#67305
[2] openshift/release#63561
joelcapitao added a commit to joelcapitao/rhel-coreos-config that referenced this pull request Jul 30, 2025
We need to pull the rhel10 repos since we added the PROW tests
`rhcos-10-build-test-[metal|qemu]` with [1].
Also, since we removed the Y stream from repo definitions in [2], we
have to remove them also in our manifest.

Finally, we can also enable rhel-10-early-kernel repo and pull
ose-aws-ecr-image-credential-provider RPM.

[1] openshift/release#67305
[2] openshift/release#63561
MrSanketkumar pushed a commit to MrSanketkumar/release that referenced this pull request Aug 1, 2025
* Delete 4.20/4.21 related files for the rhel-coroes-config repo

Cleanup associated files that are for 4.20 and 4.21 in the config
for rhel-coreos-config. The rhel-coreos-config repo doesn't branch
for OpenShift releases.

* config: don't do branching in rhel-coreos-config repo

That repo follows RHEL and doesn't need to be branched for OpenShift releases.

We think this change will cause branching to not happen based on
https://docs.ci.openshift.org/docs/architecture/branching/#how-do-i-opt-my-repository-into-automated-branching

* config: add rhcos-10 testing for rhel-coreos-config
liweinan pushed a commit to liweinan/release that referenced this pull request Aug 5, 2025
* Delete 4.20/4.21 related files for the rhel-coroes-config repo

Cleanup associated files that are for 4.20 and 4.21 in the config
for rhel-coreos-config. The rhel-coreos-config repo doesn't branch
for OpenShift releases.

* config: don't do branching in rhel-coreos-config repo

That repo follows RHEL and doesn't need to be branched for OpenShift releases.

We think this change will cause branching to not happen based on
https://docs.ci.openshift.org/docs/architecture/branching/#how-do-i-opt-my-repository-into-automated-branching

* config: add rhcos-10 testing for rhel-coreos-config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants