Skip to content

add hypershift-oadp as optional in oadp-1.4#68289

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
weshayutin:hcpoadp14
Sep 3, 2025
Merged

add hypershift-oadp as optional in oadp-1.4#68289
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
weshayutin:hcpoadp14

Conversation

@weshayutin
Copy link
Copy Markdown
Contributor

@weshayutin weshayutin commented Aug 19, 2025

No description provided.

@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented Aug 19, 2025

@kaovilai might be handy as we get ci up

kaovilai
kaovilai approved these changes Aug 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have CI files yet but when we do can let this go in. otherwise it just run the whole e2e suite.

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 19, 2025
@weshayutin weshayutin mentioned this pull request Aug 29, 2025
Merged
@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented Sep 2, 2025

/pj-rehearse pull-ci-openshift-oadp-operator-oadp-1.4-4.18-e2e-test-hcp-aws

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 2, 2025

@weshayutin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@kaovilai
Copy link
Copy Markdown
Member

kaovilai commented Sep 2, 2025

/pj-rehearse pull-ci-openshift-oadp-operator-oadp-1.4-4.18-e2e-test-hcp-aws

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 2, 2025

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented Sep 3, 2025

/pj-rehearse pull-ci-openshift-oadp-operator-oadp-1.4-4.18-e2e-test-hcp-aws

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 3, 2025

@weshayutin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented Sep 3, 2025

@jparrill HCP on 4.18 should install right?

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2025
@kaovilai
Copy link
Copy Markdown
Member

kaovilai commented Sep 3, 2025

/pj-rehearse pull-ci-openshift-oadp-operator-oadp-1.4-4.18-e2e-test-hcp-aws

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 3, 2025

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 3, 2025

[REHEARSALNOTIFIER]
@weshayutin: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-oadp-operator-oadp-1.4-4.18-e2e-test-hcp-aws openshift/oadp-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jparrill
Copy link
Copy Markdown
Contributor

jparrill commented Sep 3, 2025

@jparrill HCP on 4.18 should install right?

Yes, it should.

@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented Sep 3, 2025

@jparrill HCP on 4.18 should install right?

Yes, it should.

thanks.. this was my stupid error. This one should work, not jinxing it lolz

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 3, 2025

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented Sep 3, 2025

/lgtm /rehersals-ack

@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented Sep 3, 2025

/rehearsals-ack

kaovilai
kaovilai approved these changes Sep 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2025
@kaovilai
Copy link
Copy Markdown
Member

kaovilai commented Sep 3, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 3, 2025

@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 3, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 4af82ff into openshift:master Sep 3, 2025
16 checks passed
xiaojiey pushed a commit to xiaojiey/release that referenced this pull request Sep 25, 2025
@weshayutin @xiaojiey
add hypershift-oadp as optional in oadp-1.4 (openshift#68289)
42ad042 
* add hypershift-oadp as optional in oadp-1.4

* duh, update channel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kaovilai kaovilai kaovilai approved these changes

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kaovilai kaovilai

@shubham-pampattiwar shubham-pampattiwar

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@weshayutin @openshift-ci-robot @kaovilai @jparrill @shubham-pampattiwar